Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0049393
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Modules] Open APImajoralways2022-05-24 18:382022-06-01 18:00
ReportervmromanosView Statuspublic 
Assigned ToTriage Platform Conn 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Statusapproved
Regression date
Regression introduced by commit
Regression level
Review Assigned To
Support ticket
OBNetwork customerNo
Regression introduced in release
Summary

0049393: Performance improvements in goods movement and physical inventory import

DescriptionAfter checking a yourkit snapshot (goods movement), it has been detected that the process is spending too much time trying to get the locator for each line.

For each line, the process queries the database to retrieve the locator. The query is very fast, but we might execute it many times (depending on the request size), so the total time is high.

The process can be easily optimized by having a cache (like we have with the lineNo calculation). So if the provided locator in the json is not in the cache, we will query the database and we will save the ID (or Proxy object) in the cache for next calculation.

Steps To ReproduceNA
Proposed SolutionReview ImportInventoryLineJavaPropertyMappingHandler and ImportGoodsMvmtLineJavaPropertyMappingHandler to implement a cache over the locator calculation
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to feature request 0049329 closedTriage Omni WMS Openbravo ERP Openbravo API to support Goods Movement 
related to feature request 0049155 closedTriage Omni WMS Openbravo ERP Openbravo API to support Physical Inventories 

-  Notes
(0137725)
hgbot (developer)
2022-05-25 15:10

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.api/-/merge_requests/52 [^]
(0137952)
hgbot (developer)
2022-06-01 18:00

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.api [^]
Changeset: 89dd26073e21611e955490eb405ddde2e44cf0c9
Author: Prakash M <prakash@qualiantech.com>
Date: 01-06-2022 16:00:44
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.api/-/commit/89dd26073e21611e955490eb405ddde2e44cf0c9 [^]

Fixes ISSUE-49393: Locator details are cached to avoid querying again and therefore improves performance

---
M src/org/openbravo/api/mappings/goodsmovementline/ImportGoodsMvmtLineJavaPropertyMappingHandler.java
M src/org/openbravo/api/mappings/inventoryline/ImportInventoryLineJavaPropertyMappingHandler.java
M src/org/openbravo/api/util/ApiUtils.java
---
(0137953)
hgbot (developer)
2022-06-01 18:00

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.api/-/merge_requests/52 [^]

- Issue History
Date Modified Username Field Change
2022-05-24 18:38 vmromanos New Issue
2022-05-24 18:38 vmromanos Assigned To => Triage Platform Conn
2022-05-24 18:38 vmromanos OBNetwork customer => No
2022-05-24 18:39 vmromanos Relationship added related to 0049329
2022-05-24 18:39 vmromanos Relationship added related to 0049155
2022-05-25 15:10 hgbot Merge Request Status => open
2022-05-25 15:10 hgbot Note Added: 0137725
2022-06-01 18:00 hgbot Merge Request Status open => approved
2022-06-01 18:00 hgbot Resolution open => fixed
2022-06-01 18:00 hgbot Status new => closed
2022-06-01 18:00 hgbot Note Added: 0137952
2022-06-01 18:00 hgbot Note Added: 0137953

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker