Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0049393ModulesOpen APIpublic2022-05-24 18:382022-06-01 18:00
Reportervmromanos 
Assigned ToTriage Platform Conn 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Statusapproved
Regression date
Regression introduced by commit
Regression level
Review Assigned To
Support ticket
OBNetwork customerNo
Regression introduced in release
Summary0049393: Performance improvements in goods movement and physical inventory import
DescriptionAfter checking a yourkit snapshot (goods movement), it has been detected that the process is spending too much time trying to get the locator for each line.

For each line, the process queries the database to retrieve the locator. The query is very fast, but we might execute it many times (depending on the request size), so the total time is high.

The process can be easily optimized by having a cache (like we have with the lineNo calculation). So if the provided locator in the json is not in the cache, we will query the database and we will save the ID (or Proxy object) in the cache for next calculation.

Steps To ReproduceNA
Proposed SolutionReview ImportInventoryLineJavaPropertyMappingHandler and ImportGoodsMvmtLineJavaPropertyMappingHandler to implement a cache over the locator calculation
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0049329 closed Triage Omni WMS Openbravo ERP Openbravo API to support Goods Movement 
related to feature request 0049155 closed Triage Omni WMS Openbravo ERP Openbravo API to support Physical Inventories 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2022-05-24 18:38vmromanosNew Issue
2022-05-24 18:38vmromanosAssigned To => Triage Platform Conn
2022-05-24 18:38vmromanosOBNetwork customer => No
2022-05-24 18:39vmromanosRelationship addedrelated to 0049329
2022-05-24 18:39vmromanosRelationship addedrelated to 0049155
2022-05-25 15:10hgbotMerge Request Status => open
2022-05-25 15:10hgbotNote Added: 0137725
2022-06-01 18:00hgbotMerge Request Statusopen => approved
2022-06-01 18:00hgbotResolutionopen => fixed
2022-06-01 18:00hgbotStatusnew => closed
2022-06-01 18:00hgbotNote Added: 0137952
2022-06-01 18:00hgbotNote Added: 0137953

Notes
(0137725)
hgbot   
2022-05-25 15:10   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.api/-/merge_requests/52 [^]
(0137952)
hgbot   
2022-06-01 18:00   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.api [^]
Changeset: 89dd26073e21611e955490eb405ddde2e44cf0c9
Author: Prakash M <prakash@qualiantech.com>
Date: 01-06-2022 16:00:44
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.api/-/commit/89dd26073e21611e955490eb405ddde2e44cf0c9 [^]

Fixes ISSUE-49393: Locator details are cached to avoid querying again and therefore improves performance

---
M src/org/openbravo/api/mappings/goodsmovementline/ImportGoodsMvmtLineJavaPropertyMappingHandler.java
M src/org/openbravo/api/mappings/inventoryline/ImportInventoryLineJavaPropertyMappingHandler.java
M src/org/openbravo/api/util/ApiUtils.java
---
(0137953)
hgbot   
2022-06-01 18:00   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.api/-/merge_requests/52 [^]