Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0049259 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Modules] Openbravo Business API | minor | have not tried | 2022-05-09 09:38 | 2022-05-10 11:11 | |||
| Reporter | caristu | View Status | public | |||||
| Assigned To | caristu | |||||||
| Priority | immediate | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Regression date | ||||||||
| Regression introduced by commit | ||||||||
| Regression level | ||||||||
| Review Assigned To | ||||||||
| Regression introduced in release | ||||||||
| Summary | 0049259: Some configuration pool tests fail in Oracle | |||||||
| Description | Some configuration pool tests fail in Oracle[1]. This is because the partial definition of the EM_API_DPS_ENT_MAP_ID_UNIQUE index is not applied in Oracle, which is preventing to save records with the same entity mapping although they have different filters. Note that the purpose of this index is to prevent the save/update operation when it detects duplicated records with the same entity mapping and without a filter. [1] https://builds.openbravo.com/job/mod-simple/48919/ [^] | |||||||
| Steps To Reproduce | . | |||||||
| Proposed Solution | Replace that index with a trigger which should work both in Postgres and Oracle | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0137068) hgbot (developer) 2022-05-09 09:41 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.api/-/merge_requests/36 [^] |
|
(0137072) hgbot (developer) 2022-05-09 11:40 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.api [^] Changeset: 93094739612f243d984dc9eb591b60f936d7b7f2 Author: Carlos Aristu <carlos.aristu@openbravo.com> Date: 09-05-2022 11:38:39 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.api/-/commit/93094739612f243d984dc9eb591b60f936d7b7f2 [^] fixes BUG-49259: replace index with a trigger that works in Oracle The partial index definition of the EM_API_DPS_ENT_MAP_ID_UNIQUE index is not valid in Oracle, because as the partial index definition does not apply the index was preventing saving two data pool configuration records for the same entity mapping, even if they define different filters. The purpose of this index was to prevent saving or updating duplicated records with the same entity mapping and null export filter. So we are replacing this index with a trigger that works both in Postgres and Oracle. Apart from this, the tests that were failing in Oracle for this cause are no longer ignored and the SelectionPoolConfigurationTest is repackaged to a more suitable package according to the functionality it is covering. --- A src-db/database/model/triggers/API_DATA_POOL_SEL_TRG.xml A src-test/org/openbravo/dal/service/SelectionPoolConfigurationTest.java M src-db/database/model/modifiedTables/OBUIAPP_DATA_POOL_SEL.xml M src-db/database/sourcedata/AD_MESSAGE.xml M src-test/org/openbravo/api/StandaloneTestSuite.java M src-test/org/openbravo/dal/service/DataPoolCheckerBusinessAPITest.java --- |
|
(0137095) hgbot (developer) 2022-05-09 17:11 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.api [^] Changeset: e9ac1664df594c53baf22eeebca003fee49f8d26 Author: Carlos Aristu <carlos.aristu@openbravo.com> Date: 09-05-2022 17:10:54 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.api/-/commit/e9ac1664df594c53baf22eeebca003fee49f8d26 [^] related to BUG-49259: define trigger as after to avoid ORA-04091 mutating table error --- M src-db/database/model/triggers/API_DATA_POOL_SEL_TRG.xml --- |
|
(0137096) caristu (manager) 2022-05-09 17:12 edited on: 2022-05-09 17:12 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.api/-/merge_requests/36 [^] |
|
(0137100) hgbot (developer) 2022-05-09 19:22 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.api [^] Changeset: d8dff5310f169baf66fbbe5658d57cd91d4b5a2b Author: Carlos Aristu <carlos.aristu@openbravo.com> Date: 09-05-2022 19:22:42 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.api/-/commit/d8dff5310f169baf66fbbe5658d57cd91d4b5a2b [^] related to BUG-49259: redefine trigger to avoid ORA-04091 mutating table error --- M src-db/database/model/triggers/API_DATA_POOL_SEL_TRG.xml --- |
|
(0137106) hgbot (developer) 2022-05-10 08:18 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.api [^] Changeset: 2935f4b1dff237f5fb27d91073cf4a40e26b0401 Author: Carlos Aristu <carlos.aristu@openbravo.com> Date: 10-05-2022 08:18:45 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.api/-/commit/2935f4b1dff237f5fb27d91073cf4a40e26b0401 [^] related to BUG-49259: set trigger at statement level and keep it simpler --- M src-db/database/model/triggers/API_DATA_POOL_SEL_TRG.xml --- |
|
(0137111) hgbot (developer) 2022-05-10 11:11 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.api [^] Changeset: 8a1b02b9046bf84a4264338c7032502f4c9288b6 Author: Carlos Aristu <carlos.aristu@openbravo.com> Date: 10-05-2022 11:11:05 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.api/-/commit/8a1b02b9046bf84a4264338c7032502f4c9288b6 [^] related to BUG-49259: expected message in Oracle is different --- M src-test/org/openbravo/dal/service/SelectionPoolConfigurationTest.java --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2022-05-09 09:38 | caristu | New Issue | |
| 2022-05-09 09:38 | caristu | Assigned To | => Triage Platform Conn |
| 2022-05-09 09:41 | hgbot | Note Added: 0137068 | |
| 2022-05-09 09:45 | caristu | Description Updated | View Revisions |
| 2022-05-09 09:52 | caristu | Relationship added | caused by 0049040 |
| 2022-05-09 09:52 | caristu | Assigned To | Triage Platform Conn => caristu |
| 2022-05-09 09:52 | caristu | Priority | high => immediate |
| 2022-05-09 09:52 | caristu | Status | new => scheduled |
| 2022-05-09 11:40 | hgbot | Resolution | open => fixed |
| 2022-05-09 11:40 | hgbot | Status | scheduled => closed |
| 2022-05-09 11:40 | hgbot | Note Added: 0137072 | |
| 2022-05-09 11:40 | hgbot | Note Added: 0137073 | |
| 2022-05-09 17:11 | hgbot | Note Added: 0137095 | |
| 2022-05-09 17:12 | caristu | Note Deleted: 0137073 | |
| 2022-05-09 17:12 | caristu | Note Added: 0137096 | |
| 2022-05-09 17:12 | caristu | Note Edited: 0137096 | View Revisions |
| 2022-05-09 19:22 | hgbot | Note Added: 0137100 | |
| 2022-05-10 08:18 | hgbot | Note Added: 0137106 | |
| 2022-05-10 11:11 | hgbot | Note Added: 0137111 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |