Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0049259ModulesOpenbravo Business APIpublic2022-05-09 09:382022-05-10 11:11
Reportercaristu 
Assigned Tocaristu 
PriorityimmediateSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned To
Support ticket
OBNetwork customer
Regression introduced in release
Summary0049259: Some configuration pool tests fail in Oracle
DescriptionSome configuration pool tests fail in Oracle[1]. This is because the partial definition of the EM_API_DPS_ENT_MAP_ID_UNIQUE index is not applied in Oracle, which is preventing to save records with the same entity mapping although they have different filters.

Note that the purpose of this index is to prevent the save/update operation when it detects duplicated records with the same entity mapping and without a filter.

[1] https://builds.openbravo.com/job/mod-simple/48919/ [^]
Steps To Reproduce.
Proposed SolutionReplace that index with a trigger which should work both in Postgres and Oracle
Additional Information
TagsNo tags attached.
Relationships
caused by feature request 0049040 closed njimenez Improve ApiExporter to make readonly pool usage configurable 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2022-05-09 09:38caristuNew Issue
2022-05-09 09:38caristuAssigned To => Triage Platform Conn
2022-05-09 09:41hgbotNote Added: 0137068
2022-05-09 09:45caristuDescription Updatedbug_revision_view_page.php?rev_id=24037#r24037
2022-05-09 09:52caristuRelationship addedcaused by 0049040
2022-05-09 09:52caristuAssigned ToTriage Platform Conn => caristu
2022-05-09 09:52caristuPriorityhigh => immediate
2022-05-09 09:52caristuStatusnew => scheduled
2022-05-09 11:40hgbotResolutionopen => fixed
2022-05-09 11:40hgbotStatusscheduled => closed
2022-05-09 11:40hgbotNote Added: 0137072
2022-05-09 11:40hgbotNote Added: 0137073
2022-05-09 17:11hgbotNote Added: 0137095
2022-05-09 17:12caristuNote Deleted: 0137073
2022-05-09 17:12caristuNote Added: 0137096
2022-05-09 17:12caristuNote Edited: 0137096bug_revision_view_page.php?bugnote_id=0137096#r24064
2022-05-09 19:22hgbotNote Added: 0137100
2022-05-10 08:18hgbotNote Added: 0137106
2022-05-10 11:11hgbotNote Added: 0137111

Notes
(0137068)
hgbot   
2022-05-09 09:41   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.api/-/merge_requests/36 [^]
(0137072)
hgbot   
2022-05-09 11:40   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.api [^]
Changeset: 93094739612f243d984dc9eb591b60f936d7b7f2
Author: Carlos Aristu <carlos.aristu@openbravo.com>
Date: 09-05-2022 11:38:39
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.api/-/commit/93094739612f243d984dc9eb591b60f936d7b7f2 [^]

fixes BUG-49259: replace index with a trigger that works in Oracle

  The partial index definition of the EM_API_DPS_ENT_MAP_ID_UNIQUE index
is not valid in Oracle, because as the partial index definition does not
apply the index was preventing saving two data pool configuration
records for the same entity mapping, even if they define different filters.

  The purpose of this index was to prevent saving or updating
duplicated records with the same entity mapping and null export filter.
So we are replacing this index with a trigger that works both in
Postgres and Oracle.

  Apart from this, the tests that were failing in Oracle for this cause
are no longer ignored and the SelectionPoolConfigurationTest is
repackaged to a more suitable package according to the functionality it
is covering.

---
A src-db/database/model/triggers/API_DATA_POOL_SEL_TRG.xml
A src-test/org/openbravo/dal/service/SelectionPoolConfigurationTest.java
M src-db/database/model/modifiedTables/OBUIAPP_DATA_POOL_SEL.xml
M src-db/database/sourcedata/AD_MESSAGE.xml
M src-test/org/openbravo/api/StandaloneTestSuite.java
M src-test/org/openbravo/dal/service/DataPoolCheckerBusinessAPITest.java
---
(0137095)
hgbot   
2022-05-09 17:11   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.api [^]
Changeset: e9ac1664df594c53baf22eeebca003fee49f8d26
Author: Carlos Aristu <carlos.aristu@openbravo.com>
Date: 09-05-2022 17:10:54
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.api/-/commit/e9ac1664df594c53baf22eeebca003fee49f8d26 [^]

related to BUG-49259: define trigger as after to avoid ORA-04091 mutating table error

---
M src-db/database/model/triggers/API_DATA_POOL_SEL_TRG.xml
---
(0137096)
caristu   
2022-05-09 17:12   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.api/-/merge_requests/36 [^]
(0137100)
hgbot   
2022-05-09 19:22   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.api [^]
Changeset: d8dff5310f169baf66fbbe5658d57cd91d4b5a2b
Author: Carlos Aristu <carlos.aristu@openbravo.com>
Date: 09-05-2022 19:22:42
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.api/-/commit/d8dff5310f169baf66fbbe5658d57cd91d4b5a2b [^]

related to BUG-49259: redefine trigger to avoid ORA-04091 mutating table error

---
M src-db/database/model/triggers/API_DATA_POOL_SEL_TRG.xml
---
(0137106)
hgbot   
2022-05-10 08:18   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.api [^]
Changeset: 2935f4b1dff237f5fb27d91073cf4a40e26b0401
Author: Carlos Aristu <carlos.aristu@openbravo.com>
Date: 10-05-2022 08:18:45
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.api/-/commit/2935f4b1dff237f5fb27d91073cf4a40e26b0401 [^]

related to BUG-49259: set trigger at statement level and keep it simpler

---
M src-db/database/model/triggers/API_DATA_POOL_SEL_TRG.xml
---
(0137111)
hgbot   
2022-05-10 11:11   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.api [^]
Changeset: 8a1b02b9046bf84a4264338c7032502f4c9288b6
Author: Carlos Aristu <carlos.aristu@openbravo.com>
Date: 10-05-2022 11:11:05
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.api/-/commit/8a1b02b9046bf84a4264338c7032502f4c9288b6 [^]

related to BUG-49259: expected message in Oracle is different

---
M src-test/org/openbravo/dal/service/SelectionPoolConfigurationTest.java
---