Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0049243
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 01. General setupmajorhave not tried2022-05-06 09:232022-05-27 07:29
ReportershankarbView Statuspublic 
Assigned ToAugustoMauch 
PrioritynormalResolutionfixedFixed in VersionPR22Q3
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSLinux 64 bitDatabasePostgreSQLJava version7.x
OS VersionOpenbravo Appliance 14.04Database version9.3.xAnt version1.9.x
Product VersionSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0049243: User window - Backslash automatically added when string contains single quotes

DescriptionIn the User window, if the first name or last name field contains single quote, in the Name field, backslash is added. This is coming from the code present in src/org/openbravo/erpCommon/ad_callouts/SL_User_Name.java.
Steps To Reproduce1. Go to User window
2. Create new record
3. In first name or last name, enter string with single quotes like Test'abc
4. Notice that in the Name field the value is Test\'abc.
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0137710)
hgbot (developer)
2022-05-25 09:42

Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/602 [^]
(0137794)
hgbot (developer)
2022-05-27 07:29

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 3dfbc3882fdc3e0a24f80621e9e5710a5d9b6d04
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 27-05-2022 05:28:57
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/3dfbc3882fdc3e0a24f80621e9e5710a5d9b6d04 [^]

Fixes ISSUE-49243: Quotes in the username should not be escaped

Escaping some characters used to be needed because the callout response was returned as executable javascript [1]. That changed some releases ago,
now the result is returned in a JSON object so there is no longer need to escape those characters.

[1] https://gitlab.com/openbravo/product/openbravo/-/blame/e54fe6a48d100ee2264470cf1583462645508076/src/org/openbravo/erpCommon/ad_callouts/SL_User_Name.java\#L82 [^]

---
M src/org/openbravo/erpCommon/ad_callouts/SL_User_Name.java
---
(0137795)
hgbot (developer)
2022-05-27 07:29

Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/602 [^]

- Issue History
Date Modified Username Field Change
2022-05-06 09:23 shankarb New Issue
2022-05-06 09:23 shankarb Assigned To => Triage Omni OMS
2022-05-06 09:23 shankarb Modules => Core
2022-05-06 09:23 shankarb Triggers an Emergency Pack => No
2022-05-09 10:59 shankarb Severity minor => major
2022-05-18 15:12 AugustoMauch Assigned To Triage Omni OMS => Triage Platform Base
2022-05-18 15:19 AugustoMauch Status new => acknowledged
2022-05-25 09:30 AugustoMauch Assigned To Triage Platform Base => AugustoMauch
2022-05-25 09:30 AugustoMauch Status acknowledged => scheduled
2022-05-25 09:42 hgbot Note Added: 0137710
2022-05-27 07:29 hgbot Resolution open => fixed
2022-05-27 07:29 hgbot Status scheduled => closed
2022-05-27 07:29 hgbot Fixed in Version => PR22Q3
2022-05-27 07:29 hgbot Note Added: 0137794
2022-05-27 07:29 hgbot Note Added: 0137795


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker