Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0049243Openbravo ERP01. General setuppublic2022-05-06 09:232022-05-27 07:29
Reportershankarb 
Assigned ToAugustoMauch 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS30OS VersionOpenbravo Appliance 14.04
Product Version 
Target VersionFixed in VersionPR22Q3 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0049243: User window - Backslash automatically added when string contains single quotes
DescriptionIn the User window, if the first name or last name field contains single quote, in the Name field, backslash is added. This is coming from the code present in src/org/openbravo/erpCommon/ad_callouts/SL_User_Name.java.
Steps To Reproduce1. Go to User window
2. Create new record
3. In first name or last name, enter string with single quotes like Test'abc
4. Notice that in the Name field the value is Test\'abc.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2022-05-06 09:23shankarbNew Issue
2022-05-06 09:23shankarbAssigned To => Triage Omni OMS
2022-05-06 09:23shankarbModules => Core
2022-05-06 09:23shankarbTriggers an Emergency Pack => No
2022-05-09 10:59shankarbSeverityminor => major
2022-05-18 15:12AugustoMauchAssigned ToTriage Omni OMS => Triage Platform Base
2022-05-18 15:19AugustoMauchStatusnew => acknowledged
2022-05-25 09:30AugustoMauchAssigned ToTriage Platform Base => AugustoMauch
2022-05-25 09:30AugustoMauchStatusacknowledged => scheduled
2022-05-25 09:42hgbotNote Added: 0137710
2022-05-27 07:29hgbotResolutionopen => fixed
2022-05-27 07:29hgbotStatusscheduled => closed
2022-05-27 07:29hgbotFixed in Version => PR22Q3
2022-05-27 07:29hgbotNote Added: 0137794
2022-05-27 07:29hgbotNote Added: 0137795

Notes
(0137710)
hgbot   
2022-05-25 09:42   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/602 [^]
(0137794)
hgbot   
2022-05-27 07:29   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 3dfbc3882fdc3e0a24f80621e9e5710a5d9b6d04
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 27-05-2022 05:28:57
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/3dfbc3882fdc3e0a24f80621e9e5710a5d9b6d04 [^]

Fixes ISSUE-49243: Quotes in the username should not be escaped

Escaping some characters used to be needed because the callout response was returned as executable javascript [1]. That changed some releases ago,
now the result is returned in a JSON object so there is no longer need to escape those characters.

[1] https://gitlab.com/openbravo/product/openbravo/-/blame/e54fe6a48d100ee2264470cf1583462645508076/src/org/openbravo/erpCommon/ad_callouts/SL_User_Name.java\#L82 [^]

---
M src/org/openbravo/erpCommon/ad_callouts/SL_User_Name.java
---
(0137795)
hgbot   
2022-05-27 07:29   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/602 [^]