Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0048923
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[POS2] Coremajorhave not tried2022-03-29 13:472022-05-10 12:35
Reporterjorge-garciaView Statuspublic 
Assigned Toablasco 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0048923: useEditNumber is not working fine if used with a keypad and minimum amount has two or more digits

DescriptionuseEditNumber hook is not working fine if used with a keypad and minimum amount has two or more digits
Steps To ReproduceBy code, select a keypad that uses useEditNumber hook (i.e. PaymentPanel.jsx component) and force that minValue to be a number with two digits(i.e. 40) and maxValue to a number of three digits (i.e. 100)

In POS2 application, open the keypad that uses the useEditNumber you just changed.

Try to add 45 in the input using the keypad buttons and verify it is not possible as you enter the '4' the input changes to 40 and clicking on 5 the input changes to 100
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
related to feature request 0049047 newTriage Platform Base Message in Payment input when quantity is not allowed 
causes defect 0049268 closedablasco TypeError after matching Initial Count after use  

-  Notes
(0136252)
hgbot (developer)
2022-04-01 12:35

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/727 [^]
(0136965)
hgbot (developer)
2022-05-05 11:12

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: a2ccac66e2463cc5835f525caad36abe4a94ee7c
Author: adrian.blasco <adrian.blasco@openbravo.com>
Date: 05-05-2022 10:05:05
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/a2ccac66e2463cc5835f525caad36abe4a94ee7c [^]

Fixes ISSUE-48923: minValue and maxValue is checked when Focus is out from Input in Keypad; also working via Keyboard

---
M web-jspack/org.openbravo.core2/src/hooks/useEditNumber/useEditNumber.js
---
(0136966)
hgbot (developer)
2022-05-05 11:12

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 365632fd42e6b4d67d98c04530945214e4cb7b5d
Author: Javier Armendáriz <javier.armendariz@openbravo.com>
Date: 05-05-2022 10:54:27
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/365632fd42e6b4d67d98c04530945214e4cb7b5d [^]

Related to ISSUE-48923: Number update after validation is performed only when the value actually changes to avoid unnecessary rerenders

---
M web-jspack/org.openbravo.core2/src/hooks/useEditNumber/useEditNumber.js
---
(0136967)
hgbot (developer)
2022-05-05 11:12

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/727 [^]
(0136982)
hgbot (developer)
2022-05-05 16:11

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/743 [^]
(0136983)
hgbot (developer)
2022-05-05 16:28

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: eeef890c569332eedfb9b47a56a63a7624016a3d
Author: adrian.blasco <adrian.blasco@openbravo.com>
Date: 05-05-2022 16:09:20
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/eeef890c569332eedfb9b47a56a63a7624016a3d [^]

Related to ISSUE-48923 - Fixing update,delete Events in useEditNumber

---
M web-jspack/org.openbravo.core2/src/hooks/useEditNumber/useEditNumber.js
---
(0136984)
hgbot (developer)
2022-05-05 16:28

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/743 [^]
(0137101)
hgbot (developer)
2022-05-09 22:03

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/746 [^]
(0137119)
hgbot (developer)
2022-05-10 12:35

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: a8211146c530c062d5554d01c1d1d5ae437483d9
Author: adrian.blasco <adrian.blasco@openbravo.com>
Date: 10-05-2022 10:35:42
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/a8211146c530c062d5554d01c1d1d5ae437483d9 [^]

Related to ISSUE-48923 - Solve Cypress Test case in useEditNumber due to null value

Conditional null

---
M web-jspack/org.openbravo.core2/src/hooks/useEditNumber/useEditNumber.js
---
(0137120)
hgbot (developer)
2022-05-10 12:35

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/746 [^]

- Issue History
Date Modified Username Field Change
2022-03-29 13:47 jorge-garcia New Issue
2022-03-29 13:47 jorge-garcia Assigned To => Triage Platform Base
2022-03-29 13:47 jorge-garcia Triggers an Emergency Pack => No
2022-03-29 17:39 AugustoMauch Assigned To Triage Platform Base => ablasco
2022-03-29 17:39 AugustoMauch Status new => scheduled
2022-04-01 12:35 hgbot Note Added: 0136252
2022-04-20 14:53 ablasco Relationship added related to 0049047
2022-05-05 11:12 hgbot Resolution open => fixed
2022-05-05 11:12 hgbot Status scheduled => closed
2022-05-05 11:12 hgbot Note Added: 0136965
2022-05-05 11:12 hgbot Note Added: 0136966
2022-05-05 11:12 hgbot Note Added: 0136967
2022-05-05 16:11 hgbot Note Added: 0136982
2022-05-05 16:28 hgbot Note Added: 0136983
2022-05-05 16:28 hgbot Note Added: 0136984
2022-05-09 15:16 andre_montenegro Relationship added causes 0049268
2022-05-09 22:03 hgbot Note Added: 0137101
2022-05-10 12:35 hgbot Note Added: 0137119
2022-05-10 12:35 hgbot Note Added: 0137120


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker