Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0048923POS2Corepublic2022-03-29 13:472022-05-10 12:35
Reporterjorge-garcia 
Assigned Toablasco 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0048923: useEditNumber is not working fine if used with a keypad and minimum amount has two or more digits
DescriptionuseEditNumber hook is not working fine if used with a keypad and minimum amount has two or more digits
Steps To ReproduceBy code, select a keypad that uses useEditNumber hook (i.e. PaymentPanel.jsx component) and force that minValue to be a number with two digits(i.e. 40) and maxValue to a number of three digits (i.e. 100)

In POS2 application, open the keypad that uses the useEditNumber you just changed.

Try to add 45 in the input using the keypad buttons and verify it is not possible as you enter the '4' the input changes to 40 and clicking on 5 the input changes to 100
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0049047 new Triage Platform Base Message in Payment input when quantity is not allowed 
causes defect 0049268 closed ablasco TypeError after matching Initial Count after use  
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2022-03-29 13:47jorge-garciaNew Issue
2022-03-29 13:47jorge-garciaAssigned To => Triage Platform Base
2022-03-29 13:47jorge-garciaTriggers an Emergency Pack => No
2022-03-29 17:39AugustoMauchAssigned ToTriage Platform Base => ablasco
2022-03-29 17:39AugustoMauchStatusnew => scheduled
2022-04-01 12:35hgbotNote Added: 0136252
2022-04-20 14:53ablascoRelationship addedrelated to 0049047
2022-05-05 11:12hgbotResolutionopen => fixed
2022-05-05 11:12hgbotStatusscheduled => closed
2022-05-05 11:12hgbotNote Added: 0136965
2022-05-05 11:12hgbotNote Added: 0136966
2022-05-05 11:12hgbotNote Added: 0136967
2022-05-05 16:11hgbotNote Added: 0136982
2022-05-05 16:28hgbotNote Added: 0136983
2022-05-05 16:28hgbotNote Added: 0136984
2022-05-09 15:16andre_montenegroRelationship addedcauses 0049268
2022-05-09 22:03hgbotNote Added: 0137101
2022-05-10 12:35hgbotNote Added: 0137119
2022-05-10 12:35hgbotNote Added: 0137120

Notes
(0136252)
hgbot   
2022-04-01 12:35   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/727 [^]
(0136965)
hgbot   
2022-05-05 11:12   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: a2ccac66e2463cc5835f525caad36abe4a94ee7c
Author: adrian.blasco <adrian.blasco@openbravo.com>
Date: 05-05-2022 10:05:05
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/a2ccac66e2463cc5835f525caad36abe4a94ee7c [^]

Fixes ISSUE-48923: minValue and maxValue is checked when Focus is out from Input in Keypad; also working via Keyboard

---
M web-jspack/org.openbravo.core2/src/hooks/useEditNumber/useEditNumber.js
---
(0136966)
hgbot   
2022-05-05 11:12   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 365632fd42e6b4d67d98c04530945214e4cb7b5d
Author: Javier Armendáriz <javier.armendariz@openbravo.com>
Date: 05-05-2022 10:54:27
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/365632fd42e6b4d67d98c04530945214e4cb7b5d [^]

Related to ISSUE-48923: Number update after validation is performed only when the value actually changes to avoid unnecessary rerenders

---
M web-jspack/org.openbravo.core2/src/hooks/useEditNumber/useEditNumber.js
---
(0136967)
hgbot   
2022-05-05 11:12   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/727 [^]
(0136982)
hgbot   
2022-05-05 16:11   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/743 [^]
(0136983)
hgbot   
2022-05-05 16:28   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: eeef890c569332eedfb9b47a56a63a7624016a3d
Author: adrian.blasco <adrian.blasco@openbravo.com>
Date: 05-05-2022 16:09:20
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/eeef890c569332eedfb9b47a56a63a7624016a3d [^]

Related to ISSUE-48923 - Fixing update,delete Events in useEditNumber

---
M web-jspack/org.openbravo.core2/src/hooks/useEditNumber/useEditNumber.js
---
(0136984)
hgbot   
2022-05-05 16:28   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/743 [^]
(0137101)
hgbot   
2022-05-09 22:03   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/746 [^]
(0137119)
hgbot   
2022-05-10 12:35   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: a8211146c530c062d5554d01c1d1d5ae437483d9
Author: adrian.blasco <adrian.blasco@openbravo.com>
Date: 10-05-2022 10:35:42
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/a8211146c530c062d5554d01c1d1d5ae437483d9 [^]

Related to ISSUE-48923 - Solve Cypress Test case in useEditNumber due to null value

Conditional null

---
M web-jspack/org.openbravo.core2/src/hooks/useEditNumber/useEditNumber.js
---
(0137120)
hgbot   
2022-05-10 12:35   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/746 [^]