Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0048756 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] 09. Financial management | major | always | 2022-03-10 07:29 | 2022-04-20 09:41 | |||
| Reporter | alostale | View Status | public | |||||
| Assigned To | alostale | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | PR22Q2 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0048756: unnecesary OrganizationStructureProvider double initialization on ticket creation | |||||||
| Description | As reported in 0042370, OrganizationStructureProvider initialization has an important impact in the overall database performance. When creating tickets from the POS this initialization occurs twice per ticket: 1. Creating the context for processing the ticket (might be addressed by 0042370) 2. When obtaining document type (the goal of this issue). | |||||||
| Steps To Reproduce | In a retail instance: 1. Log in as System Admin and set debug log level to OrganizationStructureProvider 2. Log in POS and create one ticket 3. Check logs, there should be a single initialization there are two:
| |||||||
| Tags | Performance | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0135608) hgbot (developer) 2022-03-10 07:38 |
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/538 [^] |
|
(0135735) hgbot (developer) 2022-03-15 14:46 |
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/538 [^] |
|
(0135736) hgbot (developer) 2022-03-15 14:46 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/openbravo [^] Changeset: 8a9b434def6ead92f787335bf2fa88e60d6d4fdd Author: Asier Lostalé <asier.lostale@openbravo.com> Date: 15-03-2022 13:45:00 URL: https://gitlab.com/openbravo/product/openbravo/-/commit/8a9b434def6ead92f787335bf2fa88e60d6d4fdd [^] fixes BUG-48756: unnecesary OSP initialization in getDocumentType Whenever FIN_Utility.getDocumentType was invoked, OSP was initialized. In high volume environments, this causes a noticeable DB overhead in ticket creation. Instead of creating a new OSP instance which needs to be initialized, we now reuse the one from the context that is already initialized. --- M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/utility/FIN_Utility.java --- |
|
(0136615) plujan (manager) 2022-04-20 09:41 |
Please change the generic user to the actual person assigned when fixing an issue |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2022-03-10 07:29 | alostale | New Issue | |
| 2022-03-10 07:29 | alostale | Assigned To | => Triage Omni OMS |
| 2022-03-10 07:29 | alostale | Modules | => Core |
| 2022-03-10 07:29 | alostale | Triggers an Emergency Pack | => No |
| 2022-03-10 07:30 | alostale | Tag Attached: Performance | |
| 2022-03-10 07:30 | alostale | Relationship added | related to 0042370 |
| 2022-03-10 07:34 | alostale | Summary | unnecesary OrganizationStructureProvider initialization on ticket creation => unnecesary OrganizationStructureProvider double initialization on ticket creation |
| 2022-03-10 07:38 | hgbot | Note Added: 0135608 | |
| 2022-03-15 14:46 | hgbot | Resolution | open => fixed |
| 2022-03-15 14:46 | hgbot | Status | new => closed |
| 2022-03-15 14:46 | hgbot | Note Added: 0135735 | |
| 2022-03-15 14:46 | hgbot | Fixed in Version | => PR22Q2 |
| 2022-03-15 14:46 | hgbot | Note Added: 0135736 | |
| 2022-04-20 09:41 | plujan | Note Added: 0136615 | |
| 2022-04-20 09:41 | plujan | Assigned To | Triage Omni OMS => alostale |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |