Anonymous | Login
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformmajoralways2019-11-21 18:282022-05-03 08:57
Reportermauricio_peccoriniView Statuspublic 
Assigned ToAugustoMauch 
PriorityhighResolutionfixedFixed in VersionPR22Q3
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Web browser
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo

0042370: Unnecessary executions of a query that loads the complete organizational structure of a client

DescriptionCreation of new OBContexts or reinitialization of OrganizationStructureProviders cause many unnecessary executions of the query that loads the organizational tree of a client.
Steps To Reproduce- Set a breakpoint on line 95 of (List<Object[]> treeNodes = qry.list();)
- Perform regular actions like logging in from different accounts even on the same terminal, creating tickets and waiting for Import Entries to be processed. The breakpoint is hit for many of the actions and, for some of them, several times.
Proposed SolutionSince Import Entry reinitializes the available OrganizationStructureProviders it is not enough to cache those instances. Instead, the internal Map or organization nodes should be cached by client Id.

To manage the cases when the organization structure changes, a Business Entity Event Observer should be developed to listen changes to Organization and clear the cached maps when organizations are created, deleted or its relevant properties are updated. The properties are: PeriodControlAllowedOrganization, CalendarOwnerOrganization, BusinessUnitOrganization and LegalEntityOrganization.

Attached diffs with the proposed implementation.
Attached Filesdiff file icon OrganizationStructureProvider.diff [^] (6,948 bytes) 2019-11-21 18:45 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]
related to defect 0048756 closedalostale unnecesary OrganizationStructureProvider double initialization on ticket creation 

-  Notes
ioritzCia (developer)
2021-12-30 10:56

I would like to raise this issue again. We looked in two of hour biggest customers taking a look at pg_stat_statements and in one of them is the 2nd query reading the most and in the other the 9th. It is not that it is bad performant but it gets executed too often. In the first of the two customers around 200 times per minute, which does not make sense because the organization tree does not change as often.
ioritzCia (developer)
2022-03-09 15:16
edited on: 2022-03-09 15:17

In another review of the statistics. It was the 2nd in two of our biggest customers, the 9th in another. In on of the first two, analyzing the peak hour of the peak day it was 1st most reading query, it had read almost 6.5TB in that hour and it had an average execution of 72 times per second.

hgbot (developer)
2022-04-12 14:26

Merge Request created: [^]
hgbot (developer)
2022-05-03 08:57

Directly closing issue as related merge request is already approved.

Repository: [^]
Changeset: 2e14b5c56ecce6699486a10c6f8072b29cdabad8
Author: Augusto Mauch <>
Date: 03-05-2022 06:39:21
URL: [^]

Fixes ISSUE-42370: OrganizationStructureProvider caches the organization node data

Now the organization node data will be stored in a TimeInvalidatedCache so that it is cached but periodically recalculated (current
periodicity is 5 minutes). Users of OrganizationStructureProvider that used to invoke the reinitialize method no longer do it unless
they really require an updated org info (only use cases were tests that invoked assertPersistOrgInfo to ensure the OrganizationStructureProvider
reflected the changes they just did to the organization structure and InitialOrgSetup, right after creating a new organization).

A src/org/openbravo/dal/security/
M src/org/openbravo/dal/security/
M src/org/openbravo/erpCommon/ad_forms/
M src/org/openbravo/service/importprocess/
hgbot (developer)
2022-05-03 08:57

Merge request merged: [^]

- Issue History
Date Modified Username Field Change
2019-11-21 18:28 mauricio_peccorini New Issue
2019-11-21 18:28 mauricio_peccorini Assigned To => platform
2019-11-21 18:28 mauricio_peccorini File Added: OrganizationStructureProvider.diff
2019-11-21 18:28 mauricio_peccorini Modules => Core
2019-11-21 18:28 mauricio_peccorini Triggers an Emergency Pack => No
2019-11-21 18:45 mauricio_peccorini File Deleted: OrganizationStructureProvider.diff
2019-11-21 18:45 mauricio_peccorini File Added: OrganizationStructureProvider.diff
2019-12-26 11:18 AugustoMauch Assigned To platform => mauricio_peccorini
2020-08-14 16:41 ALopetegui Issue Monitored: ALopetegui
2020-08-14 16:43 ALopetegui Tag Attached: Performance
2021-12-30 10:38 AugustoMauch Assigned To mauricio_peccorini => AugustoMauch
2021-12-30 10:56 ioritzCia Note Added: 0134069
2022-02-01 07:24 alostale Assigned To AugustoMauch => Triage Platform Base
2022-03-09 15:16 ioritzCia Note Added: 0135593
2022-03-09 15:17 ioritzCia Note Edited: 0135593 View Revisions
2022-03-10 07:30 alostale Relationship added related to 0048756
2022-03-11 13:05 AugustoMauch Assigned To Triage Platform Base => cberner
2022-03-11 13:05 AugustoMauch Status new => scheduled
2022-04-07 15:51 AugustoMauch Assigned To cberner => AugustoMauch
2022-04-12 14:26 hgbot Note Added: 0136491
2022-05-03 08:57 hgbot Resolution open => fixed
2022-05-03 08:57 hgbot Status scheduled => closed
2022-05-03 08:57 hgbot Fixed in Version => PR22Q3
2022-05-03 08:57 hgbot Note Added: 0136895
2022-05-03 08:57 hgbot Note Added: 0136896

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker