Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0048713 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo Localizations] Localization Portugal | major | have not tried | 2022-03-03 14:09 | 2022-03-08 09:59 | |||
| Reporter | aferraz | View Status | public | |||||
| Assigned To | jorge-garcia | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | approved | |||||||
| Regression date | ||||||||
| Regression introduced by commit | ||||||||
| Regression level | ||||||||
| Support ticket | ||||||||
| OBNetwork customer | No | |||||||
| Regression introduced in release | ||||||||
| Summary | 0048713: Original document number must be included in ticket description also when using Return Line | |||||||
| Description | The only way to create a blind return in Portugal is adding the document number of the original sale into the return description. This way, the original document number is printed in the return receipt and informed in the SAFT file (0047721). Currently, we only validate description in case of doing Return this Receipt (orderType=1), but this menu button is hidden in Portugal terminals and Return Line button is being used for doing blind returns. - We need to do the validation also in case of doing Return Line. - We need to display Return this Receipt menu button as it is allowed in case original document number is informed. | |||||||
| Steps To Reproduce | In WebPOS create a ticket and add any product. Check Return this Receipt button is not shown in the menu. Select the line and click on Return Line button. Complete the ticket and check description has not been validated. | |||||||
| Proposed Solution | Remove receipt.get('orderType') === 1 condition from description validation in order to do it in case we have a negative line and it is not a verified return: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt.retail/-/blob/master/web/com.practicsbs.saftpt.retail/js/hooks/prepayment.js#L16 [^] Remove the piece of code that hides Return this Receipt menu button: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt.retail/-/blob/master/web/com.practicsbs.saftpt.retail/js/components/modifycomponents.js#L11 [^] and https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt.retail/-/blob/master/web/com.practicsbs.saftpt.retail/js/hooks/loadterminal.js#L35 [^] | |||||||
| Tags | NOR | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0135469) hgbot (developer) 2022-03-04 12:14 edited on: 2022-03-04 12:14 |
Merge Request created for 20Q3: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt.retail/-/merge_requests/33 [^] |
|
(0135470) hgbot (developer) 2022-03-04 12:24 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt.retail/-/merge_requests/34 [^] |
|
(0135541) hgbot (developer) 2022-03-08 09:57 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt.retail [^] Changeset: 6798323277e90b8b7b2dd5db19a1a97621c06b57 Author: Jorge García <jorge.garcia@openbravo.com> Date: 08-03-2022 08:57:44 URL: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt.retail/-/commit/6798323277e90b8b7b2dd5db19a1a97621c06b57 [^] Fixed ISSUE-48713: Show return this receipt button and verify saft ticket description for blind returns --- M web/com.practicsbs.saftpt.retail/js/components/modifycomponents.js M web/com.practicsbs.saftpt.retail/js/hooks/loadterminal.js M web/com.practicsbs.saftpt.retail/js/hooks/prepayment.js --- |
|
(0135542) hgbot (developer) 2022-03-08 09:57 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt.retail/-/merge_requests/34 [^] |
|
(0135543) hgbot (developer) 2022-03-08 09:59 |
Repository: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt.retail [^] Changeset: 76a198f16d06b011e389cb4be47439ff12d46805 Author: Jorge García <jorge.garcia@openbravo.com> Date: 08-03-2022 08:59:03 URL: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt.retail/-/commit/76a198f16d06b011e389cb4be47439ff12d46805 [^] Related to ISSUE-48713 [20Q3]: Show return this receipt button and verify saft ticket description for blind returns --- M web/com.practicsbs.saftpt.retail/js/components/modifycomponents.js M web/com.practicsbs.saftpt.retail/js/hooks/loadterminal.js M web/com.practicsbs.saftpt.retail/js/hooks/prepayment.js --- |
|
(0135544) hgbot (developer) 2022-03-08 09:59 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt.retail/-/merge_requests/33 [^] |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2022-03-03 14:09 | aferraz | New Issue | |
| 2022-03-03 14:09 | aferraz | Assigned To | => Triage Omni OMS |
| 2022-03-03 14:09 | aferraz | OBNetwork customer | => No |
| 2022-03-03 14:18 | aferraz | Proposed Solution updated | |
| 2022-03-03 14:23 | aferraz | Relationship added | related to 0047721 |
| 2022-03-03 15:50 | rafaroda | Tag Attached: NOR | |
| 2022-03-03 16:08 | aferraz | Assigned To | Triage Omni OMS => jorge-garcia |
| 2022-03-04 11:37 | jorge-garcia | Status | new => scheduled |
| 2022-03-04 12:14 | hgbot | Merge Request Status | => open |
| 2022-03-04 12:14 | hgbot | Note Added: 0135469 | |
| 2022-03-04 12:14 | jorge-garcia | Note Edited: 0135469 | View Revisions |
| 2022-03-04 12:24 | hgbot | Note Added: 0135470 | |
| 2022-03-08 09:24 | aferraz | Proposed Solution updated | |
| 2022-03-08 09:57 | hgbot | Merge Request Status | open => approved |
| 2022-03-08 09:57 | hgbot | Resolution | open => fixed |
| 2022-03-08 09:57 | hgbot | Status | scheduled => closed |
| 2022-03-08 09:57 | hgbot | Note Added: 0135541 | |
| 2022-03-08 09:57 | hgbot | Note Added: 0135542 | |
| 2022-03-08 09:59 | hgbot | Note Added: 0135543 | |
| 2022-03-08 09:59 | hgbot | Note Added: 0135544 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |