0048713: Original document number must be included in ticket description also when using Return Line

Openbravo Issue Tracking System - Openbravo Localizations

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0048713

Openbravo Localizations

Localization Portugal

public

2022-03-03 14:09

2022-03-08 09:59

Reporter

aferraz

Assigned To

jorge-garcia

Priority

normal

Severity

major

Reproducibility

have not tried

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

Merge Request Status

approved

Regression date

Regression introduced by commit

Regression level

Support ticket

OBNetwork customer

Regression introduced in release

Summary

0048713: Original document number must be included in ticket description also when using Return Line

Description

The only way to create a blind return in Portugal is adding the document number of the original sale into the return description.
This way, the original document number is printed in the return receipt and informed in the SAFT file (0047721).

Currently, we only validate description in case of doing Return this Receipt (orderType=1), but this menu button is hidden in Portugal terminals and Return Line button is being used for doing blind returns.
- We need to do the validation also in case of doing Return Line.
- We need to display Return this Receipt menu button as it is allowed in case original document number is informed.

Steps To Reproduce

In WebPOS create a ticket and add any product.
Check Return this Receipt button is not shown in the menu.
Select the line and click on Return Line button.
Complete the ticket and check description has not been validated.

Proposed Solution

Remove receipt.get('orderType') === 1 condition from description validation in order to do it in case we have a negative line and it is not a verified return: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt.retail/-/blob/master/web/com.practicsbs.saftpt.retail/js/hooks/prepayment.js#L16 [^]

Remove the piece of code that hides Return this Receipt menu button: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt.retail/-/blob/master/web/com.practicsbs.saftpt.retail/js/components/modifycomponents.js#L11 [^] and https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt.retail/-/blob/master/web/com.practicsbs.saftpt.retail/js/hooks/loadterminal.js#L35 [^]

Additional Information