Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0048659
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 02. Master data managementminoralways2022-02-23 15:562022-02-25 09:11
ReporterjetxarriView Statuspublic 
Assigned Tojetxarri 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget VersionPR22Q2
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0048659: API change: removed availability fields from discounts and promotions window

DescriptionRemoved fields
Ending Time, Monday, Starting Time Saturday, Sunday, Ending Time Friday, Wednesday, Ending Time Wednesday
Thursday, Starting Time Tuesday, Ending Time Saturday, Starting Time, Starting Time Friday, Starting Time Sunday
Starting Time Wednesday, Ending Time Monday, Ending Time Tuesday, Ending Time Sunday, Starting Time Thursday
All Week, Starting Time Monday, Friday, Ending Time Thursday, Tuesday, Saturday, Availability

Moving all the logic to a new Tab "Availability" that will allow users to define more than one time slot each day.

Columns has not been deleted because they are useful for the module script to translate all the information to new tab.

The risk is minor because we have done all the changes in the affected modules and also verified that the old fields are not used in other modules. Attached a with the search done
Search done:
 grep -EIr 'isThursday|PROPERTY_THURSDAY|PROPERTY_STARTINGTIMETHURSDAY|getStartingtimethursday|startingtimethursday|thursday'

search1.txt => git clone in /product/* (ignoring unsupported)
search2.txt => 'all forge modules from last summer'
Steps To Reproducehttps://builds.openbravo.com/job/int-api/518/console [^]
TagsApproved
Attached Filestxt file icon fr48383-for-Javier-search1.txt [^] (38,983 bytes) 2022-02-23 15:56 [Show Content]
txt file icon fr48383-for-Javier-search2.txt [^] (8,198 bytes) 2022-02-23 15:56 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]
blocks defect 0048660PR22Q2 closedjetxarri As a new Tab Availability has been created, remove old fields related to availability 

-  Notes
(0135301)
hgbot (developer)
2022-02-25 06:52

Merge Request created: https://gitlab.com/openbravo/ci/backoffice-api/-/merge_requests/21 [^]
(0135302)
hgbot (developer)
2022-02-25 09:11

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/ci/backoffice-api [^]
Changeset: 867062059ab0497019637df2c81ce8a572f45a7e
Author: Javier Etxarri <javier.echarri@openbravo.com>
Date: 25-02-2022 06:51:14
URL: https://gitlab.com/openbravo/ci/backoffice-api/-/commit/867062059ab0497019637df2c81ce8a572f45a7e [^]

Fixes ISSUE-48659: API change: removed availability fields from discounts and promotions window

---
M model/src-db/database/sourcedata/AD_FIELD.xml
---
(0135303)
hgbot (developer)
2022-02-25 09:11

Merge request merged: https://gitlab.com/openbravo/ci/backoffice-api/-/merge_requests/21 [^]

- Issue History
Date Modified Username Field Change
2022-02-23 15:56 jetxarri New Issue
2022-02-23 15:56 jetxarri Assigned To => dmitry_mezentsev
2022-02-23 15:56 jetxarri File Added: fr48383-for-Javier-search1.txt
2022-02-23 15:56 jetxarri Modules => Core
2022-02-23 15:56 jetxarri Triggers an Emergency Pack => No
2022-02-23 15:56 jetxarri File Added: fr48383-for-Javier-search2.txt
2022-02-23 16:02 jetxarri Relationship added related to 0048660
2022-02-24 20:22 dmitry_mezentsev Tag Attached: Approved
2022-02-24 20:22 dmitry_mezentsev Assigned To dmitry_mezentsev => jetxarri
2022-02-25 06:52 hgbot Note Added: 0135301
2022-02-25 09:08 aferraz Relationship replaced blocks 0048660
2022-02-25 09:11 hgbot Resolution open => fixed
2022-02-25 09:11 hgbot Status new => closed
2022-02-25 09:11 hgbot Note Added: 0135302
2022-02-25 09:11 hgbot Note Added: 0135303


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker