Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0048659Openbravo ERP02. Master data managementpublic2022-02-23 15:562022-02-25 09:11
Reporterjetxarri 
Assigned Tojetxarri 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionPR22Q2Fixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0048659: API change: removed availability fields from discounts and promotions window
DescriptionRemoved fields
Ending Time, Monday, Starting Time Saturday, Sunday, Ending Time Friday, Wednesday, Ending Time Wednesday
Thursday, Starting Time Tuesday, Ending Time Saturday, Starting Time, Starting Time Friday, Starting Time Sunday
Starting Time Wednesday, Ending Time Monday, Ending Time Tuesday, Ending Time Sunday, Starting Time Thursday
All Week, Starting Time Monday, Friday, Ending Time Thursday, Tuesday, Saturday, Availability

Moving all the logic to a new Tab "Availability" that will allow users to define more than one time slot each day.

Columns has not been deleted because they are useful for the module script to translate all the information to new tab.

The risk is minor because we have done all the changes in the affected modules and also verified that the old fields are not used in other modules. Attached a with the search done
Search done:
 grep -EIr 'isThursday|PROPERTY_THURSDAY|PROPERTY_STARTINGTIMETHURSDAY|getStartingtimethursday|startingtimethursday|thursday'

search1.txt => git clone in /product/* (ignoring unsupported)
search2.txt => 'all forge modules from last summer'
Steps To Reproducehttps://builds.openbravo.com/job/int-api/518/console [^]
Proposed Solution
Additional Information
TagsApproved
Relationships
blocks defect 0048660PR22Q2 closed jetxarri As a new Tab Availability has been created, remove old fields related to availability 
Attached Filestxt fr48383-for-Javier-search1.txt (38,983) 2022-02-23 15:56
https://issues.openbravo.com/file_download.php?file_id=16667&type=bug
txt fr48383-for-Javier-search2.txt (8,198) 2022-02-23 15:56
https://issues.openbravo.com/file_download.php?file_id=16668&type=bug
Issue History
Date ModifiedUsernameFieldChange
2022-02-23 15:56jetxarriNew Issue
2022-02-23 15:56jetxarriAssigned To => dmitry_mezentsev
2022-02-23 15:56jetxarriFile Added: fr48383-for-Javier-search1.txt
2022-02-23 15:56jetxarriModules => Core
2022-02-23 15:56jetxarriTriggers an Emergency Pack => No
2022-02-23 15:56jetxarriFile Added: fr48383-for-Javier-search2.txt
2022-02-23 16:02jetxarriRelationship addedrelated to 0048660
2022-02-24 20:22dmitry_mezentsevTag Attached: Approved
2022-02-24 20:22dmitry_mezentsevAssigned Todmitry_mezentsev => jetxarri
2022-02-25 06:52hgbotNote Added: 0135301
2022-02-25 09:08aferrazRelationship replacedblocks 0048660
2022-02-25 09:11hgbotResolutionopen => fixed
2022-02-25 09:11hgbotStatusnew => closed
2022-02-25 09:11hgbotNote Added: 0135302
2022-02-25 09:11hgbotNote Added: 0135303

Notes
(0135301)
hgbot   
2022-02-25 06:52   
Merge Request created: https://gitlab.com/openbravo/ci/backoffice-api/-/merge_requests/21 [^]
(0135302)
hgbot   
2022-02-25 09:11   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/ci/backoffice-api [^]
Changeset: 867062059ab0497019637df2c81ce8a572f45a7e
Author: Javier Etxarri <javier.echarri@openbravo.com>
Date: 25-02-2022 06:51:14
URL: https://gitlab.com/openbravo/ci/backoffice-api/-/commit/867062059ab0497019637df2c81ce8a572f45a7e [^]

Fixes ISSUE-48659: API change: removed availability fields from discounts and promotions window

---
M model/src-db/database/sourcedata/AD_FIELD.xml
---
(0135303)
hgbot   
2022-02-25 09:11   
Merge request merged: https://gitlab.com/openbravo/ci/backoffice-api/-/merge_requests/21 [^]