Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0048594
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSminoralways2022-02-15 08:332022-03-09 09:41
Reporterprakashmurugesan88View Statuspublic 
Assigned Toprakashmurugesan88 
PrioritynormalResolutionfixedFixed in VersionRR22Q2
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0048594: Callback is missing in CreateLine function of Order model

DescriptionCallback is missing in CreateLine function of Order model

https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/blob/master/web/org.openbravo.retail.posterminal/js/model/order.js#L4011 [^]

When CreateLine is called with callback parameter, callback function is not called after creating lines.
Steps To ReproduceIn livebuilds, Open terminal

Try to add lines using CreateLine function as below in browser console,
OB.Dal.get(
    OB.Model.Product,
   '934E7D7587EC4C7A9E9FF58F0382D450',
    function(product) {
      OB.MobileApp.model.receipt.createLine(
        product,
        1, null, null,
       () => {
        console.error('success');
       },
       () => {
        console.error('error');
       }
      );
    }
);

Notice success callback is not printed
Proposed SolutionInclude missing call for callback
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0135035)
hgbot (developer)
2022-02-16 08:15

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/720 [^]
(0135036)
hgbot (developer)
2022-02-16 08:22

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 271e25659c1b345575804c28e932275494291f73
Author: Prakash M <prakash@qualiantech.com>
Date: 16-02-2022 12:43:56
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/271e25659c1b345575804c28e932275494291f73 [^]

Fixed BUG-48594: Added missing callback for CreateLine function in Order

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0135037)
hgbot (developer)
2022-02-16 08:22

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/720 [^]
(0135568)
hgbot (developer)
2022-03-09 07:18

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/741 [^]
(0135573)
marvintm (viewer)
2022-03-09 09:41

 Finally the callback wasn't actually missing and we need to revert the change
(0135574)
hgbot (developer)
2022-03-09 09:41

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 86a49d7197a3b67be4ddfee97a9fbb64c3789366
Author: Prakash M <prakash@qualiantech.com>
Date: 09-03-2022 11:46:04
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/86a49d7197a3b67be4ddfee97a9fbb64c3789366 [^]

Revert "Fixed BUG-48594: Added missing callback for CreateLine function in Order"

This reverts commit 271e25659c1b345575804c28e932275494291f73.

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0135575)
hgbot (developer)
2022-03-09 09:41

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/741 [^]

- Issue History
Date Modified Username Field Change
2022-02-15 08:33 prakashmurugesan88 New Issue
2022-02-15 08:33 prakashmurugesan88 Assigned To => prakashmurugesan88
2022-02-15 08:33 prakashmurugesan88 OBNetwork customer => No
2022-02-15 08:33 prakashmurugesan88 Triggers an Emergency Pack => No
2022-02-15 08:33 prakashmurugesan88 Status new => scheduled
2022-02-15 11:07 prakashmurugesan88 Steps to Reproduce Updated View Revisions
2022-02-15 11:07 prakashmurugesan88 Proposed Solution updated
2022-02-16 08:15 hgbot Merge Request Status => open
2022-02-16 08:15 hgbot Note Added: 0135035
2022-02-16 08:22 hgbot Merge Request Status open => approved
2022-02-16 08:22 hgbot Resolution open => fixed
2022-02-16 08:22 hgbot Status scheduled => closed
2022-02-16 08:22 hgbot Fixed in Version => RR22Q2
2022-02-16 08:22 hgbot Note Added: 0135036
2022-02-16 08:22 hgbot Note Added: 0135037
2022-03-09 07:18 hgbot Note Added: 0135568
2022-03-09 09:41 marvintm Note Added: 0135573
2022-03-09 09:41 hgbot Note Added: 0135574
2022-03-09 09:41 hgbot Note Added: 0135575

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker