Openbravo Issue Tracking System - Retail Modules
View Issue Details
0048594Retail ModulesWeb POSpublic2022-02-15 08:332022-03-09 09:41
prakashmurugesan88 
prakashmurugesan88 
normalminoralways
closedfixed 
5
 
RR22Q2 
No
0048594: Callback is missing in CreateLine function of Order model
Callback is missing in CreateLine function of Order model

https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/blob/master/web/org.openbravo.retail.posterminal/js/model/order.js#L4011 [^]

When CreateLine is called with callback parameter, callback function is not called after creating lines.
In livebuilds, Open terminal

Try to add lines using CreateLine function as below in browser console,
OB.Dal.get(
    OB.Model.Product,
   '934E7D7587EC4C7A9E9FF58F0382D450',
    function(product) {
      OB.MobileApp.model.receipt.createLine(
        product,
        1, null, null,
       () => {
        console.error('success');
       },
       () => {
        console.error('error');
       }
      );
    }
);

Notice success callback is not printed
Include missing call for callback
No tags attached.
Issue History
2022-02-15 08:33prakashmurugesan88New Issue
2022-02-15 08:33prakashmurugesan88Assigned To => prakashmurugesan88
2022-02-15 08:33prakashmurugesan88Triggers an Emergency Pack => No
2022-02-15 08:33prakashmurugesan88Statusnew => scheduled
2022-02-15 11:07prakashmurugesan88Steps to Reproduce Updatedbug_revision_view_page.php?rev_id=23670#r23670
2022-02-15 11:07prakashmurugesan88Proposed Solution updated
2022-02-16 08:15hgbotNote Added: 0135035
2022-02-16 08:22hgbotResolutionopen => fixed
2022-02-16 08:22hgbotStatusscheduled => closed
2022-02-16 08:22hgbotFixed in Version => RR22Q2
2022-02-16 08:22hgbotNote Added: 0135036
2022-02-16 08:22hgbotNote Added: 0135037
2022-03-09 07:18hgbotNote Added: 0135568
2022-03-09 09:41marvintmNote Added: 0135573
2022-03-09 09:41hgbotNote Added: 0135574
2022-03-09 09:41hgbotNote Added: 0135575

Notes
(0135035)
hgbot   
2022-02-16 08:15   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/720 [^]
(0135036)
hgbot   
2022-02-16 08:22   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 271e25659c1b345575804c28e932275494291f73
Author: Prakash M <prakash@qualiantech.com>
Date: 16-02-2022 12:43:56
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/271e25659c1b345575804c28e932275494291f73 [^]

Fixed BUG-48594: Added missing callback for CreateLine function in Order

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0135037)
hgbot   
2022-02-16 08:22   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/720 [^]
(0135568)
hgbot   
2022-03-09 07:18   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/741 [^]
(0135573)
marvintm   
2022-03-09 09:41   
Finally the callback wasn't actually missing and we need to revert the change
(0135574)
hgbot   
2022-03-09 09:41   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 86a49d7197a3b67be4ddfee97a9fbb64c3789366
Author: Prakash M <prakash@qualiantech.com>
Date: 09-03-2022 11:46:04
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/86a49d7197a3b67be4ddfee97a9fbb64c3789366 [^]

Revert "Fixed BUG-48594: Added missing callback for CreateLine function in Order"

This reverts commit 271e25659c1b345575804c28e932275494291f73.

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0135575)
hgbot   
2022-03-09 09:41   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/741 [^]