Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0048465 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
defect | [Openbravo ERP] Z. Others | major | always | 2022-01-21 22:10 | 2022-03-02 08:25 | |||
Reporter | ivazquez | View Status | public | |||||
Assigned To | caristu | |||||||
Priority | high | Resolution | fixed | Fixed in Version | ||||
Status | closed | Fix in branch | Fixed in SCM revision | 820a1a85782c | ||||
Projection | none | ETA | none | Target Version | ||||
OS | Any | Database | Any | Java version | ||||
OS Version | Database version | Ant version | ||||||
Product Version | PR21Q2.3 | SCM revision | ||||||
Review Assigned To | AugustoMauch | |||||||
Web browser | ||||||||
Modules | Core | |||||||
Regression level | Production - Confirmed Stable | |||||||
Regression date | 2018-09-25 | |||||||
Regression introduced in release | 3.0PR18Q4 | |||||||
Regression introduced by commit | https://code.openbravo.com/erp/devel/pi/rev/8a73e458127f7a40f4db9fc8583db06798e0856e [^] | |||||||
Triggers an Emergency Pack | No | |||||||
Summary | 0048465: Some process definition reports stop working after upgrading from 18Q3 to 21Q2.3 | |||||||
Description | After an upgrade to version 21Q2.3 it was reported that a problem occurred when trying to generate process definition reports that make use of some org.openbravo.erpCommon.utility.Utility methods (that use DAL internally) in the header and also have a subreport executing a query. The error displayed by the stacktrace is as follows: Caused by: java.sql.SQLException: PooledConnection has already been closed. To clarify that in Openbravos.properties the following configuration is found this way: db.externalPoolClassName=org.openbravo.apachejdbcconnectionpool.JdbcExternalConnectionPool Related issue: https://issues.openbravo.com/view.php?id=47943 [^] | |||||||
Steps To Reproduce | 1.- Download and assemble a pristine in version 21Q2.3 2.- Install the module provided by the customer attached in the issue (which only has the process definition and the jaspers). 3.- Go to "Print Product" and select a product. 4.- Click on the button "Export to PDF". Returns the following error: net.sf.jasperreports.engine.JRException: Error preparing the statement to execute the report query. And in the logs you can see the error mentioned above | |||||||
Tags | No tags attached. | |||||||
Attached Files | com.exos.printproblem-1.0.0.obx [^] (26,242 bytes) 2022-01-21 22:10 stacktrace.txt [^] (3,871 bytes) 2022-01-21 22:12 [Show Content] | |||||||
Relationships [ Relation Graph ] [ Dependency Graph ] | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Notes | |
(0134718) hgbot (developer) 2022-02-01 18:06 |
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/520 [^] |
(0135256) ivazquez (developer) 2022-02-23 16:23 |
Hello Team, Any update on this case? Regards, Ignacio Vazquez |
(0135309) hgbot (developer) 2022-02-25 10:05 |
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/520 [^] |
(0135310) hgbot (developer) 2022-02-25 10:05 |
Repository: https://gitlab.com/openbravo/product/openbravo [^] Changeset: 65c1be00849b97a0c86ff2a159a717b089437259 Author: Carlos Aristu <carlos.aristu@openbravo.com> Date: 25-02-2022 10:03:53 URL: https://gitlab.com/openbravo/product/openbravo/-/commit/65c1be00849b97a0c86ff2a159a717b089437259 [^] related to BUG-48465: add test cases --- A src-test/src/org/openbravo/test/reporting/ReportingUtilsTest.java A src-test/src/org/openbravo/test/reporting/reports/Main.jrxml A src-test/src/org/openbravo/test/reporting/reports/Subreport.jrxml M src-test/src/org/openbravo/test/StandaloneTestSuite.java --- |
(0135311) hgbot (developer) 2022-02-25 10:05 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/openbravo [^] Changeset: 820a1a85782c1fdff85a268454ad2df6946e58e8 Author: Carlos Aristu <carlos.aristu@openbravo.com> Date: 25-02-2022 10:03:53 URL: https://gitlab.com/openbravo/product/openbravo/-/commit/820a1a85782c1fdff85a268454ad2df6946e58e8 [^] fixes BUG-48465: manage the DAL connection of the subreports Jasper subreports are filled with a multi-threading mechanism. In case the threads use DAL to retrieve any information (for example an image) we must ensure that the DAL connection is closed to prevent connection leaks. For this reason, most of the Utility class methods are closing the connection on finish. But at the same time this can cause problems in case the DAL connection is reused both in the header and in the subreport query. In that case if the header closes the DAL connection through the Utility method, then the subreport will not be able to execute the query because the connection is already closed. To fix this problems, two actions are being taken: - We provide our own subreport runner factory to ensure that the threads used to fill the subreports close the DAL connections when they are finished. - The Utility methods are no longer closing the DAL connection, because this not needed anymore. --- A src/org/openbravo/dal/core/DalThreadCleaner.java A src/org/openbravo/report/jasper/SubreportRunner.java A src/org/openbravo/report/jasper/SubreportRunnerFactory.java M src/org/openbravo/dal/core/DalThreadHandler.java M src/org/openbravo/erpCommon/utility/Utility.java M src/org/openbravo/erpReports/jasperreports.properties --- |
(0135376) hgbot (developer) 2022-03-02 08:25 |
Repository: https://gitlab.com/openbravo/product/openbravo [^] Changeset: fe489aa11c01d18668bab7ef8b4bbc8b47390091 Author: Carlos Aristu <carlos.aristu@openbravo.com> Date: 02-03-2022 08:25:12 URL: https://gitlab.com/openbravo/product/openbravo/-/commit/fe489aa11c01d18668bab7ef8b4bbc8b47390091 [^] related to BUG-48465: add comment --- M src/org/openbravo/erpReports/jasperreports.properties --- |
Issue History | |||
Date Modified | Username | Field | Change |
2022-01-21 22:10 | ivazquez | New Issue | |
2022-01-21 22:10 | ivazquez | Assigned To | => Triage Finance |
2022-01-21 22:10 | ivazquez | File Added: com.exos.printproblem-1.0.0.obx | |
2022-01-21 22:10 | ivazquez | Modules | => Core |
2022-01-21 22:10 | ivazquez | Triggers an Emergency Pack | => No |
2022-01-21 22:10 | ivazquez | Reproducibility | have not tried => always |
2022-01-21 22:12 | ivazquez | File Added: stacktrace.txt | |
2022-01-24 12:06 | vmromanos | Assigned To | Triage Finance => platform |
2022-01-24 12:21 | shuehner | Assigned To | platform => Triage Platform Base |
2022-01-31 13:33 | AugustoMauch | Regression level | => Production - Confirmed Stable |
2022-01-31 13:33 | AugustoMauch | Regression date | => 2018-09-25 |
2022-01-31 13:33 | AugustoMauch | Regression introduced in release | => 3.0PR18Q4 |
2022-01-31 13:33 | AugustoMauch | Regression introduced by commit | => https://code.openbravo.com/erp/devel/pi/rev/8a73e458127f7a40f4db9fc8583db06798e0856e [^] |
2022-01-31 13:33 | AugustoMauch | Status | new => acknowledged |
2022-01-31 13:34 | AugustoMauch | Relationship added | caused by 0039261 |
2022-01-31 16:54 | AugustoMauch | Assigned To | Triage Platform Base => caristu |
2022-01-31 16:54 | AugustoMauch | Status | acknowledged => scheduled |
2022-02-01 11:08 | caristu | Relationship added | related to 0028947 |
2022-02-01 11:10 | caristu | Relationship added | related to 0036736 |
2022-02-01 18:06 | hgbot | Note Added: 0134718 | |
2022-02-02 12:56 | caristu | Relationship added | related to 0036697 |
2022-02-14 12:27 | caristu | Relationship added | related to 0030182 |
2022-02-14 15:54 | caristu | Summary | Reports stop working after upgrading from 18Q3 to 21Q2.3 => Some process definition reports stop working after upgrading from 18Q3 to 21Q2.3 |
2022-02-14 15:54 | caristu | Description Updated | View Revisions |
2022-02-15 08:01 | caristu | Relationship added | related to 0032576 |
2022-02-23 16:23 | ivazquez | Note Added: 0135256 | |
2022-02-25 10:05 | hgbot | Note Added: 0135309 | |
2022-02-25 10:05 | hgbot | Note Added: 0135310 | |
2022-02-25 10:05 | hgbot | Resolution | open => fixed |
2022-02-25 10:05 | hgbot | Status | scheduled => closed |
2022-02-25 10:05 | hgbot | Fixed in Version | => PR22Q2 |
2022-02-25 10:05 | hgbot | Note Added: 0135311 | |
2022-02-25 10:11 | caristu | Status | closed => new |
2022-02-25 10:11 | caristu | Resolution | fixed => open |
2022-02-25 10:11 | caristu | Fixed in Version | PR22Q2 => |
2022-02-25 10:12 | caristu | Status | new => scheduled |
2022-02-25 10:13 | caristu | Status | scheduled => resolved |
2022-02-25 10:13 | caristu | Fixed in SCM revision | => https://gitlab.com/openbravo/product/openbravo/-/commit/820a1a85782c1fdff85a268454ad2df6946e58e8 [^] |
2022-02-25 10:13 | caristu | Resolution | open => fixed |
2022-02-25 10:14 | caristu | Review Assigned To | => AugustoMauch |
2022-02-25 10:14 | caristu | Status | resolved => closed |
2022-03-02 08:25 | hgbot | Note Added: 0135376 | |
2022-03-08 19:10 | ivazquez | Relationship added | related to 0048748 |
Copyright © 2000 - 2009 MantisBT Group |