Openbravo Issue Tracking System - Openbravo ERP |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0048465 | Openbravo ERP | Z. Others | public | 2022-01-21 22:10 | 2022-03-02 08:25 |
|
| Reporter | ivazquez | |
| Assigned To | caristu | |
| Priority | high | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | PR21Q2.3 | |
| Target Version | | Fixed in Version | | |
| Merge Request Status | |
| Review Assigned To | AugustoMauch |
| OBNetwork customer | |
| Web browser | |
| Modules | Core |
| Support ticket | |
| Regression level | Production - Confirmed Stable |
| Regression date | 2018-09-25 |
| Regression introduced in release | 3.0PR18Q4 |
| Regression introduced by commit | https://code.openbravo.com/erp/devel/pi/rev/8a73e458127f7a40f4db9fc8583db06798e0856e [^] |
| Triggers an Emergency Pack | No |
|
| Summary | 0048465: Some process definition reports stop working after upgrading from 18Q3 to 21Q2.3 |
| Description | After an upgrade to version 21Q2.3 it was reported that a problem occurred when trying to generate process definition reports that make use of some org.openbravo.erpCommon.utility.Utility methods (that use DAL internally) in the header and also have a subreport executing a query.
The error displayed by the stacktrace is as follows:
Caused by: java.sql.SQLException: PooledConnection has already been closed.
To clarify that in Openbravos.properties the following configuration is found this way:
db.externalPoolClassName=org.openbravo.apachejdbcconnectionpool.JdbcExternalConnectionPool
Related issue: https://issues.openbravo.com/view.php?id=47943 [^] |
| Steps To Reproduce | 1.- Download and assemble a pristine in version 21Q2.3
2.- Install the module provided by the customer attached in the issue (which only has the process definition and the jaspers).
3.- Go to "Print Product" and select a product.
4.- Click on the button "Export to PDF".
Returns the following error:
net.sf.jasperreports.engine.JRException: Error preparing the statement to execute the report query.
And in the logs you can see the error mentioned above |
| Proposed Solution | |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | | related to | feature request | 0028947 | | closed | nonofrancisco | Add HTML output to Process Definition reports | | related to | feature request | 0036736 | | closed | AtulOpenbravo | Make OB reports read-only pool "compatible" | | related to | defect | 0036697 | | closed | caristu | connection leak when printing a image on a jasper subreport using the Utility.showImage method | | related to | defect | 0032576 | | closed | alostale | connection leak when printing Requisition report | | depends on | backport | 0048672 | PR22Q1.1 | closed | caristu | Some process definition reports stop working after upgrading from 18Q3 to 21Q2.3 | | depends on | backport | 0048673 | PR21Q4.4 | closed | caristu | Some process definition reports stop working after upgrading from 18Q3 to 21Q2.3 | | caused by | defect | 0039261 | | closed | jarmendariz | connection leak when printing image on subreports using the Utility.showImageLogo method | | related to | design defect | 0030182 | | closed | Triage Platform Base | jasper subreports using DAL do leak connection + transactions | | related to | defect | 0048748 | PR21Q2.3 | closed | ivazquez | Open database connections are left open when printing reports (post upgrade from 18Q3 to 21Q2.3) |
|
| Attached Files |  com.exos.printproblem-1.0.0.obx (26,242) 2022-01-21 22:10
https://issues.openbravo.com/file_download.php?file_id=16532&type=bug
 stacktrace.txt (3,871) 2022-01-21 22:12
https://issues.openbravo.com/file_download.php?file_id=16533&type=bug |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2022-01-21 22:10 | ivazquez | New Issue | |
| 2022-01-21 22:10 | ivazquez | Assigned To | => Triage Finance |
| 2022-01-21 22:10 | ivazquez | File Added: com.exos.printproblem-1.0.0.obx | |
| 2022-01-21 22:10 | ivazquez | Modules | => Core |
| 2022-01-21 22:10 | ivazquez | Triggers an Emergency Pack | => No |
| 2022-01-21 22:10 | ivazquez | Reproducibility | have not tried => always |
| 2022-01-21 22:12 | ivazquez | File Added: stacktrace.txt | |
| 2022-01-24 12:06 | vmromanos | Assigned To | Triage Finance => platform |
| 2022-01-24 12:21 | shuehner | Assigned To | platform => Triage Platform Base |
| 2022-01-31 13:33 | AugustoMauch | Regression level | => Production - Confirmed Stable |
| 2022-01-31 13:33 | AugustoMauch | Regression date | => 2018-09-25 |
| 2022-01-31 13:33 | AugustoMauch | Regression introduced in release | => 3.0PR18Q4 |
| 2022-01-31 13:33 | AugustoMauch | Regression introduced by commit | => https://code.openbravo.com/erp/devel/pi/rev/8a73e458127f7a40f4db9fc8583db06798e0856e [^] |
| 2022-01-31 13:33 | AugustoMauch | Status | new => acknowledged |
| 2022-01-31 13:34 | AugustoMauch | Relationship added | caused by 0039261 |
| 2022-01-31 16:54 | AugustoMauch | Assigned To | Triage Platform Base => caristu |
| 2022-01-31 16:54 | AugustoMauch | Status | acknowledged => scheduled |
| 2022-02-01 11:08 | caristu | Relationship added | related to 0028947 |
| 2022-02-01 11:10 | caristu | Relationship added | related to 0036736 |
| 2022-02-01 18:06 | hgbot | Note Added: 0134718 | |
| 2022-02-02 12:56 | caristu | Relationship added | related to 0036697 |
| 2022-02-14 12:27 | caristu | Relationship added | related to 0030182 |
| 2022-02-14 15:54 | caristu | Summary | Reports stop working after upgrading from 18Q3 to 21Q2.3 => Some process definition reports stop working after upgrading from 18Q3 to 21Q2.3 |
| 2022-02-14 15:54 | caristu | Description Updated | bug_revision_view_page.php?rev_id=23661#r23661 |
| 2022-02-15 08:01 | caristu | Relationship added | related to 0032576 |
| 2022-02-23 16:23 | ivazquez | Note Added: 0135256 | |
| 2022-02-25 10:05 | hgbot | Note Added: 0135309 | |
| 2022-02-25 10:05 | hgbot | Note Added: 0135310 | |
| 2022-02-25 10:05 | hgbot | Resolution | open => fixed |
| 2022-02-25 10:05 | hgbot | Status | scheduled => closed |
| 2022-02-25 10:05 | hgbot | Fixed in Version | => PR22Q2 |
| 2022-02-25 10:05 | hgbot | Note Added: 0135311 | |
| 2022-02-25 10:11 | caristu | Status | closed => new |
| 2022-02-25 10:11 | caristu | Resolution | fixed => open |
| 2022-02-25 10:11 | caristu | Fixed in Version | PR22Q2 => |
| 2022-02-25 10:12 | caristu | Status | new => scheduled |
| 2022-02-25 10:13 | caristu | Status | scheduled => resolved |
| 2022-02-25 10:13 | caristu | Fixed in SCM revision | => https://gitlab.com/openbravo/product/openbravo/-/commit/820a1a85782c1fdff85a268454ad2df6946e58e8 [^] |
| 2022-02-25 10:13 | caristu | Resolution | open => fixed |
| 2022-02-25 10:14 | caristu | Review Assigned To | => AugustoMauch |
| 2022-02-25 10:14 | caristu | Status | resolved => closed |
| 2022-03-02 08:25 | hgbot | Note Added: 0135376 | |
| 2022-03-08 19:10 | ivazquez | Relationship added | related to 0048748 |
|
Notes |
|
|
(0134718)
|
|
hgbot
|
|
2022-02-01 18:06
|
|
|
|
|
|
Hello Team,
Any update on this case?
Regards,
Ignacio Vazquez |
|
|
|
(0135309)
|
|
hgbot
|
|
2022-02-25 10:05
|
|
|
|
|
(0135310)
|
|
hgbot
|
|
2022-02-25 10:05
|
|
|
|
|
(0135311)
|
|
hgbot
|
|
2022-02-25 10:05
|
|
Directly closing issue as related merge request is already approved.
Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 820a1a85782c1fdff85a268454ad2df6946e58e8
Author: Carlos Aristu <carlos.aristu@openbravo.com>
Date: 25-02-2022 10:03:53
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/820a1a85782c1fdff85a268454ad2df6946e58e8 [^]
fixes BUG-48465: manage the DAL connection of the subreports
Jasper subreports are filled with a multi-threading mechanism. In case
the threads use DAL to retrieve any information (for example an image)
we must ensure that the DAL connection is closed to prevent connection
leaks.
For this reason, most of the Utility class methods are closing the
connection on finish. But at the same time this can cause problems in
case the DAL connection is reused both in the header and in the
subreport query. In that case if the header closes the DAL connection
through the Utility method, then the subreport will not be able to
execute the query because the connection is already closed.
To fix this problems, two actions are being taken:
- We provide our own subreport runner factory to ensure that the
threads used to fill the subreports close the DAL connections when they
are finished.
- The Utility methods are no longer closing the DAL connection, because
this not needed anymore.
---
A src/org/openbravo/dal/core/DalThreadCleaner.java
A src/org/openbravo/report/jasper/SubreportRunner.java
A src/org/openbravo/report/jasper/SubreportRunnerFactory.java
M src/org/openbravo/dal/core/DalThreadHandler.java
M src/org/openbravo/erpCommon/utility/Utility.java
M src/org/openbravo/erpReports/jasperreports.properties
---
|
|
|
|
(0135376)
|
|
hgbot
|
|
2022-03-02 08:25
|
|
|