0048438: JIRA 2600 - It's possible to pay twice a ticket and remove discounts from it

Description

In TAP version it is possible to pay a ticket twice and remove discount from it.
It is just enough to open it and pay it again, cf use case below done on livebuild.

Steps To Reproduce

Go to https://livebuilds.openbravo.com/retail_pos2_tap_pgsql/web/pos/?terminal=VBS-2 [^]

Go to WebPos as Vallblanca
Add Hiking boots and Balaclava Cap
Click on Hiking boots and then press discount
select disc_5_ var_perc discount and press apply
pay the transaction by cash

Go to Backoffice as Vallblanca user and open sales order window in order to open the previous sale
Go to payment plan tab and check outstanding which is equal to 0.00
And go to Payment details, as you can see one payment was done

Go back to WebPOS and open the transaction you have previously done
Amount of the transaction is 329.55 € and the discount is still present
But it is possible to pay --> it shouldn't be possible to pay again this ticket
And when you pay, the discount disappears and you can add another payment in cash (8.45 €) to the ticket
And then press "done"

Go to Backoffice as Vallblanca user and open sales order window in order to open the previous sale
Go to payment plan tab and check outstanding which is equal to -8.45
In payment details there is 2 payment lines instead of initially one
--> KO it is not normal to change a transaction like that after paying it during the first ticket

Proposed Solution

Deactivate the pay button when the ticket is completely paid and you open it
Or completely keep the same ticket (when included discount for example ) after switching to payment mode and don't save a new payment again (just print a duplicata, the ticket has not to be changed)

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

related to	defect	0046701		closed	Retail	JIRA-1754: No info shown if a order is already paid, if opened.
blocks	defect	0048400		closed	cberner	JIRA 2600 - It's possible to pay twice a ticket and remove discounts from it

Notes
(0134458) cberner (developer) 2022-01-21 09:07 edited on: 2022-01-21 09:07	MR created and merged for this issue: https://gitlab.com/obcustomers/AGAP/org.openbravo.pos2/-/merge_requests/145 [^]

Issue History
Date Modified	Username	Field	Change
2022-01-19 16:47	guilleaer	Type	defect => backport
2022-01-21 09:07	cberner	Note Added: 0134458
2022-01-21 09:07	cberner	Note Edited: 0134458	View Revisions
2022-01-21 09:08	cberner	Status	scheduled => resolved
2022-01-21 09:08	cberner	Fixed in Version	=> TAP
2022-01-21 09:08	cberner	Resolution	open => fixed
2022-01-21 09:08	cberner	Review Assigned To	=> guilleaer
2022-01-21 09:08	cberner	Status	resolved => closed
2022-01-21 09:43	cberner	Relationship added	related to 0046701