Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0046701
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[POS2] POSmajoralways2021-05-18 09:512022-03-01 12:51
ReporterpsanjuanView Statuspublic 
Assigned ToRetail 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSLinux 64 bitDatabasePostgreSQLJava version7.x
OS VersionOpenbravo Appliance 14.04Database version9.3.xAnt version1.9.x
Product VersionSCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0046701: JIRA-1754: No info shown if a order is already paid, if opened.

DescriptionNo info shown if a order is already paid, if opened.
Steps To ReproduceCreate a sale of 9€. Select any product.
Pay the sale in cash, for instance. Press Done.

Click on Orders and select the last order created and paid.

There is no place where the user can be informed that the order is already paid, but a highlighted button saying "Pay" in yellow, that could be understood as if the order needs to be paid. See image attached.

Only when you click on that Pay button, the UI changes and the amount paid is shown.
See image attached.
TagsNo tags attached.
Attached Filesjpg file icon Paid_Receipt.jpg [^] (222,192 bytes) 2021-05-18 20:44


png file icon Issue_46701.png [^] (83,406 bytes) 2021-05-19 09:50


png file icon Issue46701_2.png [^] (78,531 bytes) 2021-05-19 09:50


png file icon B010 - Orders - 040.png [^] (375,347 bytes) 2021-06-07 21:10
png file icon A310 - Order Paid.png [^] (640,408 bytes) 2021-06-07 21:10
png file icon MinHeight.png [^] (219,052 bytes) 2021-06-08 11:34

- Relationships Relation Graph ] Dependency Graph ]
depends on backport 0046796TAP closedmtaal JIRA-1754: No info shown if a order is already paid, if opened. 
related to backport 0048438TAP closedcberner JIRA 2600 - It's possible to pay twice a ticket and remove discounts from it 
blocks defect 0046393 closedRetail The user can not differentiate between positive and negative payments (returns) 

-  Notes
(0128353)
dbaz (developer)
2021-05-18 20:45

It should be at least as in old WebPOS

* A "Paid" text (I would handle it inside the Receipt Status project)
* The "Payment breakdown" section. It could be handled right now
(0128767)
guilleaer (manager)
2021-05-28 11:21
edited on: 2021-05-28 11:27

Pending:
Mockup for payment breakdown
Mockup + specification about order status (Paid, quotation, return etc)
Button pay label should change

(0129160)
dbaz (developer)
2021-06-07 21:14

Uploaded mockups

"B010 - Orders - 040.png"
"A310 - Order Paid.png"

In the Orders grid there is a new column reflecting the status of the order/quotation/return. The same status is also shown in the order receipt header.

In the order receipt footer, there are also shown the payments of the order. There is a separation line between the taxes and these payments.

If the order is already paid, the "Pay" button changes its label to "Review Payments". In case the order were a "Return Refunded", the label of this button should be "Review Refunds"
(0129173)
dbaz (developer)
2021-06-08 11:33

Added "MinHeight.png"

As in the old WebPOS, the minimum height of the receipt lines should be 150px (15rem). From there, if the real height of lines and the footer (total+taxes+payments) is higher than the available height, they both should have scrollbars (as in attached screenshot and as in old WebPOS)
(0129175)
dmiguelez (developer)
2021-06-08 12:11

The final solution proposed to fix this issue (and some related topics) is a little bit more complex than expected, therefore the resolution date has been delayed one week to fully address all the topics
(0129493)
hgbot (developer)
2021-06-14 23:59

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/552 [^]
(0129528)
mtaal (manager)
2021-06-15 20:23

https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/552 [^]
(0130134)
hgbot (developer)
2021-07-05 11:59

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/552 [^]
(0130135)
hgbot (developer)
2021-07-05 11:59

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 64190a35d5e8fe4a5d85546c548e6b4d3a43f932
Author: Antonio Moreno <anmorenoperez@gmail.com>
Date: 2021-07-05T11:58:58+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/64190a35d5e8fe4a5d85546c548e6b4d3a43f932 [^]

Fixed ISSUE-46701: Merge branch 'fix/46701'

---
A src/org/openbravo/pos2/master/PaidReceiptsFilterProperties.java
A web-jspack/org.openbravo.pos2/src/components/ButtonBar2/ButtonBar2-BookedReturn.config.json
A web-jspack/org.openbravo.pos2/src/components/ButtonBar2/ButtonBar2-DraftReturn.config.json
A web-jspack/org.openbravo.pos2/src/components/Payments/PaymentPanel/PaymentReviewPanel.config.json
A web-jspack/org.openbravo.pos2/src/components/Ticket/TicketTypeStatus.scss
A web-jspack/org.openbravo.pos2/src/components/Ticket/TicketTypeStatusHandling.js
A web-jspack/org.openbravo.pos2/src/components/TicketList/TicketListLocalGrid/render/TicketLocalStatusCellRender.jsx
A web-jspack/org.openbravo.pos2/src/components/TicketList/TicketListRemoteGrid/render/TicketRemoteStatusCellRender.jsx
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/pos2/master/PaidReceiptProperties.java
M web-jspack/org.openbravo.pos2/src/components/ButtonBar1/ButtonBar1-BookedTicket.config.json
M web-jspack/org.openbravo.pos2/src/components/ButtonBar1/__test__/ButtonBar1.test.jsx
M web-jspack/org.openbravo.pos2/src/components/ButtonBar2/ButtonBar2-BookedTicket.config.json
M web-jspack/org.openbravo.pos2/src/components/MainPOSApp/MainPOSApp.config.json
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentList/PaymentList.jsx
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentPanel/PaymentPanel.jsx
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentPanelTitle/PaymentPanelTitle.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketHeaderBPWithDocType/__test__/TicketHeaderBPWithDocType.test.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketHeaderBPWithDocType/stories/TicketHeaderBPWithDocType.stories.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketHeaderBPWithDocType/stories/TicketHeaderBPWithDocTypeStoriesUtils.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketHeaderDocTypeLabel/TicketHeaderDocTypeLabel.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketHeaderDocTypeLabel/TicketHeaderDocTypeLabel.scss
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketHeaderDocTypeLabel/__test__/TicketHeaderDocTypeLabel.test.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketHeaderDocTypeLabel/stories/TicketHeaderDocTypeLabel.stories.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketHeaderDocTypeLabel/stories/TicketHeaderDocTypeLabelStoriesUtils.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLinePrice/stories/TicketLinePrice.stories.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLines/TicketLineSchemaLabel/TicketLineSchemaLabel.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLines/TicketLines.scss
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketSummary/TicketSummary.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketSummary/TicketSummary.scss
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketSummary/TicketSummaryView.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketSummary/__test__/TicketSummary.test.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketSummary/storybook/TicketSummary.stories.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketSummary/storybook/TicketSummaryView.stories.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketSummaryDiscountLine/stories/TicketSummaryDiscountLine.stories.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketSummaryDiscounts/stories/TicketSummaryDiscounts.stories.jsx
M web-jspack/org.openbravo.pos2/src/components/TicketList/TicketListLocalGrid/TicketListLocalGrid.config.json
M web-jspack/org.openbravo.pos2/src/components/TicketList/TicketListLocalGrid/__test__/TicketListLocalGrid.test.jsx
M web-jspack/org.openbravo.pos2/src/components/TicketList/TicketListLocalGrid/render/TicketLocalTypeCellRender.jsx
M web-jspack/org.openbravo.pos2/src/components/TicketList/TicketListLocalGrid/stories/TicketListLocalGrid.stories.jsx
M web-jspack/org.openbravo.pos2/src/components/TicketList/TicketListRemoteGrid/TicketListRemoteGrid.config.json
M web-jspack/org.openbravo.pos2/src/components/TicketList/TicketListRemoteGrid/__test__/TicketListRemoteGrid.test.jsx
M web-jspack/org.openbravo.pos2/src/components/TicketList/TicketListRemoteGrid/render/TicketRemoteTypeCellRender.jsx
M web-jspack/org.openbravo.pos2/src/components/TicketList/TicketListRemoteGrid/stories/TicketListRemoteGrid.stories.jsx
M web-jspack/org.openbravo.pos2/src/model/user-interface/layout-selectors/selectLayoutConfigBasedOnApplicationState.js
M web-jspack/org.openbravo.pos2/src/ob-init.js
R web-jspack/org.openbravo.pos2/src/components/Ticket/TicketHeaderDocTypeLabel/getDocumentTypeLabelAndStyle.js
R web-jspack/org.openbravo.pos2/src/components/TicketList/TicketListLocalGrid/render/TicketLocalTypeCellRender.scss
R web-jspack/org.openbravo.pos2/src/components/TicketList/TicketListRemoteGrid/render/TicketRemoteTypeCellRender.scss
---
(0134841)
timothee_catteeuw (developer)
2022-02-09 11:59

It works well with the new version, now after opening an already paid ticket :

A “review payment” button is displayed instead of paid button → OK

After pressing “review payment”, I can see all the payments

I can press “done” button which enables to print a duplicata -->OK

But after pressing it, duplicate ticket is printed but also notification coupon if notification product is in my basket → only duplicate ticket has to be printed.
(0135364)
timothee_catteeuw (developer)
2022-03-01 12:50

As discussed with Guillermo, I will create a new mantis.

- Issue History
Date Modified Username Field Change
2021-05-18 09:51 psanjuan New Issue
2021-05-18 09:51 psanjuan Assigned To => Retail
2021-05-18 09:51 psanjuan Triggers an Emergency Pack => No
2021-05-18 09:52 psanjuan File Added: issue_46701.png
2021-05-18 09:53 psanjuan File Added: issue_46701_2.png
2021-05-18 09:53 psanjuan Assigned To Retail => plujan
2021-05-18 20:44 dbaz File Added: Paid_Receipt.jpg
2021-05-18 20:45 dbaz Note Added: 0128353
2021-05-19 09:42 plujan Assigned To plujan => Retail
2021-05-19 09:49 psanjuan File Deleted: issue_46701.png
2021-05-19 09:49 psanjuan File Deleted: issue_46701_2.png
2021-05-19 09:50 psanjuan File Added: Issue_46701.png
2021-05-19 09:50 psanjuan File Added: Issue46701_2.png
2021-05-19 09:51 psanjuan Steps to Reproduce Updated View Revisions
2021-05-21 18:56 guilleaer Resolution time => 1624226400
2021-05-21 18:56 guilleaer Priority urgent => normal
2021-05-21 18:56 guilleaer Status new => scheduled
2021-05-21 18:56 guilleaer Status scheduled => acknowledged
2021-05-25 17:28 guilleaer Resolution time 1624226400 => 1623362400
2021-05-28 11:21 guilleaer Note Added: 0128767
2021-05-28 11:27 guilleaer Note Edited: 0128767 View Revisions
2021-06-04 13:21 dmiguelez Summary No info shown if a order is already paid, if opened. => JIRA-1754: No info shown if a order is already paid, if opened.
2021-06-07 21:10 dbaz File Added: B010 - Orders - 040.png
2021-06-07 21:10 dbaz File Added: A310 - Order Paid.png
2021-06-07 21:14 dbaz Note Added: 0129160
2021-06-08 11:33 dbaz Note Added: 0129173
2021-06-08 11:34 dbaz File Added: MinHeight.png
2021-06-08 12:10 dmiguelez Resolution time 1623362400 => 1623967200
2021-06-08 12:11 dmiguelez Note Added: 0129175
2021-06-08 14:57 guilleaer Status acknowledged => scheduled
2021-06-08 14:57 guilleaer Assigned To Retail => mtaal
2021-06-14 23:59 hgbot Note Added: 0129493
2021-06-15 15:24 mtaal Relationship added blocks 0046393
2021-06-15 20:23 mtaal Note Added: 0129528
2021-07-05 11:59 hgbot Note Added: 0130134
2021-07-05 11:59 hgbot Resolution open => fixed
2021-07-05 11:59 hgbot Status scheduled => closed
2021-07-05 11:59 hgbot Note Added: 0130135
2022-01-21 09:43 cberner Relationship added related to 0048438
2022-02-09 11:59 timothee_catteeuw Note Added: 0134841
2022-02-09 11:59 timothee_catteeuw Assigned To mtaal =>
2022-02-09 11:59 timothee_catteeuw Status closed => new
2022-02-28 08:37 guilleaer Assigned To => Retail
2022-03-01 12:50 timothee_catteeuw Note Added: 0135364
2022-03-01 12:50 timothee_catteeuw Status new => scheduled
2022-03-01 12:50 timothee_catteeuw Status scheduled => resolved
2022-03-01 12:51 timothee_catteeuw Status resolved => closed


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker