Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0048360 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] A. Platform | minor | have not tried | 2022-01-06 13:53 | 2022-01-12 10:48 | |||
| Reporter | shuehner | View Status | public | |||||
| Assigned To | shuehner | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | PR22Q2 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0048360: Remove friendlyWarnings option from build system (obsolete since: remove GUI rebuild+restart from MMC) | |||||||
| Description | The friendlyWarnings option is a left over from the MMC GUI Rebuild system which was removed in 21Q1 release. It was hiding some not so grave compile time warnings when compile was done via the UI back then with the goal of not cluttering UI log for less severe warning which could have been confusing for a entry level admin. That option was only activated when running rebuild via MMC GUI so can not be cleaned as obsolete code. | |||||||
| Steps To Reproduce | - | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||||||||
|
|||||||||||||||
 Relationships |
|
Notes |
|
|
(0134144) hgbot (developer) 2022-01-06 13:57 |
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/494 [^] |
|
(0134253) hgbot (developer) 2022-01-12 10:48 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/openbravo [^] Changeset: e24a5d382ed90972352b9c145381c619170267dd Author: Stefan Huehner <stefan.huehner@openbravo.com> Date: 12-01-2022 09:48:19 URL: https://gitlab.com/openbravo/product/openbravo/-/commit/e24a5d382ed90972352b9c145381c619170267dd [^] fixes ISSUE-48360: Remove friendlyWarnings from build-system * Removes friendlyWarnings from build That is a unused build parameter which was only set from the MMC GUI Rebuild system (removed in 21Q1). Remove it from: - some javac compile tasks passing it as nowarn option - wad validation code (where it was hiding the concrete problems) - Passing it around during ant apply.module * Removes friendlyWarnings from apply.module ant apply.module has special code to always use the friendlyWarnings for the warnings coming from DAL startup (ModelProvider and related code). Source comment explained that behavior with "unfriendly warnings" are already shown in generate.entities (run before and also having its own DAL startup) so no need to show again. Given that the same would be shown also on tomcat start + other DAL usages and the whole friendlyWarning concept is leftover from MMC GUI Rebuild remove that special case also. That will show more log-output in case those warnings get triggered but correct fix is anyway to fix the model problems (and not amount of log shown when that is not done) --- M build.xml M src-test/build.xml M src-wad/src/org/openbravo/wad/validation/WADValidator.java M src-wad/src/org/openbravo/wad/validation/WADValidatorTask.java M src/build.xml M src/org/openbravo/base/model/Column.java M src/org/openbravo/base/model/ModelProvider.java M src/org/openbravo/base/model/domaintype/BaseForeignKeyDomainType.java M src/org/openbravo/base/session/OBPropertiesProvider.java M src/org/openbravo/erpCommon/modules/ApplyModuleTask.java --- |
|
(0134254) hgbot (developer) 2022-01-12 10:48 |
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/494 [^] |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2022-01-06 13:53 | shuehner | New Issue | |
| 2022-01-06 13:53 | shuehner | Assigned To | => Triage Platform Base |
| 2022-01-06 13:53 | shuehner | Modules | => Core |
| 2022-01-06 13:53 | shuehner | Triggers an Emergency Pack | => No |
| 2022-01-06 13:54 | shuehner | Relationship added | related to 0044269 |
| 2022-01-06 13:57 | hgbot | Note Added: 0134144 | |
| 2022-01-11 11:57 | AugustoMauch | Status | new => scheduled |
| 2022-01-11 11:57 | AugustoMauch | Assigned To | Triage Platform Base => meriem_azaf |
| 2022-01-12 08:43 | alostale | Relationship added | depends on 0048384 |
| 2022-01-12 08:46 | alostale | Assigned To | meriem_azaf => shuehner |
| 2022-01-12 10:48 | hgbot | Resolution | open => fixed |
| 2022-01-12 10:48 | hgbot | Status | scheduled => closed |
| 2022-01-12 10:48 | hgbot | Fixed in Version | => PR22Q2 |
| 2022-01-12 10:48 | hgbot | Note Added: 0134253 | |
| 2022-01-12 10:48 | hgbot | Note Added: 0134254 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |