Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0048360Openbravo ERPA. Platformpublic2022-01-06 13:532022-01-12 10:48
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionPR22Q2 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0048360: Remove friendlyWarnings option from build system (obsolete since: remove GUI rebuild+restart from MMC)
DescriptionThe friendlyWarnings option is a left over from the MMC GUI Rebuild system which was removed in 21Q1 release.

It was hiding some not so grave compile time warnings when compile was done via the UI back then with the goal of not cluttering UI log for less severe warning which could have been confusing for a entry level admin.

That option was only activated when running rebuild via MMC GUI so can not be cleaned as obsolete code.
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0044269 closed alostale remove GUI rebuild+restart from MMC 
depends on defect 0048384 closed alostale API change: removed friendlyWarnings getters and setters 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2022-01-06 13:53shuehnerNew Issue
2022-01-06 13:53shuehnerAssigned To => Triage Platform Base
2022-01-06 13:53shuehnerModules => Core
2022-01-06 13:53shuehnerTriggers an Emergency Pack => No
2022-01-06 13:54shuehnerRelationship addedrelated to 0044269
2022-01-06 13:57hgbotNote Added: 0134144
2022-01-11 11:57AugustoMauchStatusnew => scheduled
2022-01-11 11:57AugustoMauchAssigned ToTriage Platform Base => meriem_azaf
2022-01-12 08:43alostaleRelationship addeddepends on 0048384
2022-01-12 08:46alostaleAssigned Tomeriem_azaf => shuehner
2022-01-12 10:48hgbotResolutionopen => fixed
2022-01-12 10:48hgbotStatusscheduled => closed
2022-01-12 10:48hgbotFixed in Version => PR22Q2
2022-01-12 10:48hgbotNote Added: 0134253
2022-01-12 10:48hgbotNote Added: 0134254

Notes
(0134144)
hgbot   
2022-01-06 13:57   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/494 [^]
(0134253)
hgbot   
2022-01-12 10:48   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: e24a5d382ed90972352b9c145381c619170267dd
Author: Stefan Huehner <stefan.huehner@openbravo.com>
Date: 12-01-2022 09:48:19
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/e24a5d382ed90972352b9c145381c619170267dd [^]

fixes ISSUE-48360: Remove friendlyWarnings from build-system

* Removes friendlyWarnings from build
   That is a unused build parameter which was only set from the MMC GUI
    Rebuild system (removed in 21Q1).
    Remove it from:
    - some javac compile tasks passing it as nowarn option
    - wad validation code (where it was hiding the concrete problems)
    - Passing it around during ant apply.module

* Removes friendlyWarnings from apply.module
    ant apply.module has special code to always use the friendlyWarnings for
    the warnings coming from DAL startup (ModelProvider and related code).
    
    Source comment explained that behavior with "unfriendly warnings" are
    already shown in generate.entities (run before and also having its own
    DAL startup) so no need to show again.
    
    Given that the same would be shown also on tomcat start + other DAL
    usages and the whole friendlyWarning concept is leftover from MMC GUI
    Rebuild remove that special case also.
    
    That will show more log-output in case those warnings get triggered but
    correct fix is anyway to fix the model problems (and not amount of log
    shown when that is not done)


---
M build.xml
M src-test/build.xml
M src-wad/src/org/openbravo/wad/validation/WADValidator.java
M src-wad/src/org/openbravo/wad/validation/WADValidatorTask.java
M src/build.xml
M src/org/openbravo/base/model/Column.java
M src/org/openbravo/base/model/ModelProvider.java
M src/org/openbravo/base/model/domaintype/BaseForeignKeyDomainType.java
M src/org/openbravo/base/session/OBPropertiesProvider.java
M src/org/openbravo/erpCommon/modules/ApplyModuleTask.java
---
(0134254)
hgbot   
2022-01-12 10:48   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/494 [^]