Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0048354 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] 00. Application dictionary | major | always | 2022-01-05 10:15 | 2022-02-18 15:27 | |||
| Reporter | AugustoMauch | View Status | public | |||||
| Assigned To | AugustoMauch | |||||||
| Priority | high | Resolution | fixed | Fixed in Version | PR22Q2 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | pi | SCM revision | ||||||
| Review Assigned To | ||||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0048354: Error translating a discount and promotion | |||||||
| Description | Error translating a discount and promotion after editing in grid view Previous fix done in this issue was backed out because it broke CI: https://issues.openbravo.com/view.php?id=48153 [^] | |||||||
| Steps To Reproduce | -Go to discount and promotions -Create a translation in form view -Go to grid view -Edit and remove the language -Press save --> you will see red rectangle with the error -Press Edit -You will see Albanian as selected -Press save The error appears again You need to select manually the lang to avoid the error | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||||||
|
|||||||||||||
 Relationships |
|
Notes |
|
|
(0134128) hgbot (developer) 2022-01-05 10:21 |
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/491 [^] |
|
(0134248) hgbot (developer) 2022-01-12 10:18 |
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/491 [^] |
|
(0134249) hgbot (developer) 2022-01-12 10:18 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/openbravo [^] Changeset: c1cde3801ab41935329179b1f0ffb35d333d7f2f Author: Augusto Mauch <augusto.mauch@openbravo.com> Date: 12-01-2022 09:17:29 URL: https://gitlab.com/openbravo/product/openbravo/-/commit/c1cde3801ab41935329179b1f0ffb35d333d7f2f [^] Fixes ISSUE-48354: Validating error cleared when no mandatory fields are empty To reproduce the issue, the user had to: - create a record, filling in all mandatory fields - empty one of the mandatory fields and save, an expected validation error was raised - edit the line in grid view, mandatory field is given a default value (the FIC does it), but after trying to save the validation error does not go away and the new value is not saved The problem was that even though the FIC was providing a valid default value for the empty mandatory field, the save process was not trying to save the record because it mistakingly thought that the edit form had not been changed. To fix this, when processing the FIC return the setHasChanged function is invoked if the FIC has provided a not-null value for a field that used to be empty. Change only needs to be done on grid view, because: - in form view the problem is not reproducible - if done in form view, UI will detect changes that are not real (i.e. fields that are visible in form view but not in grid view being filled in by the FIC) --- M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js --- |
|
(0135137) rafaroda (developer) 2022-02-18 15:27 |
So this has been finally rollbacked without final resolution? |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2022-01-05 10:15 | AugustoMauch | New Issue | |
| 2022-01-05 10:15 | AugustoMauch | Assigned To | => AugustoMauch |
| 2022-01-05 10:15 | AugustoMauch | Modules | => Core |
| 2022-01-05 10:15 | AugustoMauch | Triggers an Emergency Pack | => No |
| 2022-01-05 10:15 | AugustoMauch | Issue generated from | 0048153 |
| 2022-01-05 10:16 | AugustoMauch | Status | new => scheduled |
| 2022-01-05 10:16 | AugustoMauch | Summary | Error translating a discount and promotion - => Error translating a discount and promotion |
| 2022-01-05 10:16 | AugustoMauch | Description Updated | View Revisions |
| 2022-01-05 10:21 | hgbot | Note Added: 0134128 | |
| 2022-01-12 10:18 | hgbot | Note Added: 0134248 | |
| 2022-01-12 10:18 | hgbot | Resolution | open => fixed |
| 2022-01-12 10:18 | hgbot | Status | scheduled => closed |
| 2022-01-12 10:18 | hgbot | Fixed in Version | => PR22Q2 |
| 2022-01-12 10:18 | hgbot | Note Added: 0134249 | |
| 2022-01-12 10:37 | AugustoMauch | Issue cloned | 0048385 |
| 2022-02-18 15:27 | rafaroda | Note Added: 0135137 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |