Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0048354Openbravo ERP00. Application dictionarypublic2022-01-05 10:152022-02-18 15:27
ReporterAugustoMauch 
Assigned ToAugustoMauch 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in VersionPR22Q2 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0048354: Error translating a discount and promotion
DescriptionError translating a discount and promotion after editing in grid view

Previous fix done in this issue was backed out because it broke CI: https://issues.openbravo.com/view.php?id=48153 [^]
Steps To Reproduce-Go to discount and promotions
-Create a translation in form view
-Go to grid view
-Edit and remove the language
-Press save --> you will see red rectangle with the error
-Press Edit
-You will see Albanian as selected
-Press save

The error appears again

You need to select manually the lang to avoid the error
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0048355PR22Q1 closed AugustoMauch Error translating a discount and promotion - 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2022-01-05 10:15AugustoMauchNew Issue
2022-01-05 10:15AugustoMauchAssigned To => AugustoMauch
2022-01-05 10:15AugustoMauchOBNetwork customer => OBPS
2022-01-05 10:15AugustoMauchModules => Core
2022-01-05 10:15AugustoMauchTriggers an Emergency Pack => No
2022-01-05 10:15AugustoMauchIssue generated from0048153
2022-01-05 10:16AugustoMauchStatusnew => scheduled
2022-01-05 10:16AugustoMauchSummaryError translating a discount and promotion - => Error translating a discount and promotion
2022-01-05 10:16AugustoMauchDescription Updatedbug_revision_view_page.php?rev_id=23482#r23482
2022-01-05 10:21hgbotMerge Request Status => open
2022-01-05 10:21hgbotNote Added: 0134128
2022-01-12 10:17hgbotMerge Request Statusopen => approved
2022-01-12 10:18hgbotNote Added: 0134248
2022-01-12 10:18hgbotResolutionopen => fixed
2022-01-12 10:18hgbotStatusscheduled => closed
2022-01-12 10:18hgbotFixed in Version => PR22Q2
2022-01-12 10:18hgbotNote Added: 0134249
2022-01-12 10:37AugustoMauchIssue cloned0048385
2022-02-18 15:27rafarodaNote Added: 0135137

Notes
(0134128)
hgbot   
2022-01-05 10:21   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/491 [^]
(0134248)
hgbot   
2022-01-12 10:18   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/491 [^]
(0134249)
hgbot   
2022-01-12 10:18   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: c1cde3801ab41935329179b1f0ffb35d333d7f2f
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 12-01-2022 09:17:29
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/c1cde3801ab41935329179b1f0ffb35d333d7f2f [^]

Fixes ISSUE-48354: Validating error cleared when no mandatory fields are empty

To reproduce the issue, the user had to:
- create a record, filling in all mandatory fields
- empty one of the mandatory fields and save, an expected validation error was raised
- edit the line in grid view, mandatory field is given a default value (the FIC does it), but
after trying to save the validation error does not go away and the new value is not saved

The problem was that even though the FIC was providing a valid default value for the empty
mandatory field, the save process was not trying to save the record because it mistakingly
thought that the edit form had not been changed. To fix this, when processing the FIC return the
setHasChanged function is invoked if the FIC has provided a not-null value for a field that used
to be empty.

Change only needs to be done on grid view, because:
- in form view the problem is not reproducible
- if done in form view, UI will detect changes that are not real (i.e. fields that are visible in form view but not in grid view being filled in by the FIC)

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js
---
(0135137)
rafaroda   
2022-02-18 15:27   
So this has been finally rollbacked without final resolution?