Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0048326 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Retail Modules] Web POS | minor | always | 2021-12-24 13:02 | 2022-06-03 08:53 | |||
| Reporter | justin_patterson | View Status | public | |||||
| Assigned To | rqueralta | |||||||
| Priority | high | Resolution | fixed | Fixed in Version | RR22Q3 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Linux 64 bit | Database | PostgreSQL | Java version | 11 | |||
| OS Version | Elementary OS 6.1 | Database version | 11 | Ant version | 1.10 | |||
| Product Version | SCM revision | |||||||
| Merge Request Status | approved | |||||||
| Review Assigned To | ||||||||
| OBNetwork customer | Gold | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0048326: Customer details shown as empty if edit canceled before filled | |||||||
| Description | In POS>Manage Customer Details>Edit, if detail is left empty, pressing "cancel" will show empty detail in detail summary, effectively making it seem like the value has been saved as empty. | |||||||
| Steps To Reproduce | 1. In POS, click on Customer box and select any customer 2. Click three dots on the right, then click "Manage Addresses" 3. Click three dots again, then "Show Details" 4. Click "Edit" 5. Delete value of a field, click save a couple of times, then click cancel 6. See that the value is now marked as empty | |||||||
| Proposed Solution | There is a reassignment of this.customerAddr inside of the call to cancelClose() when cancel button is clicked that resets field values without validation. I propose we simply omit this call, as when popup is hidden information is automatically preserved. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files |  cancelClosePatch.txt [^] (713 bytes) 2021-12-24 13:02 [Show Content]
| |||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0137200) hgbot (developer) 2022-05-12 04:57 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/794 [^] |
|
(0137685) hgbot (developer) 2022-05-24 21:06 |
Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/794 [^] |
|
(0138015) hgbot (developer) 2022-06-03 08:53 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/794 [^] |
|
(0138016) hgbot (developer) 2022-06-03 08:53 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^] Changeset: e8c1d848b50c414c39c7d05f9e7d30ad6915b4fb Author: Rafael Queralta <rafaelcuba81@gmail.com> Date: 03-06-2022 06:39:14 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/e8c1d848b50c414c39c7d05f9e7d30ad6915b4fb [^] Fixed BUG-48326: Call the validateForm function before save customer address to avoid save mandatory fields with empty values --- M web/org.openbravo.retail.posterminal/js/pointofsale/view/subwindows/customeraddress/components/sharedcomponents.js --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2021-12-24 13:02 | justin_patterson | New Issue | |
| 2021-12-24 13:02 | justin_patterson | Assigned To | => justin_patterson |
| 2021-12-24 13:02 | justin_patterson | File Added: cancelClosePatch.txt | |
| 2021-12-24 13:02 | justin_patterson | OBNetwork customer | => No |
| 2021-12-24 13:02 | justin_patterson | Triggers an Emergency Pack | => No |
| 2022-03-15 17:03 | kchoperena | Priority | low => high |
| 2022-03-31 11:47 | kchoperena | Assigned To | justin_patterson => Retail |
| 2022-04-04 07:08 | marvintm | OBNetwork customer | No => Gold |
| 2022-04-08 00:12 | rqueralta | Assigned To | Retail => rqueralta |
| 2022-04-08 00:12 | rqueralta | Status | new => scheduled |
| 2022-05-12 04:57 | hgbot | Merge Request Status | => open |
| 2022-05-12 04:57 | hgbot | Note Added: 0137200 | |
| 2022-05-24 21:06 | hgbot | Note Added: 0137685 | |
| 2022-06-03 08:53 | hgbot | Merge Request Status | open => approved |
| 2022-06-03 08:53 | hgbot | Resolution | open => fixed |
| 2022-06-03 08:53 | hgbot | Status | scheduled => closed |
| 2022-06-03 08:53 | hgbot | Note Added: 0138015 | |
| 2022-06-03 08:53 | hgbot | Fixed in Version | => RR22Q3 |
| 2022-06-03 08:53 | hgbot | Note Added: 0138016 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |