0048326: Customer details shown as empty if edit canceled before filled

Description

In POS>Manage Customer Details>Edit, if detail is left empty, pressing "cancel" will show empty detail in detail summary, effectively making it seem like the value has been saved as empty.

Steps To Reproduce

1. In POS, click on Customer box and select any customer
2. Click three dots on the right, then click "Manage Addresses"
3. Click three dots again, then "Show Details"
4. Click "Edit"
5. Delete value of a field, click save a couple of times, then click cancel
6. See that the value is now marked as empty

Proposed Solution

There is a reassignment of this.customerAddr inside of the call to cancelClose() when cancel button is clicked that resets field values without validation.

I propose we simply omit this call, as when popup is hidden information is automatically preserved.

Tags

No tags attached.

Attached Files

cancelClosePatch.txt [^] (713 bytes) 2021-12-24 13:02 [Show Content] [Hide Content]

diff --git a/web/org.openbravo.retail.posterminal/js/pointofsale/view/subwindows/customeraddress/editcreatecustomeraddress.js b/web/org.openbravo.retail.posterminal/js/pointofsale/view/subwindows/customeraddress/editcreatecustomeraddress.js
index 48ebb6492..14accfb25 100644
--- a/web/org.openbravo.retail.posterminal/js/pointofsale/view/subwindows/customeraddress/editcreatecustomeraddress.js
+++ b/web/org.openbravo.retail.posterminal/js/pointofsale/view/subwindows/customeraddress/editcreatecustomeraddress.js
@@ -34,7 +34,6 @@ enyo.kind({
     return retrievedValues;
   },
   cancelClose: function(inSender, inEvent) {
-    this.customerAddr = inEvent.customerAddr;
     this.hide();
     return true;
   },

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0137200) hgbot (developer) 2022-05-12 04:57	Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/794 [^]

Issue History
Date Modified	Username	Field	Change
2021-12-24 13:02	justin_patterson	New Issue
2021-12-24 13:02	justin_patterson	Assigned To	=> justin_patterson
2021-12-24 13:02	justin_patterson	File Added: cancelClosePatch.txt
2021-12-24 13:02	justin_patterson	Triggers an Emergency Pack	=> No
2022-03-15 17:03	kchoperena	Priority	low => high
2022-03-31 11:47	kchoperena	Assigned To	justin_patterson => Retail
2022-04-08 00:12	rqueralta	Assigned To	Retail => rqueralta
2022-04-08 00:12	rqueralta	Status	new => scheduled
2022-05-12 04:57	hgbot	Note Added: 0137200