Openbravo Issue Tracking System - Retail Modules
View Issue Details
0048326Retail ModulesWeb POSpublic2021-12-24 13:022022-06-03 08:53
justin_patterson 
rqueralta 
highminoralways
closedfixed 
30Elementary OS 6.1
 
RR22Q3 
No
0048326: Customer details shown as empty if edit canceled before filled
In POS>Manage Customer Details>Edit, if detail is left empty, pressing "cancel" will show empty detail in detail summary, effectively making it seem like the value has been saved as empty.
1. In POS, click on Customer box and select any customer
2. Click three dots on the right, then click "Manage Addresses"
3. Click three dots again, then "Show Details"
4. Click "Edit"
5. Delete value of a field, click save a couple of times, then click cancel
6. See that the value is now marked as empty
There is a reassignment of this.customerAddr inside of the call to cancelClose() when cancel button is clicked that resets field values without validation.

I propose we simply omit this call, as when popup is hidden information is automatically preserved.
No tags attached.
txt cancelClosePatch.txt (713) 2021-12-24 13:02
https://issues.openbravo.com/file_download.php?file_id=16475&type=bug
Issue History
2021-12-24 13:02justin_pattersonNew Issue
2021-12-24 13:02justin_pattersonAssigned To => justin_patterson
2021-12-24 13:02justin_pattersonFile Added: cancelClosePatch.txt
2021-12-24 13:02justin_pattersonTriggers an Emergency Pack => No
2022-03-15 17:03kchoperenaPrioritylow => high
2022-03-31 11:47kchoperenaAssigned Tojustin_patterson => Retail
2022-04-08 00:12rqueraltaAssigned ToRetail => rqueralta
2022-04-08 00:12rqueraltaStatusnew => scheduled
2022-05-12 04:57hgbotNote Added: 0137200
2022-05-24 21:06hgbotNote Added: 0137685
2022-06-03 08:53hgbotResolutionopen => fixed
2022-06-03 08:53hgbotStatusscheduled => closed
2022-06-03 08:53hgbotNote Added: 0138015
2022-06-03 08:53hgbotFixed in Version => RR22Q3
2022-06-03 08:53hgbotNote Added: 0138016

Notes
(0137200)
hgbot   
2022-05-12 04:57   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/794 [^]
(0137685)
hgbot   
2022-05-24 21:06   
Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/794 [^]
(0138015)
hgbot   
2022-06-03 08:53   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/794 [^]
(0138016)
hgbot   
2022-06-03 08:53   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: e8c1d848b50c414c39c7d05f9e7d30ad6915b4fb
Author: Rafael Queralta <rafaelcuba81@gmail.com>
Date: 03-06-2022 06:39:14
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/e8c1d848b50c414c39c7d05f9e7d30ad6915b4fb [^]

Fixed BUG-48326: Call the validateForm function before save customer address to avoid save mandatory fields with empty values

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/subwindows/customeraddress/components/sharedcomponents.js
---