Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0048274
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[POS2] Coreminorhave not tried2021-12-17 13:022022-12-12 16:00
ReportercaristuView Statuspublic 
Assigned Tocberner 
PriorityhighResolutionfixedFixed in Version23Q1
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0048274: userActionInProgress state property incorrectly set to null in some cases

DescriptionIf we have a UIAction "A" which invokes a different UIAction "B" (for example in a post hook) then the userActionInProgress state property is incorrectly set to null after "B" finishes.

This is not correct userActionInProgress should be "A" when "B" finishes.
Steps To Reproduce1- Create a new ticket
2- Add a couple of products
3- Select a line
4- Unselect the previously selected line. Check the state changes, the following sequence of changes has been applied to the userActionInProgress property
  > null --> OBPOS2_SelectLine (OK)
  > OBPOS2_SelectLine --> OBPOS2_SetMultiLineSelection (OK)
  > OBPOS2_SetMultiLineSelection --> null (WRONG): instead of null it should be restored to OBPOS2_SelectLine and once OBPOS2_SelectLine finishes then set back to null again
Proposed SolutionThe proposed fix for this issue was implemented in 0048144 but then reverted in 0048269, because when we login in POS2, the are two user actions ('OBPOS2_SelectKeymapCategory', 'OBC2_setKeymapPages') whose execution is being overlapped causing the stack not being cleared properly, and therefore the UserAction Scrim is always shown, blocking every user operation.

The final fix should also take into account that scenario to avoid breaking the POS
TagsNo tags attached.
Attached Filespng file icon 1.png [^] (8,999 bytes) 2021-12-17 13:05


png file icon 2.png [^] (12,163 bytes) 2021-12-17 13:05


png file icon 3.png [^] (10,109 bytes) 2021-12-17 13:05

- Relationships Relation Graph ] Dependency Graph ]
related to defect 0048144 closedcaristu userActionInProgress state property incorrectly set to null in some cases 
related to defect 0048269 closedcaristu POS2 is stuck in loading status 

-  Notes
(0144168)
hgbot (developer)
2022-11-25 16:18

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/930 [^]
(0144169)
hgbot (developer)
2022-11-25 16:20

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1389 [^]
(0144537)
hgbot (developer)
2022-12-12 16:00

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/930 [^]
(0144538)
hgbot (developer)
2022-12-12 16:00

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: ea59cfd99f30cbc2c03aeafb1475e94cc32fba31
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 12-12-2022 15:00:20
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/ea59cfd99f30cbc2c03aeafb1475e94cc32fba31 [^]

Fixes ISSUE-48274: Keep track of all in progress user actions instead of only the last one

Changes how in progress user action is being tracked. Previously it was a string, and now it is a stack that keeps all the in progress user actions, and not only the last one. By doing so, we're able to track parent user actions that call child user actions, without losing them when the child user action finishes.

---
A web-jspack/org.openbravo.core2/src/core/user-action/__test__/UseUserActionInProgress.test.jsx
A web-jspack/org.openbravo.core2/src/core/user-action/useUserActionInProgress.js
A web-jspack/org.openbravo.core2/src/model/user-interface/__test__/UserActionInProgressStack.test.js
A web-jspack/org.openbravo.core2/src/model/user-interface/actions/UserActionInProgressStack.js
M web-jspack/org.openbravo.core2/src/components/BaseDialog/__test__/BaseDialog.test.jsx
M web-jspack/org.openbravo.core2/src/components/BasePopover/__test__/BasePopover.test.jsx
M web-jspack/org.openbravo.core2/src/components/BasePopover/stories/BasePopover.stories.jsx
M web-jspack/org.openbravo.core2/src/components/Scrim/UserActionScrim/UserActionScrim.jsx
M web-jspack/org.openbravo.core2/src/components/Scrim/UserActionScrim/__test__/UserActionScrim.test.jsx
M web-jspack/org.openbravo.core2/src/components/Scrim/UserActionScrim/stories/UserActionScrim.stories.jsx
M web-jspack/org.openbravo.core2/src/core/user-action/UserAction.js
M web-jspack/org.openbravo.core2/src/hooks/useLockableStackOrder/__test__/useLockableStackOrder.test.jsx
M web-jspack/org.openbravo.core2/src/hooks/useLockableStackOrder/useLockableStackOrder.js
M web-jspack/org.openbravo.core2/src/model/user-interface/UI.js
R web-jspack/org.openbravo.core2/src/model/user-interface/actions/SetUserActionInProgress.js
---
(0144539)
hgbot (developer)
2022-12-12 16:00

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 186cbec8965158794a71d78fe13a1bbdfe042f7d
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 12-12-2022 15:55:44
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/186cbec8965158794a71d78fe13a1bbdfe042f7d [^]

Related to ISSUE-48274: userActionInProgress state property incorrectly set to null in some cases

Fixes some tests due to the changes on how userActionInProgress works
now. Previously it was a single string and now it is an array of
actions.

---
M web-jspack/org.openbravo.pos2/src/model/user-interface/__test__/SelectCurrentSchema.test.js
---
(0144540)
hgbot (developer)
2022-12-12 16:00

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1389 [^]

- Issue History
Date Modified Username Field Change
2021-12-17 13:02 caristu New Issue
2021-12-17 13:02 caristu Assigned To => caristu
2021-12-17 13:02 caristu Triggers an Emergency Pack => No
2021-12-17 13:02 caristu Issue generated from 0048144
2021-12-17 13:02 caristu Relationship added related to 0048144
2021-12-17 13:02 caristu Status new => acknowledged
2021-12-17 13:03 caristu Relationship added related to 0048269
2021-12-17 13:05 caristu File Added: 1.png
2021-12-17 13:05 caristu File Added: 2.png
2021-12-17 13:05 caristu File Added: 3.png
2021-12-21 13:51 caristu Proposed Solution updated
2021-12-23 12:55 caristu Assigned To caristu => platform
2021-12-23 17:41 AugustoMauch Assigned To platform => Triage Platform Base
2022-11-25 16:18 hgbot Note Added: 0144168
2022-11-25 16:20 hgbot Note Added: 0144169
2022-11-25 16:35 cberner Assigned To Triage Platform Base => cberner
2022-12-12 16:00 hgbot Resolution open => fixed
2022-12-12 16:00 hgbot Status acknowledged => closed
2022-12-12 16:00 hgbot Note Added: 0144537
2022-12-12 16:00 hgbot Fixed in Version => 23Q1
2022-12-12 16:00 hgbot Note Added: 0144538
2022-12-12 16:00 hgbot Note Added: 0144539
2022-12-12 16:00 hgbot Note Added: 0144540


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker