Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0048144 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [POS2] Core | minor | have not tried | 2021-11-23 18:04 | 2021-12-17 13:02 | |||
| Reporter | caristu | View Status | public | |||||
| Assigned To | caristu | |||||||
| Priority | high | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0048144: userActionInProgress state property incorrectly set to null in some cases | |||||||
| Description | If we have a UIAction "A" which invokes a different UIAction "B" (for example in a post hook) then the userActionInProgress state property is incorrectly set to null after "B" finishes. This is not correct userActionInProgress should be "A" when "B" finishes. | |||||||
| Steps To Reproduce | 1- Create a new ticket 2- Add a couple of products 3- Select a line 4- Unselect the previously selected line. Check the state changes, the following sequence of changes has been applied to the userActionInProgress property > null --> OBPOS2_SelectLine (OK) > OBPOS2_SelectLine --> OBPOS2_SetMultiLineSelection (OK) > OBPOS2_SetMultiLineSelection --> null (WRONG): instead of null it should be restored to OBPOS2_SelectLine and once OBPOS2_SelectLine finishes then set back to null again | |||||||
| Tags | No tags attached. | |||||||
| Attached Files |  1.png [^] (8,999 bytes) 2021-11-23 18:05
2.png [^] (12,163 bytes) 2021-11-23 18:05
3.png [^] (10,109 bytes) 2021-11-23 18:05
| |||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||||||||
|
|||||||||||||||
 Relationships |
|
Notes |
|
|
(0133311) hgbot (developer) 2021-11-23 19:12 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/671 [^] |
|
(0133478) hgbot (developer) 2021-12-02 10:25 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/745 [^] |
|
(0133778) hgbot (developer) 2021-12-16 16:58 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/671 [^] |
|
(0133779) hgbot (developer) 2021-12-16 16:58 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^] Changeset: d3645abc217a55e68fb995d4ee7c64d4c80ed833 Author: Carlos Aristu <carlos.aristu@openbravo.com> Date: 16-12-2021 16:37:42 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/d3645abc217a55e68fb995d4ee7c64d4c80ed833 [^] fixes ISSUE-48144: handle user action in progress with a stack When a UIAction "A" was invoking another UIAction "B", for example through a post-hook, when "B" finished the userActionInProgress was being wrongly set to null. Instead of that, we are now replacing the userActionInProgress state property with inProgressStack. This new property contains the stack of user actions being executed, being the user action currently in progress the one at the top of the stack. --- A web-jspack/org.openbravo.core2/src/core/user-action/__test__/UseUserActionInProgress.test.jsx A web-jspack/org.openbravo.core2/src/core/user-action/useUserActionInProgress.js A web-jspack/org.openbravo.core2/src/model/user-interface/__test__/UserActionInProgressStack.test.js A web-jspack/org.openbravo.core2/src/model/user-interface/actions/UserActionInProgressStack.js M web-jspack/org.openbravo.core2/src/components/BaseDialog/__test__/BaseDialog.test.jsx M web-jspack/org.openbravo.core2/src/components/BasePopover/__test__/BasePopover.test.jsx M web-jspack/org.openbravo.core2/src/components/BasePopover/stories/BasePopover.stories.jsx M web-jspack/org.openbravo.core2/src/components/Scrim/UserActionScrim/UserActionScrim.jsx M web-jspack/org.openbravo.core2/src/components/Scrim/UserActionScrim/__test__/UserActionScrim.test.jsx M web-jspack/org.openbravo.core2/src/components/Scrim/UserActionScrim/stories/UserActionScrim.stories.jsx M web-jspack/org.openbravo.core2/src/core/user-action/UserAction.js M web-jspack/org.openbravo.core2/src/hooks/useLockableStackOrder/__test__/useLockableStackOrder.test.jsx M web-jspack/org.openbravo.core2/src/hooks/useLockableStackOrder/useLockableStackOrder.js M web-jspack/org.openbravo.core2/src/model/user-interface/UI.js R web-jspack/org.openbravo.core2/src/model/user-interface/actions/SetUserActionInProgress.js --- |
|
(0133780) hgbot (developer) 2021-12-16 16:58 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/745 [^] |
|
(0133781) hgbot (developer) 2021-12-16 16:58 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^] Changeset: 4f6bef4d72d7bfc75cd66bb023992db1d8479547 Author: Carlos Aristu <carlos.aristu@openbravo.com> Date: 16-12-2021 16:38:16 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/4f6bef4d72d7bfc75cd66bb023992db1d8479547 [^] related to ISSUE-48144: mock new state actions --- M web-jspack/org.openbravo.pos2/src/model/user-interface/__test__/SelectCurrentSchema.test.js --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2021-11-23 18:04 | caristu | New Issue | |
| 2021-11-23 18:04 | caristu | Assigned To | => Retail |
| 2021-11-23 18:04 | caristu | Triggers an Emergency Pack | => No |
| 2021-11-23 18:05 | caristu | Assigned To | Retail => platform |
| 2021-11-23 18:05 | caristu | File Added: 1.png | |
| 2021-11-23 18:05 | caristu | File Added: 2.png | |
| 2021-11-23 18:05 | caristu | File Added: 3.png | |
| 2021-11-23 19:12 | hgbot | Note Added: 0133311 | |
| 2021-12-01 19:55 | AugustoMauch | Status | new => scheduled |
| 2021-12-02 10:25 | hgbot | Note Added: 0133478 | |
| 2021-12-02 10:56 | caristu | Assigned To | platform => caristu |
| 2021-12-16 16:58 | hgbot | Note Added: 0133778 | |
| 2021-12-16 16:58 | hgbot | Resolution | open => fixed |
| 2021-12-16 16:58 | hgbot | Status | scheduled => closed |
| 2021-12-16 16:58 | hgbot | Note Added: 0133779 | |
| 2021-12-16 16:58 | hgbot | Note Added: 0133780 | |
| 2021-12-16 16:58 | hgbot | Note Added: 0133781 | |
| 2021-12-17 11:04 | caristu | Relationship added | causes 0048269 |
| 2021-12-17 13:02 | caristu | Issue cloned | 0048274 |
| 2021-12-17 13:02 | caristu | Relationship added | related to 0048274 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |