Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0048198
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSminorhave not tried2021-12-07 11:482021-12-09 10:10
ReportershuehnerView Statuspublic 
Assigned Toshuehner 
PrioritynormalResolutionfixedFixed in VersionRR22Q1
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0048198: Delete module script from issue 41027 added in 19Q4 (it never worked)

DescriptionIssue 41027 added a new feature to change how the incremental refresh worked.

As part of that work a modulescript was added to keep the existing behavior for older instances (coming from <19Q4).

However when adding that modulescript is was missing to add the compiled build folder (which is required for modulescripts) so it never ran.

That means in practice every update done since 19Q4 did opt-in to the new behavior.

As that has been happening for over 2 years now it is the de-facto standard.

After discussing with AMO plan is to remove the modulescript as the 'new behavior' added in 41027 gives also better user experience.
Steps To Reproducecheck mobile.core module for files related to:
MantainMasterdataRefreshBehaviour41027

in the folder
build/classes/org/openbravo/mobile/core/modulescript/

=> They are missing
Proposed SolutionRemove the modulescript
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to feature request 0041027 closedgorka_gil Optimize masterdata incremental refresh process 

-  Notes
(0133512)
hgbot (developer)
2021-12-07 11:53

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/310 [^]
(0133524)
hgbot (developer)
2021-12-09 07:35

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: 9ac4dfac1dea627e8813d4270e81c4cb085f1e6e
Author: Stefan Huehner <stefan.huehner@openbravo.com>
Date: 2021-12-07T11:50:28+01:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/9ac4dfac1dea627e8813d4270e81c4cb085f1e6e [^]

Fixes ISSUE-48198: Remove modulescript which never worked

Adding that modulescript in issue 41027 missed to commit the
related build/classes files which are requried for it to actually run.

As that happened over 2 years ago adopt the current behavior (to not
disable feature from 41027 on updates) officially.

=> Remove the source files of the modulescript

---
R src-util/modulescript/src/org/openbravo/mobile/core/modulescript/MantainMasterdataRefreshBehaviour41027.java
R src-util/modulescript/src/org/openbravo/mobile/core/modulescript/MantainMasterdataRefreshBehaviour41027_Data.xsql
R src-util/modulescript/src/src/org/openbravo/mobile/core/modulescript/MantainMasterdataRefreshBehaviour41027Data.java
---
(0133525)
hgbot (developer)
2021-12-09 07:35

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/310 [^]

- Issue History
Date Modified Username Field Change
2021-12-07 11:48 shuehner New Issue
2021-12-07 11:48 shuehner Assigned To => Retail
2021-12-07 11:48 shuehner Triggers an Emergency Pack => No
2021-12-07 11:52 shuehner Relationship added related to 0041027
2021-12-07 11:53 hgbot Note Added: 0133512
2021-12-09 07:35 hgbot Resolution open => fixed
2021-12-09 07:35 hgbot Status new => closed
2021-12-09 07:35 hgbot Fixed in Version => RR22Q1
2021-12-09 07:35 hgbot Note Added: 0133524
2021-12-09 07:35 hgbot Note Added: 0133525
2021-12-09 10:10 shuehner Assigned To Retail => shuehner

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker