Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0048198Retail ModulesWeb POSpublic2021-12-07 11:482021-12-09 10:10
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR22Q1 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0048198: Delete module script from issue 41027 added in 19Q4 (it never worked)
DescriptionIssue 41027 added a new feature to change how the incremental refresh worked.

As part of that work a modulescript was added to keep the existing behavior for older instances (coming from <19Q4).

However when adding that modulescript is was missing to add the compiled build folder (which is required for modulescripts) so it never ran.

That means in practice every update done since 19Q4 did opt-in to the new behavior.

As that has been happening for over 2 years now it is the de-facto standard.

After discussing with AMO plan is to remove the modulescript as the 'new behavior' added in 41027 gives also better user experience.
Steps To Reproducecheck mobile.core module for files related to:
MantainMasterdataRefreshBehaviour41027

in the folder
build/classes/org/openbravo/mobile/core/modulescript/

=> They are missing
Proposed SolutionRemove the modulescript
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0041027 closed gorka_gil Optimize masterdata incremental refresh process 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-12-07 11:48shuehnerNew Issue
2021-12-07 11:48shuehnerAssigned To => Retail
2021-12-07 11:48shuehnerTriggers an Emergency Pack => No
2021-12-07 11:52shuehnerRelationship addedrelated to 0041027
2021-12-07 11:53hgbotNote Added: 0133512
2021-12-09 07:35hgbotResolutionopen => fixed
2021-12-09 07:35hgbotStatusnew => closed
2021-12-09 07:35hgbotFixed in Version => RR22Q1
2021-12-09 07:35hgbotNote Added: 0133524
2021-12-09 07:35hgbotNote Added: 0133525
2021-12-09 10:10shuehnerAssigned ToRetail => shuehner

Notes
(0133512)
hgbot   
2021-12-07 11:53   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/310 [^]
(0133524)
hgbot   
2021-12-09 07:35   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: 9ac4dfac1dea627e8813d4270e81c4cb085f1e6e
Author: Stefan Huehner <stefan.huehner@openbravo.com>
Date: 2021-12-07T11:50:28+01:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/9ac4dfac1dea627e8813d4270e81c4cb085f1e6e [^]

Fixes ISSUE-48198: Remove modulescript which never worked

Adding that modulescript in issue 41027 missed to commit the
related build/classes files which are requried for it to actually run.

As that happened over 2 years ago adopt the current behavior (to not
disable feature from 41027 on updates) officially.

=> Remove the source files of the modulescript

---
R src-util/modulescript/src/org/openbravo/mobile/core/modulescript/MantainMasterdataRefreshBehaviour41027.java
R src-util/modulescript/src/org/openbravo/mobile/core/modulescript/MantainMasterdataRefreshBehaviour41027_Data.xsql
R src-util/modulescript/src/src/org/openbravo/mobile/core/modulescript/MantainMasterdataRefreshBehaviour41027Data.java
---
(0133525)
hgbot   
2021-12-09 07:35   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/310 [^]