Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0048092 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Modules] Reporting | minor | have not tried | 2021-11-17 14:39 | 2022-08-03 22:30 | |||
| Reporter | vmromanos | View Status | public | |||||
| Assigned To | mtaal | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | approved | |||||||
| Regression date | ||||||||
| Regression introduced by commit | ||||||||
| Regression level | ||||||||
| Review Assigned To | ||||||||
| Support ticket | ||||||||
| OBNetwork customer | No | |||||||
| Regression introduced in release | ||||||||
| Summary | 0048092: org.openbravo.reporting.tools module is using bad logging (printStackTrace) | |||||||
| Description | This module is using bad logging (printStackTrace) which should fixed (removing it or converting to proper log4j) | |||||||
| Steps To Reproduce | grep -IrE "System.out|System.err|printStackTrace" | grep -v buildvalidation | grep -v modulescript | grep -v src-test | cut -d'/' -f1-2 | sort | uniq -c | |||||||
| Proposed Solution | Review and move the logging to proper log4j usage. While doing that check if: - stackTrace is really wanted - Logging is really useful (and not developer leftover) | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||||||||||
|
|||||||||||||||||
 Relationships |
|
Notes |
|
|
(0139618) hgbot (developer) 2022-07-26 18:07 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.reporting.tools/-/merge_requests/7 [^] |
|
(0139860) hgbot (developer) 2022-08-03 22:30 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.reporting.tools/-/merge_requests/7 [^] |
|
(0139861) hgbot (developer) 2022-08-03 22:30 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.reporting.tools [^] Changeset: 7ad87c7f7eaec2d4ef62b532ebb231453ec6296f Author: Stefan Huehner <stefan.huehner@openbravo.com> Date: 26-07-2022 18:05:54 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.reporting.tools/-/commit/7ad87c7f7eaec2d4ef62b532ebb231453ec6296f [^] Fixes ISSUE-48092: Convert printStackTrace to log4j Using printStackTrace() is discouraged especially for code running in tomcat (wrong log-files, no timestamp etc). While this file is ant commandline task so not critical best avoid having bad example for others to find/copy. --- M src/org/openbravo/reporting/tools/task/GenerateJasperPropertyFileTask.java --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2021-11-17 14:39 | vmromanos | New Issue | |
| 2021-11-17 14:39 | vmromanos | Assigned To | => Triage Finance |
| 2021-11-17 14:39 | vmromanos | OBNetwork customer | => No |
| 2021-11-17 14:39 | vmromanos | Issue generated from | 0047974 |
| 2021-11-17 14:39 | vmromanos | Relationship added | related to 0047974 |
| 2021-11-17 14:39 | vmromanos | Relationship added | blocks 0036162 |
| 2021-11-17 14:42 | vmromanos | Assigned To | Triage Finance => mtaal |
| 2022-07-26 16:46 | shuehner | Issue cloned | 0049877 |
| 2022-07-26 18:05 | shuehner | Summary | Reporting/WMS: Several modules are using bad logging (System.out,System.err println or printStackTrace) => org.openbravo.reporting.tools module is using bad logging (printStackTrace) |
| 2022-07-26 18:05 | shuehner | Description Updated | View Revisions |
| 2022-07-26 18:05 | shuehner | Steps to Reproduce Updated | View Revisions |
| 2022-07-26 18:07 | hgbot | Merge Request Status | => open |
| 2022-07-26 18:07 | hgbot | Note Added: 0139618 | |
| 2022-08-03 22:30 | hgbot | Merge Request Status | open => approved |
| 2022-08-03 22:30 | hgbot | Note Added: 0139860 | |
| 2022-08-03 22:30 | hgbot | Resolution | open => fixed |
| 2022-08-03 22:30 | hgbot | Status | new => closed |
| 2022-08-03 22:30 | hgbot | Note Added: 0139861 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |