Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0048092ModulesReportingpublic2021-11-17 14:392022-08-03 22:30
Reportervmromanos 
Assigned Tomtaal 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned To
Support ticket
OBNetwork customer
Regression introduced in release
Summary0048092: org.openbravo.reporting.tools module is using bad logging (printStackTrace)
DescriptionThis module is using bad logging (printStackTrace) which should fixed (removing it or converting to proper log4j)
Steps To Reproducegrep -IrE "System.out|System.err|printStackTrace" | grep -v buildvalidation | grep -v modulescript | grep -v src-test | cut -d'/' -f1-2 | sort | uniq -c
Proposed SolutionReview and move the logging to proper log4j usage.

While doing that check if:
- stackTrace is really wanted
- Logging is really useful (and not developer leftover)
Additional Information
TagsNo tags attached.
Relationships
related to defect 0047974 closed francisco_ofarril Modules Several modules from functional/omni team are using bad logging (System.out,System.err println or printStackTrace) 
blocks design defect 0036162 acknowledged Triage Platform Base Openbravo ERP clean up openbravo.log 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-11-17 14:39vmromanosNew Issue
2021-11-17 14:39vmromanosAssigned To => Triage Finance
2021-11-17 14:39vmromanosIssue generated from0047974
2021-11-17 14:39vmromanosRelationship addedrelated to 0047974
2021-11-17 14:39vmromanosRelationship addedblocks 0036162
2021-11-17 14:42vmromanosAssigned ToTriage Finance => mtaal
2022-07-26 16:46shuehnerIssue cloned0049877
2022-07-26 18:05shuehnerSummaryReporting/WMS: Several modules are using bad logging (System.out,System.err println or printStackTrace) => org.openbravo.reporting.tools module is using bad logging (printStackTrace)
2022-07-26 18:05shuehnerDescription Updatedbug_revision_view_page.php?rev_id=24538#r24538
2022-07-26 18:05shuehnerSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=24540#r24540
2022-07-26 18:07hgbotNote Added: 0139618
2022-08-03 22:30hgbotNote Added: 0139860
2022-08-03 22:30hgbotResolutionopen => fixed
2022-08-03 22:30hgbotStatusnew => closed
2022-08-03 22:30hgbotNote Added: 0139861

Notes
(0139618)
hgbot   
2022-07-26 18:07   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.reporting.tools/-/merge_requests/7 [^]
(0139860)
hgbot   
2022-08-03 22:30   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.reporting.tools/-/merge_requests/7 [^]
(0139861)
hgbot   
2022-08-03 22:30   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.reporting.tools [^]
Changeset: 7ad87c7f7eaec2d4ef62b532ebb231453ec6296f
Author: Stefan Huehner <stefan.huehner@openbravo.com>
Date: 26-07-2022 18:05:54
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.reporting.tools/-/commit/7ad87c7f7eaec2d4ef62b532ebb231453ec6296f [^]

Fixes ISSUE-48092: Convert printStackTrace to log4j

Using printStackTrace() is discouraged especially for code running in
tomcat (wrong log-files, no timestamp etc).

While this file is ant commandline task so not critical best avoid
having bad example for others to find/copy.

---
M src/org/openbravo/reporting/tools/task/GenerateJasperPropertyFileTask.java
---