Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0048074
TypeCategorySeverityReproducibilityDate SubmittedLast Update
feature request[Retail Modules] Web POSmajorhave not tried2021-11-16 15:292021-11-23 13:44
Reporterjorge-garciaView Statuspublic 
Assigned Tojorge-garcia 
PrioritynormalResolutionfixedFixed in VersionRR22Q1
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Toaferraz
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0048074: Move some validations from ticket to be executed only in old POS

DescriptionSome ticket validations are required to be only executed in the old POS application:
 - check for extra payments in the ticket: Indicates if the ticket could be paid with less payments than created to avoid to generate unnecessary payments
 - check ticket already paid: Verifies that there is no need to add more payments as the ticket is already paid
   
Steps To Reproduce-
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
related to feature request 0048141 closedjorge-garcia Move overpayment validation from complete ticket to be executed only in old POS 

-  Notes
(0133118)
jorge-garcia (reporter)
2021-11-16 15:36

Created MR

https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/627 [^]
(0133293)
hgbot (developer)
2021-11-23 13:43

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 7b11b8064c4da5b2001f0c187259131b4ff69feb
Author: Jorge Garcia <jorge.garcia@openbravo.com>
Date: 2021-11-23T13:41:30+01:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/7b11b8064c4da5b2001f0c187259131b4ff69feb [^]

Fixed ISSUE-48074: Move some validations from ticket to be executed only in old POS

---
A web/org.openbravo.retail.posterminal/js/actionpreparation/AddPaymentCheck.js
A web/org.openbravo.retail.posterminal/js/actionpreparation/CompleteTicketCheck.js
M src/org/openbravo/retail/posterminal/OBPOSComponentProvider.java
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/actions/AddPayment.js
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/actions/CompleteTicket.js
---
(0133294)
hgbot (developer)
2021-11-23 13:43

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: db4bedc2e0badbd475f53a0cfb5ce2f2e66f812e
Author: Jorge Garcia <jorge.garcia@openbravo.com>
Date: 2021-11-23T13:41:30+01:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/db4bedc2e0badbd475f53a0cfb5ce2f2e66f812e [^]

Related to ISSUE-48074: Define a priority for checks in posterminal

---
M web/org.openbravo.retail.posterminal/js/actionpreparation/AddPaymentCheck.js
M web/org.openbravo.retail.posterminal/js/actionpreparation/CompleteTicketCheck.js
---
(0133295)
hgbot (developer)
2021-11-23 13:43

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: c6251f2869034f07ce2982d7fb3e9c8fd63fb214
Author: Jorge Garcia <jorge.garcia@openbravo.com>
Date: 2021-11-23T13:41:30+01:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/c6251f2869034f07ce2982d7fb3e9c8fd63fb214 [^]

Related to ISSUE-48074: Separate checks for add payment and complete ticket
into individual action preparations

---
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/actions/AddPayment.js
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/actions/CompleteTicket.js
M web/org.openbravo.retail.posterminal/js/actionpreparation/AddPaymentCheck.js
M web/org.openbravo.retail.posterminal/js/actionpreparation/CompleteTicketCheck.js
---
(0133296)
hgbot (developer)
2021-11-23 13:43

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 8b95e82051d85c73e2adc7f5fd375ea837c7fe38
Author: Jorge Garcia <jorge.garcia@openbravo.com>
Date: 2021-11-23T13:41:30+01:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/8b95e82051d85c73e2adc7f5fd375ea837c7fe38 [^]

Related to ISSUE-48074: Solve problems detected during code review

---
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/actions/AddPayment.js
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/actions/CompleteTicket.js
M web/org.openbravo.retail.posterminal/js/actionpreparation/AddPaymentCheck.js
M web/org.openbravo.retail.posterminal/js/actionpreparation/CompleteTicketCheck.js
---

- Issue History
Date Modified Username Field Change
2021-11-16 15:29 jorge-garcia New Issue
2021-11-16 15:29 jorge-garcia Assigned To => Retail
2021-11-16 15:29 jorge-garcia Triggers an Emergency Pack => No
2021-11-16 15:36 jorge-garcia Status new => scheduled
2021-11-16 15:36 jorge-garcia Note Added: 0133118
2021-11-18 14:30 jorge-garcia Review Assigned To => marvintm
2021-11-18 15:55 jorge-garcia Assigned To Retail => jorge-garcia
2021-11-19 13:01 jorge-garcia Review Assigned To marvintm => aferraz
2021-11-23 13:43 hgbot Resolution open => fixed
2021-11-23 13:43 hgbot Status scheduled => resolved
2021-11-23 13:43 hgbot Fixed in Version => RR22Q1
2021-11-23 13:43 hgbot Note Added: 0133293
2021-11-23 13:43 hgbot Note Added: 0133294
2021-11-23 13:43 hgbot Note Added: 0133295
2021-11-23 13:43 hgbot Note Added: 0133296
2021-11-23 13:44 jorge-garcia Status resolved => closed
2021-11-23 14:23 jorge-garcia Relationship added related to 0048141


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker