Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0048074Retail ModulesWeb POSpublic2021-11-16 15:292021-11-23 13:44
Reporterjorge-garcia 
Assigned Tojorge-garcia 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR22Q1 
Merge Request Status
Review Assigned Toaferraz
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0048074: Move some validations from ticket to be executed only in old POS
DescriptionSome ticket validations are required to be only executed in the old POS application:
 - check for extra payments in the ticket: Indicates if the ticket could be paid with less payments than created to avoid to generate unnecessary payments
 - check ticket already paid: Verifies that there is no need to add more payments as the ticket is already paid
   
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0048141 closed jorge-garcia Move overpayment validation from complete ticket to be executed only in old POS 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-11-16 15:29jorge-garciaNew Issue
2021-11-16 15:29jorge-garciaAssigned To => Retail
2021-11-16 15:29jorge-garciaOBNetwork customer => No
2021-11-16 15:29jorge-garciaTriggers an Emergency Pack => No
2021-11-16 15:36jorge-garciaStatusnew => scheduled
2021-11-16 15:36jorge-garciaNote Added: 0133118
2021-11-18 14:30jorge-garciaReview Assigned To => marvintm
2021-11-18 15:55jorge-garciaAssigned ToRetail => jorge-garcia
2021-11-19 13:01jorge-garciaReview Assigned Tomarvintm => aferraz
2021-11-23 13:43hgbotResolutionopen => fixed
2021-11-23 13:43hgbotStatusscheduled => resolved
2021-11-23 13:43hgbotFixed in Version => RR22Q1
2021-11-23 13:43hgbotNote Added: 0133293
2021-11-23 13:43hgbotNote Added: 0133294
2021-11-23 13:43hgbotNote Added: 0133295
2021-11-23 13:43hgbotNote Added: 0133296
2021-11-23 13:44jorge-garciaStatusresolved => closed
2021-11-23 14:23jorge-garciaRelationship addedrelated to 0048141

Notes
(0133118)
jorge-garcia   
2021-11-16 15:36   
Created MR

https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/627 [^]
(0133293)
hgbot   
2021-11-23 13:43   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 7b11b8064c4da5b2001f0c187259131b4ff69feb
Author: Jorge Garcia <jorge.garcia@openbravo.com>
Date: 2021-11-23T13:41:30+01:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/7b11b8064c4da5b2001f0c187259131b4ff69feb [^]

Fixed ISSUE-48074: Move some validations from ticket to be executed only in old POS

---
A web/org.openbravo.retail.posterminal/js/actionpreparation/AddPaymentCheck.js
A web/org.openbravo.retail.posterminal/js/actionpreparation/CompleteTicketCheck.js
M src/org/openbravo/retail/posterminal/OBPOSComponentProvider.java
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/actions/AddPayment.js
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/actions/CompleteTicket.js
---
(0133294)
hgbot   
2021-11-23 13:43   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: db4bedc2e0badbd475f53a0cfb5ce2f2e66f812e
Author: Jorge Garcia <jorge.garcia@openbravo.com>
Date: 2021-11-23T13:41:30+01:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/db4bedc2e0badbd475f53a0cfb5ce2f2e66f812e [^]

Related to ISSUE-48074: Define a priority for checks in posterminal

---
M web/org.openbravo.retail.posterminal/js/actionpreparation/AddPaymentCheck.js
M web/org.openbravo.retail.posterminal/js/actionpreparation/CompleteTicketCheck.js
---
(0133295)
hgbot   
2021-11-23 13:43   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: c6251f2869034f07ce2982d7fb3e9c8fd63fb214
Author: Jorge Garcia <jorge.garcia@openbravo.com>
Date: 2021-11-23T13:41:30+01:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/c6251f2869034f07ce2982d7fb3e9c8fd63fb214 [^]

Related to ISSUE-48074: Separate checks for add payment and complete ticket
into individual action preparations

---
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/actions/AddPayment.js
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/actions/CompleteTicket.js
M web/org.openbravo.retail.posterminal/js/actionpreparation/AddPaymentCheck.js
M web/org.openbravo.retail.posterminal/js/actionpreparation/CompleteTicketCheck.js
---
(0133296)
hgbot   
2021-11-23 13:43   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 8b95e82051d85c73e2adc7f5fd375ea837c7fe38
Author: Jorge Garcia <jorge.garcia@openbravo.com>
Date: 2021-11-23T13:41:30+01:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/8b95e82051d85c73e2adc7f5fd375ea837c7fe38 [^]

Related to ISSUE-48074: Solve problems detected during code review

---
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/actions/AddPayment.js
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/actions/CompleteTicket.js
M web/org.openbravo.retail.posterminal/js/actionpreparation/AddPaymentCheck.js
M web/org.openbravo.retail.posterminal/js/actionpreparation/CompleteTicketCheck.js
---