Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0048049 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Modules] Magento Connector - Mappings | minor | have not tried | 2021-11-11 16:15 | 2022-01-28 04:06 | |||
| Reporter | shuehner | View Status | public | |||||
| Assigned To | AtulOpenbravo | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Regression date | ||||||||
| Regression introduced by commit | ||||||||
| Regression level | ||||||||
| Review Assigned To | ||||||||
| Regression introduced in release | ||||||||
| Summary | 0048049: Apply HQL Style in magento mappings | |||||||
| Description | HQL style should be applied in the module: src/org/openbravo/service/integration/magento/mappings/inbound/orders/O rderImportMapper.java:155: src/org/openbravo/service/integration/magento/mappings/inbound/orders/OrderLineImportMapper.java:161: src/org/openbravo/service/integration/magento/mappings/inbound/orders/OrderLineImportMapper.java:305: src/org/openbravo/service/integration/magento/mappings/utils/MagentoUtils.java:57: | |||||||
| Steps To Reproduce | - | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||
|
|||||||||
 Relationships |
|
Notes |
|
|
(0134146) hgbot (developer) 2022-01-06 20:09 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.service.integration.magento.mappings/-/merge_requests/5 [^] |
|
(0134641) hgbot (developer) 2022-01-28 04:06 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.service.integration.magento.mappings [^] Changeset: 88408f9e41641cf474468c1aeb20d6ce7c6778a0 Author: Atul Gaware <atul.gaware@openbravo.com> Date: 27-01-2022 16:55:40 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.service.integration.magento.mappings/-/commit/88408f9e41641cf474468c1aeb20d6ce7c6778a0 [^] Fixes BUG-0048049: Apply HQL Style in magento mappings **Avoid StringBuffer and use String for hql query string to improve readability using formatter off on as required. **Avoid use of Property Constant in query string. --- M src/org/openbravo/service/integration/magento/mappings/inbound/orders/OrderImportMapper.java M src/org/openbravo/service/integration/magento/mappings/inbound/orders/OrderLineImportMapper.java M src/org/openbravo/service/integration/magento/mappings/utils/MagentoUtils.java --- |
|
(0134642) hgbot (developer) 2022-01-28 04:06 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.service.integration.magento.mappings/-/merge_requests/5 [^] |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2021-11-11 16:15 | shuehner | New Issue | |
| 2021-11-11 16:15 | shuehner | Assigned To | => platform |
| 2021-11-11 16:15 | shuehner | Issue generated from | 0048048 |
| 2021-11-11 16:15 | shuehner | Assigned To | platform => Triage Finance |
| 2021-11-11 16:16 | shuehner | Relationship added | blocks 0041287 |
| 2021-12-29 10:03 | vmromanos | Status | new => scheduled |
| 2021-12-29 10:03 | vmromanos | Assigned To | Triage Finance => AtulOpenbravo |
| 2022-01-06 20:09 | hgbot | Note Added: 0134146 | |
| 2022-01-28 04:06 | hgbot | Resolution | open => fixed |
| 2022-01-28 04:06 | hgbot | Status | scheduled => closed |
| 2022-01-28 04:06 | hgbot | Note Added: 0134641 | |
| 2022-01-28 04:06 | hgbot | Note Added: 0134642 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |