Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0048049ModulesMagento Connector - Mappingspublic2021-11-11 16:152022-01-28 04:06
Reportershuehner 
Assigned ToAtulOpenbravo 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned To
Support ticket
OBNetwork customer
Regression introduced in release
Summary0048049: Apply HQL Style in magento mappings
DescriptionHQL style should be applied in the module:

src/org/openbravo/service/integration/magento/mappings/inbound/orders/O
rderImportMapper.java:155:
src/org/openbravo/service/integration/magento/mappings/inbound/orders/OrderLineImportMapper.java:161:
src/org/openbravo/service/integration/magento/mappings/inbound/orders/OrderLineImportMapper.java:305:
src/org/openbravo/service/integration/magento/mappings/utils/MagentoUtils.java:57:
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks design defect 0041287 acknowledged Triage Platform Base Openbravo ERP Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-11-11 16:15shuehnerNew Issue
2021-11-11 16:15shuehnerAssigned To => platform
2021-11-11 16:15shuehnerIssue generated from0048048
2021-11-11 16:15shuehnerAssigned Toplatform => Triage Finance
2021-11-11 16:16shuehnerRelationship addedblocks 0041287
2021-12-29 10:03vmromanosStatusnew => scheduled
2021-12-29 10:03vmromanosAssigned ToTriage Finance => AtulOpenbravo
2022-01-06 20:09hgbotNote Added: 0134146
2022-01-28 04:06hgbotResolutionopen => fixed
2022-01-28 04:06hgbotStatusscheduled => closed
2022-01-28 04:06hgbotNote Added: 0134641
2022-01-28 04:06hgbotNote Added: 0134642

Notes
(0134146)
hgbot   
2022-01-06 20:09   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.service.integration.magento.mappings/-/merge_requests/5 [^]
(0134641)
hgbot   
2022-01-28 04:06   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.service.integration.magento.mappings [^]
Changeset: 88408f9e41641cf474468c1aeb20d6ce7c6778a0
Author: Atul Gaware <atul.gaware@openbravo.com>
Date: 27-01-2022 16:55:40
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.service.integration.magento.mappings/-/commit/88408f9e41641cf474468c1aeb20d6ce7c6778a0 [^]

Fixes BUG-0048049: Apply HQL Style in magento mappings

**Avoid StringBuffer and use String for hql query string to
improve readability using formatter off on as required.
**Avoid use of Property Constant in query string.

---
M src/org/openbravo/service/integration/magento/mappings/inbound/orders/OrderImportMapper.java
M src/org/openbravo/service/integration/magento/mappings/inbound/orders/OrderLineImportMapper.java
M src/org/openbravo/service/integration/magento/mappings/utils/MagentoUtils.java
---
(0134642)
hgbot   
2022-01-28 04:06   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.service.integration.magento.mappings/-/merge_requests/5 [^]