Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0048041 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
defect | [Modules] Cash VAT Management | minor | have not tried | 2021-11-11 15:56 | 2021-11-17 15:50 | |||
Reporter | shuehner | View Status | public | |||||
Assigned To | shuehner | |||||||
Priority | normal | Resolution | fixed | Fixed in Version | ||||
Status | closed | Fix in branch | Fixed in SCM revision | |||||
Projection | none | ETA | none | Target Version | ||||
OS | Any | Database | Any | Java version | ||||
OS Version | Database version | Ant version | ||||||
Product Version | SCM revision | |||||||
Merge Request Status | approved | |||||||
Regression date | ||||||||
Regression introduced by commit | ||||||||
Regression level | ||||||||
Review Assigned To | ||||||||
Support ticket | ||||||||
OBNetwork customer | No | |||||||
Regression introduced in release | ||||||||
Summary | 0048041: Apply HQL Style in cashvat module | |||||||
Description | HQL style should be applied in the module: src/org/openbravo/module/cashvat/accounting/DocManualSettlementCashVAT.java:130 src/org/openbravo/module/cashvat/accounting/DocManualSettlementCashVAT.java:147 src/org/openbravo/module/cashvat/util/OBCVAT_Utility.java:106 src/org/openbravo/module/cashvat/util/OBCVAT_Utility.java:130 | |||||||
Steps To Reproduce | - | |||||||
Tags | No tags attached. | |||||||
Attached Files | ||||||||
![]() |
|||||||||
|
![]() |
|
(0132985) hgbot (developer) 2021-11-11 16:54 |
Merge Request created: https://gitlab.com/openbravo/product/mods/org.openbravo.module.cashvat/-/merge_requests/1 [^] |
(0133148) hgbot (developer) 2021-11-17 13:52 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/mods/org.openbravo.module.cashvat [^] Changeset: be883434f5eda2d1330591234d55dc7806648068 Author: Stefan Huehner <stefan.huehner@openbravo.com> Date: 2021-11-15T17:44:15+01:00 URL: https://gitlab.com/openbravo/product/mods/org.openbravo.module.cashvat/-/commit/be883434f5eda2d1330591234d55dc7806648068 [^] Fixes ISSUE-48041 Apply HQL Style - Don't use StringBuilder to build HQL text - In OBCVAT_Utility also inline some src-gen constants to improve readability --- M src/org/openbravo/module/cashvat/accounting/DocManualSettlementCashVAT.java M src/org/openbravo/module/cashvat/util/OBCVAT_Utility.java --- |
(0133149) hgbot (developer) 2021-11-17 13:52 |
Merge request merged: https://gitlab.com/openbravo/product/mods/org.openbravo.module.cashvat/-/merge_requests/1 [^] |
![]() |
|||
Date Modified | Username | Field | Change |
2021-11-11 15:56 | shuehner | New Issue | |
2021-11-11 15:56 | shuehner | Assigned To | => Triage Finance |
2021-11-11 15:56 | shuehner | OBNetwork customer | => No |
2021-11-11 15:56 | shuehner | Issue generated from | 0048040 |
2021-11-11 15:57 | shuehner | Relationship added | blocks 0041287 |
2021-11-11 15:59 | shuehner | Issue cloned | 0048042 |
2021-11-11 16:54 | hgbot | Merge Request Status | => open |
2021-11-11 16:54 | hgbot | Note Added: 0132985 | |
2021-11-17 13:51 | hgbot | Merge Request Status | open => approved |
2021-11-17 13:52 | hgbot | Resolution | open => fixed |
2021-11-17 13:52 | hgbot | Status | new => closed |
2021-11-17 13:52 | hgbot | Note Added: 0133148 | |
2021-11-17 13:52 | hgbot | Note Added: 0133149 | |
2021-11-17 15:50 | shuehner | Assigned To | Triage Finance => shuehner |
Copyright © 2000 - 2009 MantisBT Group |