Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0048041
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Modules] Cash VAT Managementminorhave not tried2021-11-11 15:562021-11-17 15:50
ReportershuehnerView Statuspublic 
Assigned Toshuehner 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Regression date
Regression introduced by commit
Regression level
Review Assigned To
Regression introduced in release
Summary

0048041: Apply HQL Style in cashvat module

DescriptionHQL style should be applied in the module:

src/org/openbravo/module/cashvat/accounting/DocManualSettlementCashVAT.java:130
src/org/openbravo/module/cashvat/accounting/DocManualSettlementCashVAT.java:147
src/org/openbravo/module/cashvat/util/OBCVAT_Utility.java:106
src/org/openbravo/module/cashvat/util/OBCVAT_Utility.java:130
Steps To Reproduce-
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
blocks design defect 0041287 acknowledgedTriage Platform Base Openbravo ERP Tracking issue: Convert HQL to apply new style 

-  Notes
(0132985)
hgbot (developer)
2021-11-11 16:54

Merge Request created: https://gitlab.com/openbravo/product/mods/org.openbravo.module.cashvat/-/merge_requests/1 [^]
(0133148)
hgbot (developer)
2021-11-17 13:52

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/mods/org.openbravo.module.cashvat [^]
Changeset: be883434f5eda2d1330591234d55dc7806648068
Author: Stefan Huehner <stefan.huehner@openbravo.com>
Date: 2021-11-15T17:44:15+01:00
URL: https://gitlab.com/openbravo/product/mods/org.openbravo.module.cashvat/-/commit/be883434f5eda2d1330591234d55dc7806648068 [^]

Fixes ISSUE-48041 Apply HQL Style

- Don't use StringBuilder to build HQL text
- In OBCVAT_Utility also inline some src-gen constants to improve
  readability

---
M src/org/openbravo/module/cashvat/accounting/DocManualSettlementCashVAT.java
M src/org/openbravo/module/cashvat/util/OBCVAT_Utility.java
---
(0133149)
hgbot (developer)
2021-11-17 13:52

Merge request merged: https://gitlab.com/openbravo/product/mods/org.openbravo.module.cashvat/-/merge_requests/1 [^]

- Issue History
Date Modified Username Field Change
2021-11-11 15:56 shuehner New Issue
2021-11-11 15:56 shuehner Assigned To => Triage Finance
2021-11-11 15:56 shuehner Issue generated from 0048040
2021-11-11 15:57 shuehner Relationship added blocks 0041287
2021-11-11 15:59 shuehner Issue cloned 0048042
2021-11-11 16:54 hgbot Note Added: 0132985
2021-11-17 13:52 hgbot Resolution open => fixed
2021-11-17 13:52 hgbot Status new => closed
2021-11-17 13:52 hgbot Note Added: 0133148
2021-11-17 13:52 hgbot Note Added: 0133149
2021-11-17 15:50 shuehner Assigned To Triage Finance => shuehner


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker