Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0048041ModulesCash VAT Managementpublic2021-11-11 15:562021-11-17 15:50
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Statusapproved
Regression date
Regression introduced by commit
Regression level
Review Assigned To
Support ticket
OBNetwork customerNo
Regression introduced in release
Summary0048041: Apply HQL Style in cashvat module
DescriptionHQL style should be applied in the module:

src/org/openbravo/module/cashvat/accounting/DocManualSettlementCashVAT.java:130
src/org/openbravo/module/cashvat/accounting/DocManualSettlementCashVAT.java:147
src/org/openbravo/module/cashvat/util/OBCVAT_Utility.java:106
src/org/openbravo/module/cashvat/util/OBCVAT_Utility.java:130
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks design defect 0041287 acknowledged Triage Platform Base Openbravo ERP Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-11-11 15:56shuehnerNew Issue
2021-11-11 15:56shuehnerAssigned To => Triage Finance
2021-11-11 15:56shuehnerOBNetwork customer => No
2021-11-11 15:56shuehnerIssue generated from0048040
2021-11-11 15:57shuehnerRelationship addedblocks 0041287
2021-11-11 15:59shuehnerIssue cloned0048042
2021-11-11 16:54hgbotMerge Request Status => open
2021-11-11 16:54hgbotNote Added: 0132985
2021-11-17 13:51hgbotMerge Request Statusopen => approved
2021-11-17 13:52hgbotResolutionopen => fixed
2021-11-17 13:52hgbotStatusnew => closed
2021-11-17 13:52hgbotNote Added: 0133148
2021-11-17 13:52hgbotNote Added: 0133149
2021-11-17 15:50shuehnerAssigned ToTriage Finance => shuehner

Notes
(0132985)
hgbot   
2021-11-11 16:54   
Merge Request created: https://gitlab.com/openbravo/product/mods/org.openbravo.module.cashvat/-/merge_requests/1 [^]
(0133148)
hgbot   
2021-11-17 13:52   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/mods/org.openbravo.module.cashvat [^]
Changeset: be883434f5eda2d1330591234d55dc7806648068
Author: Stefan Huehner <stefan.huehner@openbravo.com>
Date: 2021-11-15T17:44:15+01:00
URL: https://gitlab.com/openbravo/product/mods/org.openbravo.module.cashvat/-/commit/be883434f5eda2d1330591234d55dc7806648068 [^]

Fixes ISSUE-48041 Apply HQL Style

- Don't use StringBuilder to build HQL text
- In OBCVAT_Utility also inline some src-gen constants to improve
  readability

---
M src/org/openbravo/module/cashvat/accounting/DocManualSettlementCashVAT.java
M src/org/openbravo/module/cashvat/util/OBCVAT_Utility.java
---
(0133149)
hgbot   
2021-11-17 13:52   
Merge request merged: https://gitlab.com/openbravo/product/mods/org.openbravo.module.cashvat/-/merge_requests/1 [^]