Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0048040 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Modules] Loyalty Programs | minor | have not tried | 2021-11-11 15:53 | 2021-11-18 15:49 | |||
| Reporter | shuehner | View Status | public | |||||
| Assigned To | shuehner | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Regression date | ||||||||
| Regression introduced by commit | ||||||||
| Regression level | ||||||||
| Review Assigned To | ||||||||
| Regression introduced in release | ||||||||
| Summary | 0048040: Apply HQL Style in loyalty programs | |||||||
| Description | HQL style should be applied in the module: src/org/openbravo/loyalty/programs/eventhandler/CategoryEventHandler.java:66 src/org/openbravo/loyalty/programs/eventhandler/StatusEventHandler.java:66 src/org/openbravo/loyalty/programs/eventhandler/SubscriptionCategoryPromotionRuleEventHandler.java:105 src/org/openbravo/loyalty/programs/eventhandler/SubscriptionCategoryPromotionRuleEventHandler.java:87 src/org/openbravo/loyalty/programs/eventhandler/SubscriptionEventHandler.java:117 (extra toString()) src/org/openbravo/loyalty/programs/process/GenerateBurnRun.java:77 src/org/openbravo/loyalty/programs/process/ManualBurn.java:114 src/org/openbravo/loyalty/programs/process/SubscriptionPromoteCategoryEARNRuleHandler.java:99 src/org/openbravo/loyalty/programs/process/SubscriptionWelcomePointsEARNRuleHandler.java:93 src/org/openbravo/loyalty/programs/utils/BurnRunUtils.java:177 src/org/openbravo/loyalty/programs/utils/BurnRunUtils.java:197 src/org/openbravo/loyalty/programs/utils/CopyBurnRunConfigurationUtils.java:51 | |||||||
| Steps To Reproduce | - | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||
|
|||||||||
 Relationships |
|
Notes |
|
|
(0132997) hgbot (developer) 2021-11-12 12:42 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.loyalty.programs/-/merge_requests/4 [^] |
|
(0133180) hgbot (developer) 2021-11-18 15:48 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.loyalty.programs [^] Changeset: 3cbfeb9f4b2f0198c14b424fef9649e6cc00ab0f Author: Stefan Huehner <stefan.huehner@openbravo.com> Date: 2021-11-16T15:38:38+01:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.loyalty.programs/-/commit/3cbfeb9f4b2f0198c14b424fef9649e6cc00ab0f [^] Fixes ISSUE-48040 Apply HQL Style Don't use StringBuilder to build query text --- M src/org/openbravo/loyalty/programs/eventhandler/CategoryEventHandler.java M src/org/openbravo/loyalty/programs/eventhandler/StatusEventHandler.java M src/org/openbravo/loyalty/programs/eventhandler/SubscriptionCategoryPromotionRuleEventHandler.java M src/org/openbravo/loyalty/programs/eventhandler/SubscriptionEventHandler.java M src/org/openbravo/loyalty/programs/process/GenerateBurnRun.java M src/org/openbravo/loyalty/programs/process/ManualBurn.java M src/org/openbravo/loyalty/programs/process/SubscriptionPromoteCategoryEARNRuleHandler.java M src/org/openbravo/loyalty/programs/process/SubscriptionWelcomePointsEARNRuleHandler.java M src/org/openbravo/loyalty/programs/utils/BurnRunUtils.java M src/org/openbravo/loyalty/programs/utils/CopyBurnRunConfigurationUtils.java --- |
|
(0133181) hgbot (developer) 2021-11-18 15:48 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.loyalty.programs/-/merge_requests/4 [^] |
|
(0133182) shuehner (administrator) 2021-11-18 15:49 |
That reformat commit was also applied here before above commit (typo in issue number) Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.loyalty.programs [^] [^] Changeset: 02d44a55271afb730ed85ebe284bbde14e841810 Author: Stefan Huehner <stefan.huehner@openbravo.com> Date: 2021-11-12T12:28:41+01:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.loyalty.programs/-/commit/02d44a55271afb730ed85ebe284bbde14e841810 [^] [^] Related to ISSUE-48080 Reformat file Just save with new eclipse standard formatting --- M src/org/openbravo/loyalty/programs/eventhandler/SubscriptionCategoryPromotionRuleEventHandler.java |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2021-11-11 15:53 | shuehner | New Issue | |
| 2021-11-11 15:53 | shuehner | Assigned To | => Triage Finance |
| 2021-11-11 15:53 | shuehner | Relationship added | blocks 0041287 |
| 2021-11-11 15:56 | shuehner | Issue cloned | 0048041 |
| 2021-11-11 16:07 | vmromanos | Assigned To | Triage Finance => Retail |
| 2021-11-12 12:42 | hgbot | Note Added: 0132997 | |
| 2021-11-18 15:45 | shuehner | Assigned To | Retail => shuehner |
| 2021-11-18 15:48 | hgbot | Resolution | open => fixed |
| 2021-11-18 15:48 | hgbot | Status | new => closed |
| 2021-11-18 15:48 | hgbot | Note Added: 0133180 | |
| 2021-11-18 15:48 | hgbot | Note Added: 0133181 | |
| 2021-11-18 15:49 | shuehner | Note Added: 0133182 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |