Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0048040ModulesLoyalty Programspublic2021-11-11 15:532021-11-18 15:49
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Statusapproved
Regression date
Regression introduced by commit
Regression level
Review Assigned To
Support ticket
OBNetwork customerNo
Regression introduced in release
Summary0048040: Apply HQL Style in loyalty programs
DescriptionHQL style should be applied in the module:

src/org/openbravo/loyalty/programs/eventhandler/CategoryEventHandler.java:66
src/org/openbravo/loyalty/programs/eventhandler/StatusEventHandler.java:66
src/org/openbravo/loyalty/programs/eventhandler/SubscriptionCategoryPromotionRuleEventHandler.java:105
src/org/openbravo/loyalty/programs/eventhandler/SubscriptionCategoryPromotionRuleEventHandler.java:87
src/org/openbravo/loyalty/programs/eventhandler/SubscriptionEventHandler.java:117 (extra toString())
src/org/openbravo/loyalty/programs/process/GenerateBurnRun.java:77
src/org/openbravo/loyalty/programs/process/ManualBurn.java:114
src/org/openbravo/loyalty/programs/process/SubscriptionPromoteCategoryEARNRuleHandler.java:99
src/org/openbravo/loyalty/programs/process/SubscriptionWelcomePointsEARNRuleHandler.java:93
src/org/openbravo/loyalty/programs/utils/BurnRunUtils.java:177
src/org/openbravo/loyalty/programs/utils/BurnRunUtils.java:197
src/org/openbravo/loyalty/programs/utils/CopyBurnRunConfigurationUtils.java:51
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks design defect 0041287 acknowledged Triage Platform Base Openbravo ERP Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-11-11 15:53shuehnerNew Issue
2021-11-11 15:53shuehnerAssigned To => Triage Finance
2021-11-11 15:53shuehnerOBNetwork customer => No
2021-11-11 15:53shuehnerRelationship addedblocks 0041287
2021-11-11 15:56shuehnerIssue cloned0048041
2021-11-11 16:07vmromanosAssigned ToTriage Finance => Retail
2021-11-12 12:42hgbotMerge Request Status => open
2021-11-12 12:42hgbotNote Added: 0132997
2021-11-16 07:54hgbotMerge Request Statusopen => approved
2021-11-18 15:45shuehnerAssigned ToRetail => shuehner
2021-11-18 15:48hgbotResolutionopen => fixed
2021-11-18 15:48hgbotStatusnew => closed
2021-11-18 15:48hgbotNote Added: 0133180
2021-11-18 15:48hgbotNote Added: 0133181
2021-11-18 15:49shuehnerNote Added: 0133182

Notes
(0132997)
hgbot   
2021-11-12 12:42   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.loyalty.programs/-/merge_requests/4 [^]
(0133180)
hgbot   
2021-11-18 15:48   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.loyalty.programs [^]
Changeset: 3cbfeb9f4b2f0198c14b424fef9649e6cc00ab0f
Author: Stefan Huehner <stefan.huehner@openbravo.com>
Date: 2021-11-16T15:38:38+01:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.loyalty.programs/-/commit/3cbfeb9f4b2f0198c14b424fef9649e6cc00ab0f [^]

Fixes ISSUE-48040 Apply HQL Style

Don't use StringBuilder to build query text

---
M src/org/openbravo/loyalty/programs/eventhandler/CategoryEventHandler.java
M src/org/openbravo/loyalty/programs/eventhandler/StatusEventHandler.java
M src/org/openbravo/loyalty/programs/eventhandler/SubscriptionCategoryPromotionRuleEventHandler.java
M src/org/openbravo/loyalty/programs/eventhandler/SubscriptionEventHandler.java
M src/org/openbravo/loyalty/programs/process/GenerateBurnRun.java
M src/org/openbravo/loyalty/programs/process/ManualBurn.java
M src/org/openbravo/loyalty/programs/process/SubscriptionPromoteCategoryEARNRuleHandler.java
M src/org/openbravo/loyalty/programs/process/SubscriptionWelcomePointsEARNRuleHandler.java
M src/org/openbravo/loyalty/programs/utils/BurnRunUtils.java
M src/org/openbravo/loyalty/programs/utils/CopyBurnRunConfigurationUtils.java
---
(0133181)
hgbot   
2021-11-18 15:48   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.loyalty.programs/-/merge_requests/4 [^]
(0133182)
shuehner   
2021-11-18 15:49   
That reformat commit was also applied here before above commit (typo in issue number)

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.loyalty.programs [^] [^]
Changeset: 02d44a55271afb730ed85ebe284bbde14e841810
Author: Stefan Huehner <stefan.huehner@openbravo.com>
Date: 2021-11-12T12:28:41+01:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.loyalty.programs/-/commit/02d44a55271afb730ed85ebe284bbde14e841810 [^] [^]

Related to ISSUE-48080 Reformat file

Just save with new eclipse standard formatting

---
M src/org/openbravo/loyalty/programs/eventhandler/SubscriptionCategoryPromotionRuleEventHandler.java