Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0047999 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
defect | [Retail Modules] Send By Email | minor | have not tried | 2021-11-06 10:53 | 2021-11-11 07:59 | |||
Reporter | shuehner | View Status | public | |||||
Assigned To | shuehner | |||||||
Priority | normal | Resolution | fixed | Fixed in Version | ||||
Status | closed | Fix in branch | Fixed in SCM revision | |||||
Projection | none | ETA | none | Target Version | ||||
OS | Any | Database | Any | Java version | ||||
OS Version | Database version | Ant version | ||||||
Product Version | SCM revision | |||||||
Review Assigned To | ||||||||
Regression level | ||||||||
Regression date | ||||||||
Regression introduced in release | ||||||||
Regression introduced by commit | ||||||||
Triggers an Emergency Pack | No | |||||||
Summary | 0047999: Remove obsolete storeserver related code from sendemail module | |||||||
Description | This module still retains some code related to the obsolete storeserver project. Specifically a condition to not process an entry if running on a storeserver. That can be simplified to just always process it now. | |||||||
Steps To Reproduce | - if (!serverController.isThisAStoreServer()) { - super.processEntry(importEntry); - } | |||||||
Tags | No tags attached. | |||||||
Attached Files | ||||||||
Relationships [ Relation Graph ] [ Dependency Graph ] | ||||||||
|
Notes | |
(0132878) hgbot (developer) 2021-11-06 11:07 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sendemail/-/merge_requests/7 [^] |
(0132952) hgbot (developer) 2021-11-11 07:59 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sendemail [^] Changeset: 1bed2a18f601084147f3c10cd815fc30e5fdd944 Author: Stefan Huehner <stefan.huehner@openbravo.com> Date: 2021-11-06T11:05:40+01:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sendemail/-/commit/1bed2a18f601084147f3c10cd815fc30e5fdd944 [^] Fixes ISSUE-47999 Remove obsolete storeserver code processEntry method was overloaded to only process entries is the server was NOT a storeserver. As not everything is NOT a storeserver that check can be removed. As then nothing is left in processEntry besides super.processEntry call remote the overloaded method entirely. --- M src/org/openbravo/retail/sendemail/sync/OBSMAIL_ImportEntryProcessor.java --- |
(0132953) hgbot (developer) 2021-11-11 07:59 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sendemail/-/merge_requests/7 [^] |
Issue History | |||
Date Modified | Username | Field | Change |
2021-11-06 10:53 | shuehner | New Issue | |
2021-11-06 10:53 | shuehner | Assigned To | => shuehner |
2021-11-06 10:53 | shuehner | Triggers an Emergency Pack | => No |
2021-11-06 10:53 | shuehner | Issue generated from | 0047998 |
2021-11-06 11:07 | hgbot | Note Added: 0132878 | |
2021-11-06 11:34 | shuehner | Relationship added | blocks 0048000 |
2021-11-06 12:31 | shuehner | Issue cloned | 0048001 |
2021-11-10 09:41 | shuehner | Description Updated | View Revisions |
2021-11-10 09:41 | shuehner | Steps to Reproduce Updated | View Revisions |
2021-11-10 09:41 | shuehner | Status | new => scheduled |
2021-11-11 07:59 | hgbot | Resolution | open => fixed |
2021-11-11 07:59 | hgbot | Status | scheduled => closed |
2021-11-11 07:59 | hgbot | Note Added: 0132952 | |
2021-11-11 07:59 | hgbot | Note Added: 0132953 |
Copyright © 2000 - 2009 MantisBT Group |