Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0047999Retail ModulesSend By Emailpublic2021-11-06 10:532021-11-11 07:59
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0047999: Remove obsolete storeserver related code from sendemail module
DescriptionThis module still retains some code related to the obsolete storeserver project.

Specifically a condition to not process an entry if running on a storeserver.
That can be simplified to just always process it now.
Steps To Reproduce- if (!serverController.isThisAStoreServer()) {
- super.processEntry(importEntry);
- }
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0048000 closed shuehner Remove obsolete storeserver related code from mobile.core 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-11-06 10:53shuehnerNew Issue
2021-11-06 10:53shuehnerAssigned To => shuehner
2021-11-06 10:53shuehnerOBNetwork customer => No
2021-11-06 10:53shuehnerTriggers an Emergency Pack => No
2021-11-06 10:53shuehnerIssue generated from0047998
2021-11-06 11:07hgbotMerge Request Status => open
2021-11-06 11:07hgbotNote Added: 0132878
2021-11-06 11:34shuehnerRelationship addedblocks 0048000
2021-11-06 12:31shuehnerIssue cloned0048001
2021-11-10 09:41shuehnerDescription Updatedbug_revision_view_page.php?rev_id=23298#r23298
2021-11-10 09:41shuehnerSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=23300#r23300
2021-11-10 09:41shuehnerStatusnew => scheduled
2021-11-11 07:59hgbotMerge Request Statusopen => approved
2021-11-11 07:59hgbotResolutionopen => fixed
2021-11-11 07:59hgbotStatusscheduled => closed
2021-11-11 07:59hgbotNote Added: 0132952
2021-11-11 07:59hgbotNote Added: 0132953

Notes
(0132878)
hgbot   
2021-11-06 11:07   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sendemail/-/merge_requests/7 [^]
(0132952)
hgbot   
2021-11-11 07:59   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sendemail [^]
Changeset: 1bed2a18f601084147f3c10cd815fc30e5fdd944
Author: Stefan Huehner <stefan.huehner@openbravo.com>
Date: 2021-11-06T11:05:40+01:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sendemail/-/commit/1bed2a18f601084147f3c10cd815fc30e5fdd944 [^]

Fixes ISSUE-47999 Remove obsolete storeserver code

processEntry method was overloaded to only process entries is the server
was NOT a storeserver.
As not everything is NOT a storeserver that check can be removed.
As then nothing is left in processEntry besides super.processEntry call
remote the overloaded method entirely.

---
M src/org/openbravo/retail/sendemail/sync/OBSMAIL_ImportEntryProcessor.java
---
(0132953)
hgbot   
2021-11-11 07:59   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sendemail/-/merge_requests/7 [^]