Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0047998 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Retail Modules] Order Preparation | minor | have not tried | 2021-11-06 10:41 | 2021-11-16 14:17 | |||
| Reporter | shuehner | View Status | public | |||||
| Assigned To | shuehner | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | approved | |||||||
| Review Assigned To | marvintm | |||||||
| OBNetwork customer | No | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0047998: Remove obsolete storeserver related code (use of MultiServerRequestExecutor) from orderpreparation | |||||||
| Description | This module still retains some code related to the obsolete storeserver project which is long obsolete. | |||||||
| Steps To Reproduce | grep -Iir storeserver | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0132875) hgbot (developer) 2021-11-06 10:48 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.orderpreparation/-/merge_requests/8 [^] |
|
(0132876) hgbot (developer) 2021-11-06 10:57 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sendemail/-/merge_requests/6 [^] |
|
(0132877) hgbot (developer) 2021-11-06 11:05 |
Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sendemail/-/merge_requests/6 [^] |
|
(0133113) hgbot (developer) 2021-11-16 14:15 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.orderpreparation/-/merge_requests/8 [^] |
|
(0133114) shuehner (administrator) 2021-11-16 14:17 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.orderpreparation [^] [^] Changeset: eac957358423bbb851a085d7cce43b9ad182f7fc Author: Stefan Huehner <stefan.huehner@openbravo.com> Date: 2021-11-06T10:43:21+01:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.orderpreparation/-/commit/eac957358423bbb851a085d7cce43b9ad182f7fc [^] [^] Fixes ISSUE-47988: Remove obsolete storeserver related code. - PendingOrderLines had special code for isThisAStoreServer() - That cannot be true anymore with storeserver being obsolete. So it is removed here. - With that the whole overloaded exec method has no special code apart from calling super.exec() so remove it entirely - ProcessedOrder also had special code for isThisAStoreServer() Remove it as that condition cannot be true anymore. --- M src/org/openbravo/retail/orderpreparation/master/PendingOrderLines.java M src/org/openbravo/retail/orderpreparation/master/ProcessedOrder.java |
|
(0133115) shuehner (administrator) 2021-11-16 14:17 |
Marking resolved manually (typo in commit message) |
|
(0133116) shuehner (administrator) 2021-11-16 14:17 |
Marking as closed manually (had approved MR). Automation didn't work (typo in commit message) |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2021-11-06 10:41 | shuehner | New Issue | |
| 2021-11-06 10:41 | shuehner | Assigned To | => shuehner |
| 2021-11-06 10:41 | shuehner | OBNetwork customer | => No |
| 2021-11-06 10:41 | shuehner | Triggers an Emergency Pack | => No |
| 2021-11-06 10:41 | shuehner | Issue generated from | 0047989 |
| 2021-11-06 10:48 | hgbot | Merge Request Status | => open |
| 2021-11-06 10:48 | hgbot | Note Added: 0132875 | |
| 2021-11-06 10:53 | shuehner | Issue cloned | 0047999 |
| 2021-11-06 10:57 | hgbot | Note Added: 0132876 | |
| 2021-11-06 11:05 | hgbot | Note Added: 0132877 | |
| 2021-11-06 11:34 | shuehner | Relationship added | blocks 0048000 |
| 2021-11-10 09:37 | shuehner | Summary | Remove obsolete storeserver related code from orderpreparation module => Remove obsolete storeserver related code (use of MultiServerRequestExecutor) from orderpreparation |
| 2021-11-10 09:37 | shuehner | Description Updated | View Revisions |
| 2021-11-10 09:39 | shuehner | Status | new => scheduled |
| 2021-11-11 07:58 | hgbot | Merge Request Status | open => approved |
| 2021-11-16 14:15 | hgbot | Note Added: 0133113 | |
| 2021-11-16 14:17 | shuehner | Note Added: 0133114 | |
| 2021-11-16 14:17 | shuehner | Note Added: 0133115 | |
| 2021-11-16 14:17 | shuehner | Status | scheduled => resolved |
| 2021-11-16 14:17 | shuehner | Resolution | open => fixed |
| 2021-11-16 14:17 | shuehner | Review Assigned To | => marvintm |
| 2021-11-16 14:17 | shuehner | Note Added: 0133116 | |
| 2021-11-16 14:17 | shuehner | Status | resolved => closed |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |