Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0047998Retail ModulesOrder Preparationpublic2021-11-06 10:412021-11-16 14:17
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Statusapproved
Review Assigned Tomarvintm
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0047998: Remove obsolete storeserver related code (use of MultiServerRequestExecutor) from orderpreparation
DescriptionThis module still retains some code related to the obsolete storeserver project which is long obsolete.


Steps To Reproducegrep -Iir storeserver
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0048000 closed shuehner Remove obsolete storeserver related code from mobile.core 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-11-06 10:41shuehnerNew Issue
2021-11-06 10:41shuehnerAssigned To => shuehner
2021-11-06 10:41shuehnerOBNetwork customer => No
2021-11-06 10:41shuehnerTriggers an Emergency Pack => No
2021-11-06 10:41shuehnerIssue generated from0047989
2021-11-06 10:48hgbotMerge Request Status => open
2021-11-06 10:48hgbotNote Added: 0132875
2021-11-06 10:53shuehnerIssue cloned0047999
2021-11-06 10:57hgbotNote Added: 0132876
2021-11-06 11:05hgbotNote Added: 0132877
2021-11-06 11:34shuehnerRelationship addedblocks 0048000
2021-11-10 09:37shuehnerSummaryRemove obsolete storeserver related code from orderpreparation module => Remove obsolete storeserver related code (use of MultiServerRequestExecutor) from orderpreparation
2021-11-10 09:37shuehnerDescription Updatedbug_revision_view_page.php?rev_id=23296#r23296
2021-11-10 09:39shuehnerStatusnew => scheduled
2021-11-11 07:58hgbotMerge Request Statusopen => approved
2021-11-16 14:15hgbotNote Added: 0133113
2021-11-16 14:17shuehnerNote Added: 0133114
2021-11-16 14:17shuehnerNote Added: 0133115
2021-11-16 14:17shuehnerStatusscheduled => resolved
2021-11-16 14:17shuehnerResolutionopen => fixed
2021-11-16 14:17shuehnerReview Assigned To => marvintm
2021-11-16 14:17shuehnerNote Added: 0133116
2021-11-16 14:17shuehnerStatusresolved => closed

Notes
(0132875)
hgbot   
2021-11-06 10:48   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.orderpreparation/-/merge_requests/8 [^]
(0132876)
hgbot   
2021-11-06 10:57   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sendemail/-/merge_requests/6 [^]
(0132877)
hgbot   
2021-11-06 11:05   
Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sendemail/-/merge_requests/6 [^]
(0133113)
hgbot   
2021-11-16 14:15   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.orderpreparation/-/merge_requests/8 [^]
(0133114)
shuehner   
2021-11-16 14:17   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.orderpreparation [^] [^]
Changeset: eac957358423bbb851a085d7cce43b9ad182f7fc
Author: Stefan Huehner <stefan.huehner@openbravo.com>
Date: 2021-11-06T10:43:21+01:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.orderpreparation/-/commit/eac957358423bbb851a085d7cce43b9ad182f7fc [^] [^]

Fixes ISSUE-47988: Remove obsolete storeserver related code.

- PendingOrderLines had special code for isThisAStoreServer()
  - That cannot be true anymore with storeserver being obsolete.
    So it is removed here.
  - With that the whole overloaded exec method has no special code apart
    from calling super.exec() so remove it entirely
- ProcessedOrder also had special code for isThisAStoreServer()
  Remove it as that condition cannot be true anymore.

---
M src/org/openbravo/retail/orderpreparation/master/PendingOrderLines.java
M src/org/openbravo/retail/orderpreparation/master/ProcessedOrder.java
(0133115)
shuehner   
2021-11-16 14:17   
Marking resolved manually (typo in commit message)
(0133116)
shuehner   
2021-11-16 14:17   
Marking as closed manually (had approved MR). Automation didn't work (typo in commit message)