Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0047964 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Retail Modules] Discounts and Promotions | minor | have not tried | 2021-11-03 13:29 | 2021-11-04 08:16 | |||
| Reporter | shuehner | View Status | public | |||||
| Assigned To | shuehner | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | RR22Q1 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | marvintm | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0047964: org.openbravo.retail.discounts.AddPack should not use System.out.println | |||||||
| Description | That file is using bad logging and should be moved to log4j instead. | |||||||
| Steps To Reproduce | https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/blob/master/src/org/openbravo/retail/discounts/AddPack.java#L113 [^] | |||||||
| Proposed Solution | move it to log4j.debug (as just debugging output anyway) | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||
|
|||||||||
 Relationships |
|
Notes |
|
|
(0132812) hgbot (developer) 2021-11-03 13:35 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/40 [^] |
|
(0132822) hgbot (developer) 2021-11-04 08:15 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts [^] Changeset: 7678200bb6dcc0f77593935769c3ebf919c8e71e Author: Stefan Huehner <stefan.huehner@openbravo.com> Date: 2021-11-03T13:37:38+01:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/7678200bb6dcc0f77593935769c3ebf919c8e71e [^] Fix ISSUE-47964: Avoid System.out.println by using log4j instead Some debugging output was using System.out.println which is bad logging (goes to catalina.out, does not have any context). Move it over to log4j api with debug level. --- M src/org/openbravo/retail/discounts/AddPack.java --- |
|
(0132823) hgbot (developer) 2021-11-04 08:15 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/40 [^] |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2021-11-03 13:29 | shuehner | New Issue | |
| 2021-11-03 13:29 | shuehner | Assigned To | => Retail |
| 2021-11-03 13:29 | shuehner | Triggers an Emergency Pack | => No |
| 2021-11-03 13:29 | shuehner | Relationship added | blocks 0036162 |
| 2021-11-03 13:30 | shuehner | Proposed Solution updated | |
| 2021-11-03 13:35 | hgbot | Note Added: 0132812 | |
| 2021-11-03 14:21 | shuehner | Issue cloned | 0047967 |
| 2021-11-04 08:15 | hgbot | Note Added: 0132822 | |
| 2021-11-04 08:15 | hgbot | Note Added: 0132823 | |
| 2021-11-04 08:16 | marvintm | Status | new => scheduled |
| 2021-11-04 08:16 | marvintm | Assigned To | Retail => shuehner |
| 2021-11-04 08:16 | marvintm | Status | scheduled => resolved |
| 2021-11-04 08:16 | marvintm | Fixed in Version | => RR22Q1 |
| 2021-11-04 08:16 | marvintm | Resolution | open => fixed |
| 2021-11-04 08:16 | marvintm | Review Assigned To | => marvintm |
| 2021-11-04 08:16 | marvintm | Status | resolved => closed |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |