Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0047964
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Discounts and Promotionsminorhave not tried2021-11-03 13:292021-11-04 08:16
ReportershuehnerView Statuspublic 
Assigned Toshuehner 
PrioritynormalResolutionfixedFixed in VersionRR22Q1
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Statusapproved
Review Assigned Tomarvintm
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0047964: org.openbravo.retail.discounts.AddPack should not use System.out.println

DescriptionThat file is using bad logging and should be moved to log4j instead.
Steps To Reproducehttps://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/blob/master/src/org/openbravo/retail/discounts/AddPack.java#L113 [^]
Proposed Solutionmove it to log4j.debug (as just debugging output anyway)
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
blocks design defect 0036162 acknowledgedTriage Platform Base Openbravo ERP clean up openbravo.log 

-  Notes
(0132812)
hgbot (developer)
2021-11-03 13:35

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/40 [^]
(0132822)
hgbot (developer)
2021-11-04 08:15

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts [^]
Changeset: 7678200bb6dcc0f77593935769c3ebf919c8e71e
Author: Stefan Huehner <stefan.huehner@openbravo.com>
Date: 2021-11-03T13:37:38+01:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/7678200bb6dcc0f77593935769c3ebf919c8e71e [^]

Fix ISSUE-47964: Avoid System.out.println by using log4j instead

Some debugging output was using System.out.println which is bad logging
(goes to catalina.out, does not have any context).
Move it over to log4j api with debug level.

---
M src/org/openbravo/retail/discounts/AddPack.java
---
(0132823)
hgbot (developer)
2021-11-04 08:15

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/40 [^]

- Issue History
Date Modified Username Field Change
2021-11-03 13:29 shuehner New Issue
2021-11-03 13:29 shuehner Assigned To => Retail
2021-11-03 13:29 shuehner OBNetwork customer => No
2021-11-03 13:29 shuehner Triggers an Emergency Pack => No
2021-11-03 13:29 shuehner Relationship added blocks 0036162
2021-11-03 13:30 shuehner Proposed Solution updated
2021-11-03 13:35 hgbot Merge Request Status => open
2021-11-03 13:35 hgbot Note Added: 0132812
2021-11-03 14:21 shuehner Issue cloned 0047967
2021-11-04 08:15 hgbot Merge Request Status open => approved
2021-11-04 08:15 hgbot Note Added: 0132822
2021-11-04 08:15 hgbot Note Added: 0132823
2021-11-04 08:16 marvintm Status new => scheduled
2021-11-04 08:16 marvintm Assigned To Retail => shuehner
2021-11-04 08:16 marvintm Status scheduled => resolved
2021-11-04 08:16 marvintm Fixed in Version => RR22Q1
2021-11-04 08:16 marvintm Resolution open => fixed
2021-11-04 08:16 marvintm Review Assigned To => marvintm
2021-11-04 08:16 marvintm Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker