Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0047964Retail ModulesDiscounts and Promotionspublic2021-11-03 13:292021-11-04 08:16
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR22Q1 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0047964: org.openbravo.retail.discounts.AddPack should not use System.out.println
DescriptionThat file is using bad logging and should be moved to log4j instead.
Steps To Reproducehttps://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/blob/master/src/org/openbravo/retail/discounts/AddPack.java#L113 [^]
Proposed Solutionmove it to log4j.debug (as just debugging output anyway)
Additional Information
TagsNo tags attached.
Relationships
blocks design defect 0036162 acknowledged Triage Platform Base Openbravo ERP clean up openbravo.log 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-11-03 13:29shuehnerNew Issue
2021-11-03 13:29shuehnerAssigned To => Retail
2021-11-03 13:29shuehnerTriggers an Emergency Pack => No
2021-11-03 13:29shuehnerRelationship addedblocks 0036162
2021-11-03 13:30shuehnerProposed Solution updated
2021-11-03 13:35hgbotNote Added: 0132812
2021-11-03 14:21shuehnerIssue cloned0047967
2021-11-04 08:15hgbotNote Added: 0132822
2021-11-04 08:15hgbotNote Added: 0132823
2021-11-04 08:16marvintmStatusnew => scheduled
2021-11-04 08:16marvintmAssigned ToRetail => shuehner
2021-11-04 08:16marvintmStatusscheduled => resolved
2021-11-04 08:16marvintmFixed in Version => RR22Q1
2021-11-04 08:16marvintmResolutionopen => fixed
2021-11-04 08:16marvintmReview Assigned To => marvintm
2021-11-04 08:16marvintmStatusresolved => closed

Notes
(0132812)
hgbot   
2021-11-03 13:35   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/40 [^]
(0132822)
hgbot   
2021-11-04 08:15   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts [^]
Changeset: 7678200bb6dcc0f77593935769c3ebf919c8e71e
Author: Stefan Huehner <stefan.huehner@openbravo.com>
Date: 2021-11-03T13:37:38+01:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/7678200bb6dcc0f77593935769c3ebf919c8e71e [^]

Fix ISSUE-47964: Avoid System.out.println by using log4j instead

Some debugging output was using System.out.println which is bad logging
(goes to catalina.out, does not have any context).
Move it over to log4j api with debug level.

---
M src/org/openbravo/retail/discounts/AddPack.java
---
(0132823)
hgbot   
2021-11-04 08:15   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/40 [^]