0047640: OB.UTIL.encodeXMLMultiLineComponent returns empty string if there are lines larger than the width in 21Q2

Description

OB.UTIL.encodeXMLMultiLineComponent returns empty string for these case in 21Q2 while working correctly in earlier versions.
The only change is that in the OB.UTIL.wordwrap function that is called inside a .join('\n') has been removed;

In 19Q4.4:
return str.match(RegExp('.{1,' + width + '}(\\s|$)|\\S+?(\\s|$)', 'g')).join('\n');

In 21Q2:
return str.match(RegExp('.{1,' + width + '}(\\s|$)|\\S+?(\\s|$)', 'g'));

Steps To Reproduce

- In livebuilds 19Q4.4 release
- Login to the pos
- Open the console of the chrome developer tools
- Execute an example statement like
OB.UTIL.encodeXMLMultiLineComponent ('Line 1\nLine 2', 6)
to check the cases where the width is equal to or greater than the lines of the message.
- Execute another example statement like
OB.UTIL.encodeXMLMultiLineComponent ('Line 1\nLine 2', 5)
to check cases where the width is less than the lines of the message.

-Perform the same steps for livebuilds 21Q2 release and check that for the first case it works correctly while for the second it returns an empty string.

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

blocks

defect

0047395

closed

ranjith_qualiantech_com

OB.UTIL.encodeXMLMultiLineComponent returns empty string if there are lines larger than the width in 21Q2

Notes
(0131636) hgbot (developer) 2021-09-08 08:32	Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/286 [^]

(0131639) hgbot (developer) 2021-09-08 08:41	Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^] Changeset: 26252f80136a122607e5d026ba24c9bb95c5d29a Author: Ranjith S R <ranjith@qualiantech.com> Date: 2021-09-08T11:57:40+05:30 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/26252f80136a122607e5d026ba24c9bb95c5d29a [^] Fixed ISSUE-47640: Updated Util wordwrap function to append nextline character --- M web/org.openbravo.mobile.core/source/utils/ob-utilities.js ---

(0131640) hgbot (developer) 2021-09-08 08:41	Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/286 [^]

Issue History
Date Modified	Username	Field	Change
2021-09-07 07:26	ranjith_qualiantech_com	Type	defect => backport
2021-09-07 07:26	ranjith_qualiantech_com	Target Version	=> RR21Q2.3
2021-09-08 08:32	hgbot	Note Added: 0131636
2021-09-08 08:41	hgbot	Merge Request Status	open => approved
2021-09-08 08:41	hgbot	Resolution	open => fixed
2021-09-08 08:41	hgbot	Status	scheduled => closed
2021-09-08 08:41	hgbot	Fixed in Version	=> RR21Q2.3
2021-09-08 08:41	hgbot	Note Added: 0131639
2021-09-08 08:41	hgbot	Note Added: 0131640