0047640: OB.UTIL.encodeXMLMultiLineComponent returns empty string if there are lines larger than the width in 21Q2

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0047640

Retail Modules

Web POS

public

2021-07-14 16:46

2021-09-08 08:41

Reporter

Sergio_Gomez

Assigned To

ranjith_qualiantech_com

Priority

normal

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

RR21Q2.3

Fixed in Version

RR21Q2.3

Merge Request Status

approved

Review Assigned To

OBNetwork customer

OBPS

Support ticket

26293

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0047640: OB.UTIL.encodeXMLMultiLineComponent returns empty string if there are lines larger than the width in 21Q2

Description

OB.UTIL.encodeXMLMultiLineComponent returns empty string for these case in 21Q2 while working correctly in earlier versions.
The only change is that in the OB.UTIL.wordwrap function that is called inside a .join('\n') has been removed;

In 19Q4.4:
return str.match(RegExp('.{1,' + width + '}(\\s|$)|\\S+?(\\s|$)', 'g')).join('\n');

In 21Q2:
return str.match(RegExp('.{1,' + width + '}(\\s|$)|\\S+?(\\s|$)', 'g'));

Steps To Reproduce

- In livebuilds 19Q4.4 release
- Login to the pos
- Open the console of the chrome developer tools
- Execute an example statement like
OB.UTIL.encodeXMLMultiLineComponent ('Line 1\nLine 2', 6)
to check the cases where the width is equal to or greater than the lines of the message.
- Execute another example statement like
OB.UTIL.encodeXMLMultiLineComponent ('Line 1\nLine 2', 5)
to check cases where the width is less than the lines of the message.

-Perform the same steps for livebuilds 21Q2 release and check that for the first case it works correctly while for the second it returns an empty string.

Proposed Solution

Additional Information