Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0047433
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajoralways2021-07-21 20:542021-08-16 07:38
ReporterlbressanView Statuspublic 
Assigned Toprakashmurugesan88 
PriorityhighResolutionfixedFixed in VersionRR21Q4
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Toadrianromero
Regression level
Regression date2021-08-10
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0047433: Invoice reprint error on lines with discount

DescriptionWhen a ticket whit a discount is completed and reopened to reprint the invoice, it has ZERO in the price and total.
Before start following the steps, it's needed to apply this patch:

https://issues.openbravo.com/view.php?id=47216 [^]
Steps To ReproduceSteps:
1- Apply the patch: https://issues.openbravo.com/view.php?id=47216 [^]
2- Make a Sales order.
3- Add a line with a discount with the same price as the product.
4- Mark it to invoice.
5- Complete it.
6- Open the last ticket.
7- Reprint the invoice.
8- Check the prices between the original print and the duplicated.

TagsNo tags attached.
Attached Filesjpeg file icon WhatsApp Image 2021-07-15 at 17.42.34 (2).jpeg [^] (228,535 bytes) 2021-07-21 20:54

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0045866 closedranjith_qualiantech_com Print error when completing a ticket loaded from backoffice 

-  Notes
(0131055)
adrianromero (manager)
2021-08-10 14:35

 This invoice template is a legacy template that must be migrated to the new templates engine.

Details how to migrate legacy templates is documented here: http://wiki.openbravo.com/wiki/Retail:Developers_Guide/New_Javascript_template_engine_for_receipt_printer_and_customer_displays_documents#Migrating_legacy_templates [^]

Related issue 0045866 fix can be used as example on how to migrate legacy templates.
(0131056)
Practics (reporter)
2021-08-10 16:53

 This solution it's not correct, our problem is that netUnitPrice it's not the same when reprint the invoice

View video
https://youtu.be/p28FfH6ceug [^]
(0131119)
hgbot (developer)
2021-08-13 14:12

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/542 [^]
(0131126)
hgbot (developer)
2021-08-16 07:37

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/542 [^]
(0131127)
hgbot (developer)
2021-08-16 07:37

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: b65695c111a9ca5bac59a69196035860c215e331
Author: Prakash M <prakash@qualiantech.com>
Date: 2021-08-16T05:36:33+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/b65695c111a9ca5bac59a69196035860c215e331 [^]

Fixed BUG-47433: Fixes following calculation issue of following properties in invoice reprint
Without Tax - netUnitPrice, grossUnitPrice
With Tax - netUnitAmount, netUnitPrice

---
M src/org/openbravo/retail/posterminal/InvoiceLinesProperties.java
M web/org.openbravo.retail.posterminal/js/data/dataordertaxes.js
---
(0131128)
marvintm (manager)
2021-08-16 07:38

 With our last change, both the netUnitPrice and the netUnitAmount should be correct even when reprinting the invoice.

It's important to note that these values should be used if you want to show the amounts with discounts applied. If you want to display amounts without the discounts (so that you show the discounts in a separate line, for example), then you should use "base*" properties (baseNetAmount, baseGrossAmount, ...)

- Issue History
Date Modified Username Field Change
2021-07-21 20:54 lbressan New Issue
2021-07-21 20:54 lbressan Assigned To => Retail
2021-07-21 20:54 lbressan File Added: WhatsApp Image 2021-07-15 at 17.42.34 (2).jpeg
2021-07-21 20:54 lbressan Regression date => 2021-08-10
2021-07-21 20:54 lbressan Triggers an Emergency Pack => No
2021-07-21 20:58 lbressan Description Updated View Revisions
2021-07-21 20:58 lbressan Steps to Reproduce Updated View Revisions
2021-07-21 21:53 Practics Issue Monitored: Practics
2021-08-06 11:00 adrianromero Resolution time => 1628805600
2021-08-06 11:25 adrianromero Status new => acknowledged
2021-08-06 12:02 adrianromero Status acknowledged => scheduled
2021-08-06 12:02 adrianromero Assigned To Retail => prakashmurugesan88
2021-08-06 12:20 adrianromero Relationship added related to 0047510
2021-08-06 12:25 adrianromero Relationship deleted related to 0047510
2021-08-10 14:30 adrianromero Relationship added related to 0045866
2021-08-10 14:35 adrianromero Review Assigned To => adrianromero
2021-08-10 14:35 adrianromero Note Added: 0131055
2021-08-10 14:35 adrianromero Status scheduled => closed
2021-08-10 14:35 adrianromero Resolution open => no change required
2021-08-10 16:53 Practics Note Added: 0131056
2021-08-12 08:16 marvintm Status closed => new
2021-08-12 08:16 marvintm Resolution no change required => open
2021-08-12 14:14 prakashmurugesan88 Status new => scheduled
2021-08-13 14:12 hgbot Note Added: 0131119
2021-08-16 07:37 hgbot Resolution open => fixed
2021-08-16 07:37 hgbot Status scheduled => closed
2021-08-16 07:37 hgbot Note Added: 0131126
2021-08-16 07:37 hgbot Fixed in Version => RR21Q4
2021-08-16 07:37 hgbot Note Added: 0131127
2021-08-16 07:38 marvintm Note Added: 0131128

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker