Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0047365
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Coupons OTFmajoralways2021-07-08 14:342021-07-09 15:06
ReportermigueldejuanaView Statuspublic 
Assigned Tomigueldejuana 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0047365: Coupons with higher discount than line amount, generate negative lines

DescriptionApplying a Coupon, if the coupon have a higher value than the total gross of the line, we get a negative line.
In that case, we should apply the maximum amount and the line will have a 100% of discount.
Steps To Reproduce- Create or modify a coupon and set the value to 500€ for example.
- Go to web POS, add the coupon to the ticket (the lines must be less than 500€)
- We will have a discount higher that the line amount and we get a negative line
- ERROR! We cannot have negative lines due to a discount applied
TagsNOR
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0045405 closedranjith_qualiantech_com Error applying coupon. The last line is negative. 
related to defect 0047265 closedmigueldejuana Combos with higher discount than line amount, generate negative lines 

-  Notes
(0130344)
hgbot (developer)
2021-07-09 10:15

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf/-/merge_requests/14 [^]
(0130346)
hgbot (developer)
2021-07-09 10:36

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf [^]
Changeset: 857f16d5ddc6747dd382a1b63c305ffa83c93351
Author: Miguel de Juana <miguel.dejuana@openbravo.com>
Date: 2021-07-08T14:41:05+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf/-/commit/857f16d5ddc6747dd382a1b63c305ffa83c93351 [^]

Fixed ISSUE-0047365: Coupons with higher discount than line amount, generate negative lines

- Set discount amount to line amount when discount amount is higher

---
M web/org.openbravo.retail.discounts.coupons.otf/app/model/business-logic/discounts-engine/engine/rules/variable-amount-coupons-discount.js
---
(0130347)
hgbot (developer)
2021-07-09 10:36

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf/-/merge_requests/14 [^]

- Issue History
Date Modified Username Field Change
2021-07-08 14:34 migueldejuana New Issue
2021-07-08 14:34 migueldejuana Assigned To => migueldejuana
2021-07-08 14:34 migueldejuana OBNetwork customer => No
2021-07-08 14:34 migueldejuana Triggers an Emergency Pack => No
2021-07-08 14:34 migueldejuana Relationship added related to 0045405
2021-07-08 14:35 migueldejuana Relationship added related to 0047265
2021-07-09 10:15 hgbot Merge Request Status => open
2021-07-09 10:15 hgbot Note Added: 0130344
2021-07-09 10:35 hgbot Merge Request Status open => approved
2021-07-09 10:36 hgbot Resolution open => fixed
2021-07-09 10:36 hgbot Status new => closed
2021-07-09 10:36 hgbot Note Added: 0130346
2021-07-09 10:36 hgbot Note Added: 0130347
2021-07-09 15:06 rafaroda Tag Attached: NOR

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker